net: fix warning not initializing MAC address

PATCH New Heiko Schocher 2 participants 3 messages Sep 2, 2011 Networking

lore

Share & tools

lore

Heiko Schocher

author

2011-09-02 05:55 UTC #0 lore raw

PATCH 1/1 net: fix warning not initializing MAC address

following warning message blobs up, when initializing for example DaVinci EMAC:

Net: Ethernet PHY: KSZ8873 @ 0x02
DaVinci-EMACWarning: failed to set MAC address

Introduced from commit

commit 7616e7850804c7c69e0a22c179dfcba9e8f3f587

Author: Simon Glass <[email protected]>
Date:   Mon Jun 13 16:13:10 2011 -0700

Add Ethernet hardware MAC address framework to usbnet

Built-in Ethernet adapters support setting the mac address by means of a ethaddr environment variable for each interface (ethaddr, eth1addr, eth2addr).

This adds similar support to the USB network side, using the names usbethaddr, usbeth1addr, etc. They are kept separate since we don't want a USB device taking the MAC address of a built-in device or vice versa.

Signed-off-by Simon Glass <[email protected]>

Tested-by Eric B?nard <[email protected]>

Fix this!

Signed-off-by Heiko Schocher <[email protected]>

cc Simon Glass <[email protected]>

---
 net/eth.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

net/eth.c +1 -1

index a34fe59..2caaf60 100644
@@ -296,7 +296,7 @@ int eth_initialize(bd_t *bis)
 			if (strchr(dev->name, ' '))
 				puts("\nWarning: eth device name has a space!\n");
 
-			if (eth_write_hwaddr(dev, NULL, eth_number))
+			if (eth_write_hwaddr(dev, "eth", eth_number))
 				puts("Warning: failed to set MAC address\n");
 
 			eth_number++;

Signature · 1 line

1.7.6

Kumar Gala

2011-09-02 06:44 UTC #1 lore raw

PATCH 1/1 net: fix warning not initializing MAC address

Quoted 47 lines · Heiko Schocher

following warning message blobs up, when initializing for example DaVinci EMAC:
Net: Ethernet PHY: KSZ8873 @ 0x02
DaVinci-EMACWarning: failed to set MAC address
Introduced from commit
commit 7616e7850804c7c69e0a22c179dfcba9e8f3f587
Author: Simon Glass <[email protected]>
Date:   Mon Jun 13 16:13:10 2011 -0700
Add Ethernet hardware MAC address framework to usbnet
Built-in Ethernet adapters support setting the mac address by means of a ethaddr environment variable for each interface (ethaddr, eth1addr, eth2addr).
This adds similar support to the USB network side, using the names usbethaddr, usbeth1addr, etc. They are kept separate since we don't want a USB device taking the MAC address of a built-in device or vice versa.
Signed-off-by Simon Glass <[email protected]>
Tested-by Eric B?nard <[email protected]>
Fix this!
Signed-off-by Heiko Schocher <[email protected]>
cc Simon Glass <[email protected]>
---
net/eth.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
net/eth.c +1 -1
index a34fe59..2caaf60 100644
@@ -296,7 +296,7 @@ int eth_initialize(bd_t *bis)
 			if (strchr(dev->name, ' '))
 				puts("\nWarning: eth device name has a space!\n");
 
-			if (eth_write_hwaddr(dev, NULL, eth_number))
+			if (eth_write_hwaddr(dev, "eth", eth_number))
 				puts("Warning: failed to set MAC address\n");
 
 			eth_number++;
Signature · 1 line
1.7.6

We keep fixing this one ;)

http://patchwork.ozlabs.org/patch/112361/

- k

Heiko Schocher

author

2011-09-02 07:04 UTC #2 lore raw

PATCH 1/1 net: fix warning not initializing MAC address

Hello Kumar,

Quoted 46 lines · Kumar Gala

Quoted 44 lines · Heiko Schocher
following warning message blobs up, when initializing for example DaVinci EMAC:
Net: Ethernet PHY: KSZ8873 @ 0x02
DaVinci-EMACWarning: failed to set MAC address
Introduced from commit
commit 7616e7850804c7c69e0a22c179dfcba9e8f3f587
Author: Simon Glass <[email protected]>
Date:   Mon Jun 13 16:13:10 2011 -0700
Add Ethernet hardware MAC address framework to usbnet
Built-in Ethernet adapters support setting the mac address by means of a ethaddr environment variable for each interface (ethaddr, eth1addr, eth2addr).
This adds similar support to the USB network side, using the names usbethaddr, usbeth1addr, etc. They are kept separate since we don't want a USB device taking the MAC address of a built-in device or vice versa.
Signed-off-by Simon Glass <[email protected]>
Tested-by Eric B?nard <[email protected]>
Fix this!
Signed-off-by Heiko Schocher <[email protected]>
cc Simon Glass <[email protected]>
---
net/eth.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
net/eth.c +1 -1
index a34fe59..2caaf60 100644
@@ -296,7 +296,7 @@ int eth_initialize(bd_t *bis)
 			if (strchr(dev->name, ' '))
 				puts("\nWarning: eth device name has a space!\n");
 
-			if (eth_write_hwaddr(dev, NULL, eth_number))
+			if (eth_write_hwaddr(dev, "eth", eth_number))
 				puts("Warning: failed to set MAC address\n");
 

Quoted 7 lines

Quoted 3 lines
net/eth.c +0 -0
 			eth_number++;
Signature · 1 line
1.7.6
We keep fixing this one ;)
http://patchwork.ozlabs.org/patch/112361/

Good!
(Sorry for posting another fix, but just back from vacation, and didn;t found time for looking in the u-boot ml ... :-(

Thanks for the hint!
bye,
Heiko

Signature · 2 lines

DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany