Skip to contentSkip to conversation

EM28xx - Fix memory leak on disconnect or error.

PATCH New Chris Rankin 1 participant 1 message Sep 4, 2011 Media (V4L/DVB)

lore
Share & tools
lore

Chris Rankin

author
#0 lore raw

PATCH 1/1 EM28xx - Fix memory leak on disconnect or error.

Mauro,

This patch seems to have been missed, so I'm resending it.

Release the dev->alt_max_pkt_size buffer in all cases.

Signed-off-by Chris Rankin <[email protected]>

Cheers,
Chris

drivers/media/video/em28xx/em28xx-cards.c renamed from drivers/media/video/em28xx/em28xx-cards.c.orig +1 -0
@@ -3200,6 +3200,7 @@
 	retval = em28xx_init_dev(&dev, udev, interface, nr);
 	if (retval) {
 		mutex_unlock(&dev->lock);
+		kfree(dev->alt_max_pkt_size);
 		kfree(dev);
 		goto err;
 	}
drivers/media/video/em28xx/em28xx-video.c renamed from drivers/media/video/em28xx/em28xx-video.c.orig +1 -0
@@ -2200,6 +2200,7 @@
 		   free the remaining resources */
 		if (dev->state & DEV_DISCONNECTED) {
 			em28xx_release_resources(dev);
+			kfree(dev->alt_max_pkt_size);
 			kfree(dev);
 			return 0;
 		}