Skip to contentSkip to conversation

ARM: hawkboard: fix compilation of nand_spl

PATCH New Wolfgang Denk 2 participants 6 messages Sep 10, 2011 – Sep 11, 2011

lore
Share & tools
lore

Wolfgang Denk

author
#0 lore raw

PATCH 1/1 ARM: hawkboard: fix compilation of nand_spl

Fix build problem:

nand_spl/board/davinci/da8xxevm/hawkboard_nand_spl.c: In function 'board_init_f':
nand_spl/board/davinci/da8xxevm/hawkboard_nand_spl.c:132: warning: implicit declaration of function 'nand_boot' nand_spl/board/davinci/da8xxevm/hawkboard_nand_spl.c:133: warning: 'noreturn' function does return

Signed-off-by Wolfgang Denk <[email protected]>
Cc Syed Mohammed Khasim <[email protected]>
Cc Sughosh Ganu <[email protected]>
Cc Albert ARIBAUD <[email protected]>
---
 board/davinci/da8xxevm/hawkboard_nand_spl.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)
board/davinci/da8xxevm/hawkboard_nand_spl.c +1 -0
index 9155236..e5e65e5 100644
@@ -28,6 +28,7 @@
 #include <asm/io.h>
 #include <asm/arch/davinci_misc.h>
 #include <ns16550.h>
+#include <nand.h>
 
 DECLARE_GLOBAL_DATA_PTR;
Signature · 1 line
1.7.6
author Applied
#1 lore raw

PATCH 1/1 ARM: hawkboard: fix compilation of nand_spl

Dear Wolfgang Denk,

Quoted 6 lines · In message <[email protected]> you wrote:

Fix build problem:

nand_spl/board/davinci/da8xxevm/hawkboard_nand_spl.c: In function 'board_init_f':
nand_spl/board/davinci/da8xxevm/hawkboard_nand_spl.c:132: warning: implicit declaration of function 'nand_boot' nand_spl/board/davinci/da8xxevm/hawkboard_nand_spl.c:133: warning: 'noreturn' function does return

Quoted 7 lines
Signed-off-by Wolfgang Denk <[email protected]>
Cc Syed Mohammed Khasim <[email protected]>
Cc Sughosh Ganu <[email protected]>
Cc Albert ARIBAUD <[email protected]>
---
 board/davinci/da8xxevm/hawkboard_nand_spl.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

Applied, thanks.

Best regards,

Wolfgang Denk

Signature · 5 lines
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
An optimist believes we live in the best world possible; a  pessimist
fears this is true.
#2 lore raw

PATCH 1/1 ARM: hawkboard: fix compilation of nand_spl

Hi Wolfgang,

Le 10/09/2011 22:46, Wolfgang Denk a ?crit :

Quoted 17 lines

Dear Wolfgang Denk,

Quoted 6 lines · In message<[email protected]> you wrote:

Fix build problem:

nand_spl/board/davinci/da8xxevm/hawkboard_nand_spl.c: In function 'board_init_f':
nand_spl/board/davinci/da8xxevm/hawkboard_nand_spl.c:132: warning: implicit declaration of function 'nand_boot' nand_spl/board/davinci/da8xxevm/hawkboard_nand_spl.c:133: warning: 'noreturn' function does return

Quoted 7 lines
Signed-off-by Wolfgang Denk<[email protected]>
Cc Syed Mohammed Khasim<[email protected]>
Cc Sughosh Ganu<[email protected]>
Cc Albert ARIBAUD<[email protected]>
---
  board/davinci/da8xxevm/hawkboard_nand_spl.c |    1 +
  1 files changed, 1 insertions(+), 0 deletions(-)
Quoted 5 lines

Applied, thanks.

Best regards,

Wolfgang Denk

I'd already applied this patch from Stefano to u-boot-arm/master.

Amicalement,

Signature · 1 line
Albert.
#3 lore raw

PATCH 1/1 ARM: hawkboard: fix compilation of nand_spl

Le 11/09/2011 17:59, Albert ARIBAUD a ?crit :

Quoted 20 lines

Hi Wolfgang,

Le 10/09/2011 22:46, Wolfgang Denk a ?crit :

Quoted 17 lines

Dear Wolfgang Denk,

Quoted 13 lines · In message<[email protected]> you wrote:

Fix build problem:

nand_spl/board/davinci/da8xxevm/hawkboard_nand_spl.c: In function 'board_init_f':
nand_spl/board/davinci/da8xxevm/hawkboard_nand_spl.c:132: warning: implicit declaration of function 'nand_boot' nand_spl/board/davinci/da8xxevm/hawkboard_nand_spl.c:133: warning: 'noreturn' function does return

Signed-off-by Wolfgang Denk<[email protected]>
Cc Syed Mohammed Khasim<[email protected]>
Cc Sughosh Ganu<[email protected]>
Cc Albert ARIBAUD<[email protected]>
---
   board/davinci/da8xxevm/hawkboard_nand_spl.c |    1 +
   1 files changed, 1 insertions(+), 0 deletions(-)
Quoted 7 lines
Quoted 5 lines

Applied, thanks.

Best regards,

Wolfgang Denk

I'd already applied this patch from Stefano to u-boot-arm/master.

Correction: you, not I, had already applied a patch with the exact same title and different content.

Amicalement,

Signature · 1 line
Albert.
author
#4 lore raw

PATCH 1/1 ARM: hawkboard: fix compilation of nand_spl

Dear Albert ARIBAUD,

Quoted 5 lines · In message <[email protected]> you wrote:
Quoted 2 lines

I'd already applied this patch from Stefano to u-boot-arm/master.

Correction: you, not I, had already applied a patch with the exact same title and different content.

Yes, there were several problems with this board :-(

Best regards,

Wolfgang Denk

Signature · 7 lines
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
We're all sorry for the other guy when he loses his job to a machine.
But when it comes to your job -- that's different. And it always will
be different.
	-- McCoy, "The Ultimate Computer", stardate 4729.4
author
#5 lore raw

PATCH 1/1 ARM: hawkboard: fix compilation of nand_spl

In reply to Albert ARIBAUD

Dear Albert ARIBAUD,

Quoted 2 lines · In message <[email protected]> you wrote:

I'd already applied this patch from Stefano to u-boot-arm/master.

This is no problem - git will sort it out automatically.

Sorry for going ahead, I wanted to clean up the ARM build finally.

Best regards,

Wolfgang Denk

Signature · 5 lines
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
It all seemed, he thought, to be rather a lot of  trouble  to  go  to
just sharpen a razor blade.  - Terry Pratchett, _The Light Fantastic_