Skip to contentSkip to conversation

MX25: tx25: Avoid the usage of extern in C file

PATCH New Fabio Estevam 3 participants 4 messages Sep 6, 2011 – Sep 12, 2011

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH v6 1/2 MX25: tx25: Avoid the usage of extern in C file

Avoid the usage of extern in C file as pointed out by checkpatch.

---
Changes since v5:
- Only place mx25_uart1_init_pins inside sys_proto.h
Changes since v4:
- No changes
Changes since v3:
- Place mx25_uart1_init_pins inside sys_proto.h
Changes since v2:
- Place the extern in the MX25 imx-regs.h instead of inside the MX27 imx-regs.h Changes since v1:
- No changes

 arch/arm/include/asm/arch-mx25/sys_proto.h |   29 ++++++++++++++++++++++++++++
 board/karo/tx25/tx25.c                     |    3 +-
 2 files changed, 30 insertions(+), 2 deletions(-)
 create mode 100644 arch/arm/include/asm/arch-mx25/sys_proto.h
arch/arm/include/asm/arch-mx25/sys_proto.h new file +29 -0
new file mode 100644
index 0000000..6a01a7b
@@ -0,0 +1,29 @@
+/*
+ * (C) Copyright 2009
+ * Stefano Babic, DENX Software Engineering, sbabic at denx.de.
+ *
+ * See file CREDITS for list of people who contributed to this
+ * project.
+ *
+ * This program is free software; you can redistribute it and/or
+ * modify it under the terms of the GNU General Public License as
+ * published by the Free Software Foundation; either version 2 of
+ * the License, or (at your option) any later version.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ * GNU General Public License for more details.
+ *
+ * You should have received a copy of the GNU General Public License
+ * along with this program; if not, write to the Free Software
+ * Foundation, Inc., 59 Temple Place, Suite 330, Boston,
+ * MA 02111-1307 USA
+ */
+
+#ifndef _SYS_PROTO_H_
+#define _SYS_PROTO_H_
+
+void mx25_uart1_init_pins(void);
+
+#endif
board/karo/tx25/tx25.c +1 -2
index ce75468..307ffd0 100644
@@ -29,6 +29,7 @@
 #include <asm/arch/imx-regs.h>
 #include <asm/arch/imx25-pinmux.h>
 #include <asm/gpio.h>
+#include <asm/arch/sys_proto.h>
 
 static void mdelay(int n)
 {
@@ -142,8 +143,6 @@ void tx25_fec_init(void)
 int board_init()
 {
 #ifdef CONFIG_MXC_UART
-	extern void mx25_uart1_init_pins(void);
-
 	mx25_uart1_init_pins();
 #endif
 	/* board id for linux */
Signature · 1 line
1.7.1
#1 lore raw

PATCH v6 2/2 MX25: Add initial support for MX25PDK

Add the initial support for MX25PDK booting from SD card via internal boot.

---
Changes since v5:
- Include sys_proto.h
Changes since v4:
- No changes
Changes since v3:
- No changes
Changes since v2:
- No changes
Changes since v1:
- Keep mx25pdk entry to boards.cfg sorted
- Removed unused defines in mx25pdk.h
- Do not use the whole RAM space for memory test

 MAINTAINERS                             |    1 +
 board/freescale/mx25pdk/Makefile        |   49 ++++++++++++++
 board/freescale/mx25pdk/imximage.cfg    |   73 +++++++++++++++++++++
 board/freescale/mx25pdk/lowlevel_init.S |   21 ++++++
 board/freescale/mx25pdk/mx25pdk.c       |   63 ++++++++++++++++++
 boards.cfg                              |    1 +
 include/configs/mx25pdk.h               |  106 +++++++++++++++++++++++++++++++
 7 files changed, 314 insertions(+), 0 deletions(-)
 create mode 100644 board/freescale/mx25pdk/Makefile
 create mode 100644 board/freescale/mx25pdk/imximage.cfg
 create mode 100644 board/freescale/mx25pdk/lowlevel_init.S
 create mode 100644 board/freescale/mx25pdk/mx25pdk.c
 create mode 100644 include/configs/mx25pdk.h
MAINTAINERS +1 -0
index bd92b7f..a2ef556 100644
@@ -640,6 +640,7 @@ Kristoffer Ericson <[email protected]>
 
 Fabio Estevam <[email protected]>
 
+	mx25pdk		i.MX25
 	mx31pdk		i.MX31
 	mx53ard		i.MX53
 	mx53smd		i.MX53
board/freescale/mx25pdk/Makefile new file +49 -0

49 lines not on this page · raw message

board/freescale/mx25pdk/imximage.cfg new file +73 -0

73 lines not on this page · raw message

board/freescale/mx25pdk/lowlevel_init.S new file +21 -0
new file mode 100644
index 0000000..6e6810f
@@ -0,0 +1,21 @@
+/*
+ * Copyright (c) 2011  Freescale Semiconductor
+ *
+ * See file CREDITS for list of people who contributed to this
+ * project.
+ *
+ * This program is free software; you can redistribute it and/or
+ * modify it under the terms of the GNU General Public License as
+ * published by the Free Software Foundation; either version 2 of
+ * the License, or (at your option) any later version.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ * GNU General Public License for more details.
+ */
+
+.globl lowlevel_init
+lowlevel_init:
+
+	mov	pc, lr
board/freescale/mx25pdk/mx25pdk.c new file +63 -0

63 lines not on this page · raw message

boards.cfg +1 -0
index 4770831..7c5cf62 100644
@@ -150,6 +150,7 @@ rd6281a                      arm         arm926ejs   -                   Marvell
 sheevaplug                   arm         arm926ejs   -                   Marvell        kirkwood
 dockstar                     arm         arm926ejs   -                   Seagate        kirkwood
 jadecpu                      arm         arm926ejs   jadecpu             syteco         mb86r0x
+mx25pdk                      arm         arm926ejs   mx25pdk             freescale      mx25		mx25pdk:IMX_CONFIG=board/freescale/mx25pdk/imximage.cfg
 zmx25                        arm         arm926ejs   zmx25               syteco         mx25
 imx27lite                    arm         arm926ejs   imx27lite           logicpd        mx27
 magnesium                    arm         arm926ejs   imx27lite           logicpd        mx27
include/configs/mx25pdk.h new file +106 -0

106 lines not on this page · raw message

Signature · 1 line
1.7.1
#3 lore raw

PATCH v6 1/2 MX25: tx25: Avoid the usage of extern in C file

Quoted 9 lines · Fabio Estevam

Hi Stefano,

Quoted 3 lines · Fabio Estevam

Avoid the usage of extern in C file as pointed out by checkpatch.

Does v6 series look good now?

Yes, I have rebased your patch due to changes in boards.cfg and put on my private next branch. Due to incoming release, I have not yet officially pushed, but I will merge them after 2011.09 is out.

I have now published my next branch, and you can take a look what I have currently taken to be merged. Except for the changes in main Makefile, because these patches should be picked or rejected by Wolfgang.

Best regards,
Stefano Babic

Signature · 5 lines
=====================================================================
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-0 Fax: +49-8142-66989-80  Email: office at denx.de
=====================================================================