Skip to contentSkip to conversation

MX25: tx25: Pass NAND_U_BOOT option

PATCH New Fabio Estevam 2 participants 4 messages Sep 13, 2011 – Sep 14, 2011

lore
Share & tools
lore

Fabio Estevam

author
#0 lore raw

PATCH 1/1 MX25: tx25: Pass NAND_U_BOOT option

commit e5226e63 (Makefile: remove tx25 exception) missed to pass NAND_U_BOOT option when moving tx25 target to boards.cfg.

Signed-off-by Fabio Estevam <[email protected]>
---
 boards.cfg |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
boards.cfg +1 -1
index 1e2ff43..58f677f 100644
@@ -148,7 +148,7 @@ sheevaplug                   arm         arm926ejs   -                   Marvell
 dockstar                     arm         arm926ejs   -                   Seagate        kirkwood
 jadecpu                      arm         arm926ejs   jadecpu             syteco         mb86r0x
 mx25pdk                      arm         arm926ejs   mx25pdk             freescale      mx25		mx25pdk:IMX_CONFIG=board/freescale/mx25pdk/imximage.cfg
-tx25                         arm         arm926ejs   tx25                karo           mx25
+tx25                         arm         arm926ejs   tx25                karo           mx25		tx25:NAND_U_BOOT
 zmx25                        arm         arm926ejs   zmx25               syteco         mx25
 imx27lite                    arm         arm926ejs   imx27lite           logicpd        mx27
 magnesium                    arm         arm926ejs   imx27lite           logicpd        mx27
Signature · 1 line
1.7.1
#1 lore raw

PATCH 1/1 MX25: tx25: Pass NAND_U_BOOT option

Quoted 4 lines · Fabio Estevam

commit e5226e63 (Makefile: remove tx25 exception) missed to pass NAND_U_BOOT option when moving tx25 target to boards.cfg.

Signed-off-by Fabio Estevam <[email protected]>

Hi Fabio,

Quoted 3 lines
---
 boards.cfg |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

Right, that is true. However, the patch is not yet in mainline, I have errouneously put it into my next branch (I should not), and we can modify the original patch before merging.

The patch is already in "Change requested" status, because also Wolfgang found that I missed NAND_U_BOOT. I have really forgotten to resend a new version, and thanks for your remind and for checking my next branch ;-). I will send V2.

Best regards,
Stefano Babic

Signature · 5 lines
=====================================================================
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-0 Fax: +49-8142-66989-80  Email: office at denx.de
=====================================================================
#2 lore raw

PATCH 1/1 MX25: tx25: Pass NAND_U_BOOT option

In reply to Fabio Estevam
Quoted 8 lines · Fabio Estevam

commit e5226e63 (Makefile: remove tx25 exception) missed to pass NAND_U_BOOT option when moving tx25 target to boards.cfg.

Signed-off-by Fabio Estevam <[email protected]>
---
 boards.cfg |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

Hi Fabio,

boards.cfg sheevaplug arm arm926ejs - Marvell · line 154

Quoted 13 lines
boards.cfg +1 -1
index 1e2ff43..58f677f 100644
@@ -148,7 +148,7 @@ sheevaplug                   arm         arm926ejs   -                   Marvell
 dockstar                     arm         arm926ejs   -                   Seagate        kirkwood
 jadecpu                      arm         arm926ejs   jadecpu             syteco         mb86r0x
 mx25pdk                      arm         arm926ejs   mx25pdk             freescale      mx25		mx25pdk:IMX_CONFIG=board/freescale/mx25pdk/imximage.cfg
-tx25                         arm         arm926ejs   tx25                karo           mx25
+tx25                         arm         arm926ejs   tx25                karo           mx25		tx25:NAND_U_BOOT
 zmx25                        arm         arm926ejs   zmx25               syteco         mx25
 imx27lite                    arm         arm926ejs   imx27lite           logicpd        mx27
 magnesium                    arm         arm926ejs   imx27lite           logicpd        mx27

I was too fast...I reread the whole thread
(http://patchwork.ozlabs.org/patch/112080/)
CONFIG_NAND_U_BOOT is defined in tx25.h, and there is no need to define
it again. I think the actual patch is ok. Have you seen any problem ?

Best regards,
Stefano Babic

Signature · 5 lines
=====================================================================
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-0 Fax: +49-8142-66989-80  Email: office at denx.de
=====================================================================
author
#3 lore raw

PATCH 1/1 MX25: tx25: Pass NAND_U_BOOT option

On Wed, Sep 14, 2011 at 4:45 AM, Stefano Babic <[email protected]> wrote:
...

Quoted 4 lines

I was too fast...I reread the whole thread
(http://patchwork.ozlabs.org/patch/112080/)
?CONFIG_NAND_U_BOOT is defined in tx25.h, and there is no need to define it again. I think the actual patch is ok. Have you seen any problem ?

Ok, thanks for the clarification. Your original patch looks good then.

Regards,

Fabio Estevam