mx31pdk: Disable watchdog

PATCH New Fabio Estevam 3 participants 10 messages Sep 15, 2011 – Sep 19, 2011

lore

Share & tools

lore

Fabio Estevam

author

2011-09-15 23:18 UTC #0 lore raw

PATCH 1/2 mx31pdk: Disable watchdog

When booting a mainline kernel on a mx31pdk the system gets getting resets from the watchdog.

As the kernel has watchdog support, disable it from U-boot.

Signed-off-by Fabio Estevam <[email protected]>

---
 include/configs/mx31pdk.h |    1 -
 1 files changed, 0 insertions(+), 1 deletions(-)

include/configs/mx31pdk.h +0 -1

index 1a5bdd1..e77805c 100644
@@ -60,7 +60,6 @@
 
 #define CONFIG_MXC_UART
 #define CONFIG_SYS_MX31_UART1
-#define CONFIG_HW_WATCHDOG
 #define CONFIG_MXC_GPIO
 
 #define CONFIG_HARD_SPI

Signature · 1 line

1.6.0.4

Fabio Estevam

author

2011-09-15 23:18 UTC #1 lore raw

PATCH 2/2 mx31pdk: Change the prompt as per other i.MX boards

Change the prompt as done in other i.MX boards.

Signed-off-by Fabio Estevam <[email protected]>

---
 include/configs/mx31pdk.h |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

include/configs/mx31pdk.h +1 -1

index e77805c..7f91f67 100644
@@ -123,7 +123,7 @@
  * Miscellaneous configurable options
  */
 #define CONFIG_SYS_LONGHELP	/* undef to save memory */
-#define CONFIG_SYS_PROMPT	"uboot> "
+#define CONFIG_SYS_PROMPT	"MX31PDK U-Boot > "
 #define CONFIG_SYS_CBSIZE	256	/* Console I/O Buffer Size */
 /* Print Buffer Size */
 #define CONFIG_SYS_PBSIZE	(CONFIG_SYS_CBSIZE + \

Signature · 1 line

1.6.0.4

Stefano Babic

2011-09-16 11:38 UTC #2 lore raw

PATCH 2/2 mx31pdk: Change the prompt as per other i.MX boards

Quoted 12 lines · Fabio Estevam

Change the prompt as done in other i.MX boards.
Signed-off-by Fabio Estevam <[email protected]>
---
 include/configs/mx31pdk.h |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
include/configs/mx31pdk.h +0 -0
index e77805c..7f91f67 100644

include/configs/mx31pdk.h line 129

Quoted 8 lines

include/configs/mx31pdk.h +1 -1

@@ -123,7 +123,7 @@
  * Miscellaneous configurable options
  */
 #define CONFIG_SYS_LONGHELP	/* undef to save memory */
-#define CONFIG_SYS_PROMPT	"uboot> "
+#define CONFIG_SYS_PROMPT	"MX31PDK U-Boot > "
 #define CONFIG_SYS_CBSIZE	256	/* Console I/O Buffer Size */
 /* Print Buffer Size */
 #define CONFIG_SYS_PBSIZE	(CONFIG_SYS_CBSIZE + \

Acked-by Stefano Babic <[email protected]>

Best regards,
Stefano Babic

Signature · 5 lines

=====================================================================
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-0 Fax: +49-8142-66989-80  Email: office at denx.de
=====================================================================

Stefano Babic

2011-09-19 09:35 UTC #3 lore raw

PATCH 2/2 mx31pdk: Change the prompt as per other i.MX boards

In reply to Fabio Estevam

Quoted 4 lines · Fabio Estevam

Change the prompt as done in other i.MX boards.
Signed-off-by Fabio Estevam <[email protected]>
---

Hi Fabio,

Quoted 8 lines

 include/configs/mx31pdk.h |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

include/configs/mx31pdk.h +0 -0

index e77805c..7f91f67 100644

include/configs/mx31pdk.h line 129

Quoted 8 lines

include/configs/mx31pdk.h +1 -1

@@ -123,7 +123,7 @@
  * Miscellaneous configurable options
  */
 #define CONFIG_SYS_LONGHELP	/* undef to save memory */
-#define CONFIG_SYS_PROMPT	"uboot> "
+#define CONFIG_SYS_PROMPT	"MX31PDK U-Boot > "
 #define CONFIG_SYS_CBSIZE	256	/* Console I/O Buffer Size */
 /* Print Buffer Size */
 #define CONFIG_SYS_PBSIZE	(CONFIG_SYS_CBSIZE + \

Applied to u-boot-imx, next branch, thanks.

Best regards,
Stefano Babic

Signature · 5 lines

=====================================================================
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-0 Fax: +49-8142-66989-80  Email: office at denx.de
=====================================================================

Stefano Babic

2011-09-16 07:46 UTC #4 lore raw

PATCH 1/2 mx31pdk: Disable watchdog

In reply to Fabio Estevam

On 09/16/2011 01:18 AM, Fabio Estevam wrote:

Hi Fabio,

Quoted 3 lines

When booting a mainline kernel on a mx31pdk the system gets getting resets from the watchdog.
As the kernel has watchdog support, disable it from U-boot.

But if the kernel has support for watchdog, why does the system reset ? I checked this board and the watchdog in u-boot is set to 64 seconds, that is the maximum value. It is surely enough for kernel to boot and to start triggering the watchdog. If the system still reboots, it seems to me that this is an issue to be fixed in kernel, not in u-boot. I am sure I have tested in the past (not recently) the QONG board with enabled watchdog, using also the imx2_wdt driver in kernel.

The watchdog in u-boot helps if u-boot hangs somewhere, for example transfering the image from media. It is a different feature.

Best regards,
Stefano Babic

Signature · 5 lines

=====================================================================
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-0 Fax: +49-8142-66989-80  Email: office at denx.de
=====================================================================

Fabio Estevam

author

2011-09-19 15:04 UTC #5 lore raw

PATCH 1/2 mx31pdk: Disable watchdog

Hi Stefano,

Quoted 8 lines · Stefano Babic

On 09/16/2011 01:18 AM, Fabio Estevam wrote:
Hi Fabio,
Quoted 3 lines
When booting a mainline kernel on a mx31pdk the system gets getting resets from the watchdog.
As the kernel has watchdog support, disable it from U-boot.

Quoted 7 lines

But if the kernel has support for watchdog, why does the system reset ? I checked this board and the watchdog in u-boot is set to 64 seconds, that is the maximum value. It is surely enough for kernel to boot and to start triggering the watchdog. If the system still reboots, it seems to me that this is an issue to be fixed in kernel, not in u-boot. I am sure I have tested in the past (not recently) the QONG board with enabled watchdog, using also the imx2_wdt driver in kernel.

I have sent a patch to the ARM kernel list to add watchdog support for qong board:
http://lists.infradead.org/pipermail/linux-arm-kernel/2011-September/065698.html

Can you please try it and let me know if you get resets when watchdog is enabled in U-boot
and kernel?

Thanks,

Fabio Estevam

Stefano Babic

2011-09-19 16:24 UTC #6 lore raw

PATCH 1/2 mx31pdk: Disable watchdog

Quoted 19 lines · Fabio Estevam

Hi Stefano,
Quoted 8 lines · Stefano Babic
On 09/16/2011 01:18 AM, Fabio Estevam wrote:
Hi Fabio,
Quoted 3 lines
When booting a mainline kernel on a mx31pdk the system gets getting resets from the watchdog.
As the kernel has watchdog support, disable it from U-boot.
Quoted 7 lines
But if the kernel has support for watchdog, why does the system reset ? I checked this board and the watchdog in u-boot is set to 64 seconds, that is the maximum value. It is surely enough for kernel to boot and to start triggering the watchdog. If the system still reboots, it seems to me that this is an issue to be fixed in kernel, not in u-boot. I am sure I have tested in the past (not recently) the QONG board with enabled watchdog, using also the imx2_wdt driver in kernel.

Quoted 3 lines

I have sent a patch to the ARM kernel list to add watchdog support for qong board:
http://lists.infradead.org/pipermail/linux-arm-kernel/2011-September/065698.html

Ok, thanks.

Quoted 4 lines

Can you please try it and let me know if you get resets when watchdog is enabled in U-boot
and kernel?

It works, the board does not get reset (of course, it is required to trigger at least once the watchdog under the kernel). I send my Tested-by to linux-arm.

Best regards,
Stefano Babic

Signature · 5 lines

=====================================================================
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-0 Fax: +49-8142-66989-80  Email: office at denx.de
=====================================================================

Fabio Estevam

author

2011-09-19 16:57 UTC #7 lore raw

PATCH 1/2 mx31pdk: Disable watchdog

On Mon, Sep 19, 2011 at 1:24 PM, Stefano Babic <[email protected]> wrote:
...

Quoted 3 lines

It works, the board does not get reset (of course, it is required to trigger at least once the watchdog under the kernel). I send my Tested-by to linux-arm.

Yes, looks like on my mx31pdk the kernel never services the watchdog.

Will try to debug the kernel then.

Thanks for testing it on qong board.

Regards,

Fabio Estevam

author

2011-09-19 17:47 UTC #8 lore raw

PATCH 1/2 mx31pdk: Disable watchdog

Hi Stefano,

Quoted 5 lines · Fabio Estevam

On Mon, Sep 19, 2011 at 1:24 PM, Stefano Babic <[email protected]> wrote:
...
Quoted 3 lines
It works, the board does not get reset (of course, it is required to trigger at least once the watchdog under the kernel). I send my Tested-by to linux-arm.

I managed to fix this and will submit a patch for U-boot shortly.

Regards,

Fabio Estevam

Sergei Shtylyov

2011-09-16 11:10 UTC #9 lore raw

PATCH 1/2 mx31pdk: Disable watchdog

In reply to Fabio Estevam

Hello.

Quoted 1 line · Fabio Estevam

When booting a mainline kernel on a mx31pdk the system gets getting resets from the watchdog.

That's tautological. Maybe "is getting reset"?

Quoted 3 lines

As the kernel has watchdog support, disable it from U-boot.
Signed-off-by Fabio Estevam<[email protected]>

WBR, Sergei