Skip to contentSkip to conversation

Strip trailing slashes on PHYSICALDRIVE%d paths when making Windows CreateFile calls.

PATCH Applied Mario Limonciello 2 participants 2 messages Sep 21, 2011 – Sep 29, 2011

lore
Share & tools
lore
#0 lore raw

PATCH 3/3 Strip trailing slashes on PHYSICALDRIVE%d paths when making Windows CreateFile calls.

=== modified file 'ChangeLog'

ChangeLog 2011-09-21 20:39:06 +0000 renamed from ChangeLog 2011-09-21 20:38:06 +0000 +2 -0
@@ -2,6 +2,8 @@
 
     * Remove extra declaration of sleep for mingw32.
     * No realpath on mingw32.  Instead use _fullpath.
+    * Strip trailing slashes on PHYSICALDRIVE%d paths when making
+    Windows CreateFile calls.
 
 2011-09-17  Grégoire Sutre <[email protected]>
 

=== modified file 'util/misc.c'

misc.c 2011-09-21 20:39:06 +0000 renamed from misc.c 2011-09-21 20:36:50 +0000 +2 -0
@@ -55,6 +55,7 @@
 #ifdef __MINGW32__
 #include <windows.h>
 #include <winioctl.h>
+#include "dirname.h"
 #endif
 
 #ifdef GRUB_UTIL
@@ -322,6 +323,7 @@
   HANDLE hd;
   grub_int64_t size = -1LL;
 
+  strip_trailing_slashes(name);
   hd = CreateFile (name, GENERIC_READ, FILE_SHARE_READ | FILE_SHARE_WRITE,
                    0, OPEN_EXISTING, 0, 0);
 

=== modified file 'ChangeLog'

ChangeLog +2 -0
@@ -2,6 +2,8 @@
 
 	* Remove extra declaration of sleep for mingw32.
 	* No realpath on mingw32.  Instead use _fullpath.
+	* Strip trailing slashes on PHYSICALDRIVE%d paths when making
+	Windows CreateFile calls.
 
 2011-09-17  Grégoire Sutre  <[email protected]>
 

=== modified file 'util/misc.c'

misc.c +2 -0
@@ -55,6 +55,7 @@
 #ifdef __MINGW32__
 #include <windows.h>
 #include <winioctl.h>
+#include "dirname.h"
 #endif
 
 #ifdef GRUB_UTIL
@@ -322,6 +323,7 @@
   HANDLE hd;
   grub_int64_t size = -1LL;
 
+  strip_trailing_slashes(name);
   hd = CreateFile (name, GENERIC_READ, FILE_SHARE_READ | FILE_SHARE_WRITE,
                    0, OPEN_EXISTING, 0, 0);
 
#1 lore raw

Committed. Thanks

Quoted 39 lines · Mario Limonciello

=== modified file 'ChangeLog'

ChangeLog 2011-09-21 20:39:06 +0000 renamed from ChangeLog 2011-09-21 20:38:06 +0000 +2 -0
@@ -2,6 +2,8 @@
 
     * Remove extra declaration of sleep for mingw32.
     * No realpath on mingw32.  Instead use _fullpath.
+    * Strip trailing slashes on PHYSICALDRIVE%d paths when making
+    Windows CreateFile calls.
 
 2011-09-17  Grégoire Sutre <[email protected]>
 

=== modified file 'util/misc.c'

misc.c 2011-09-21 20:39:06 +0000 renamed from misc.c 2011-09-21 20:36:50 +0000 +2 -0
@@ -55,6 +55,7 @@
 #ifdef __MINGW32__
 #include <windows.h>
 #include <winioctl.h>
+#include "dirname.h"
 #endif
 
 #ifdef GRUB_UTIL
@@ -322,6 +323,7 @@
   HANDLE hd;
   grub_int64_t size = -1LL;
 
+  strip_trailing_slashes(name);
   hd = CreateFile (name, GENERIC_READ, FILE_SHARE_READ |
 FILE_SHARE_WRITE,
                    0, OPEN_EXISTING, 0, 0);

_______________________________________________
Grub-devel mailing list
[email protected]
https://lists.gnu.org/mailman/listinfo/grub-devel

Signature · 2 lines
Regards
Vladimir 'φ-coder/phcoder' Serbinenko