Skip to contentSkip to conversation

EfikaMX: Adjust undocumented magic constant in config file

PATCH New Marek Vasut 2 participants 2 messages Sep 15, 2011 – Sep 22, 2011

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 EfikaMX: Adjust undocumented magic constant in config file

This magic constant with zero documentation, when it's last 8 bits are set to 0x45, configures correctly the PERCLK dividers. Therefore the I2C operates correctly when divider computed from PERCLK.

Note: This constant is written to CBCDR register in arch/arm/cpu/armv7/mx5/lowlevel_init.S, but it's written only once. The register is accessed three more times in the file, with different values written to it each time.

---
 include/configs/efikamx.h |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
include/configs/efikamx.h +1 -1
index d4e77c2..1fa29d2 100644
@@ -284,6 +284,6 @@
 	(CONFIG_SYS_INIT_RAM_ADDR + CONFIG_SYS_INIT_SP_OFFSET)
 
 #define CONFIG_SYS_DDR_CLKSEL		0
-#define CONFIG_SYS_CLKTL_CBCDR		0x59E35100
+#define CONFIG_SYS_CLKTL_CBCDR		0x59E35145
 
 #endif
Signature · 1 line
1.7.5.4
#1 lore raw

PATCH 1/1 EfikaMX: Adjust undocumented magic constant in config file

Quoted 19 lines · Marek Vasut

This magic constant with zero documentation, when it's last 8 bits are set to 0x45, configures correctly the PERCLK dividers. Therefore the I2C operates correctly when divider computed from PERCLK.

Note: This constant is written to CBCDR register in arch/arm/cpu/armv7/mx5/lowlevel_init.S, but it's written only once. The register is accessed three more times in the file, with different values written to it each time.

---
 include/configs/efikamx.h |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
include/configs/efikamx.h +0 -0
index d4e77c2..1fa29d2 100644

include/configs/efikamx.h line 289

Quoted 7 lines
include/configs/efikamx.h +1 -1
@@ -284,6 +284,6 @@
 	(CONFIG_SYS_INIT_RAM_ADDR + CONFIG_SYS_INIT_SP_OFFSET)
 
 #define CONFIG_SYS_DDR_CLKSEL		0
-#define CONFIG_SYS_CLKTL_CBCDR		0x59E35100
+#define CONFIG_SYS_CLKTL_CBCDR		0x59E35145
 
 #endif

Applied to u-boot-imx, next branch.

Best regards,
Stefano Babic

Signature · 5 lines
=====================================================================
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-0 Fax: +49-8142-66989-80  Email: office at denx.de
=====================================================================