Skip to contentSkip to conversation

OMAP3: beagle: Fix build warning in beagle.c

PATCH New Dirk Behme 3 participants 3 messages Sep 22, 2011

lore
Share & tools
lore

Dirk Behme

author
#0 lore raw

PATCH 1/1 OMAP3: beagle: Fix build warning in beagle.c

From: Dirk Behme <[email protected]>

Fix build warning

beagle.c:532: warning: initialization from incompatible pointer type

CC Jason Kridner <[email protected]>
CC Koen Kooi <[email protected]>
CC Joel A Fernandes <[email protected]>
Cc Greg Turner <[email protected]>
CC Sandeep Paulraj <[email protected]>

---
Note: This seems to be introduced with the commit

"BeagleBoard: Added userbutton command"

http://git.denx.de/?p=u-boot.git;a=commit;h=f835ea7158025818d69384a7ebd8c3de0f10a9f7

 board/ti/beagle/beagle.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
board/ti/beagle/beagle.c +1 -1
Index: u-boot.git/board/ti/beagle/beagle.c
===================================================================
@@ -486,7 +486,7 @@ int ehci_hcd_init(void)
  * Returns - 	1 if button is held down
  *		0 if button is not held down
  */
-int do_userbutton (cmd_tbl_t *cmdtp, int flag, int argc, char *argv[])
+int do_userbutton(cmd_tbl_t *cmdtp, int flag, int argc, char * const argv[])
 {
 	int     button = 0;
 	int	gpio;
#1 lore raw

PATCH 1/1 OMAP3: beagle: Fix build warning in beagle.c

Quoted 8 lines · Dirk Behme

From: Dirk Behme <[email protected]>

Fix build warning

beagle.c:532: warning: initialization from incompatible pointer type

CC Jason Kridner <[email protected]>
Quoted 29 lines
CC Koen Kooi <[email protected]>
CC Joel A Fernandes <[email protected]>
Cc Greg Turner <[email protected]>
CC Sandeep Paulraj <[email protected]>

---
Note: This seems to be introduced with the commit

"BeagleBoard: Added userbutton command"

http://git.denx.de/?p=u-boot.git;a=commit;h=f835ea7158025818d69384a7ebd8c3de0f10a9f7

?board/ti/beagle/beagle.c | ? ?2 +-
?1 file changed, 1 insertion(+), 1 deletion(-)

Index: u-boot.git/board/ti/beagle/beagle.c
===================================================================

board/ti/beagle/beagle.c +0 -0
@@ -486,7 +486,7 @@ int ehci_hcd_init(void)

?* Returns - ? 1 if button is held down
?* ? ? ? ? ? ? 0 if button is not held down ?*/

board/ti/beagle/beagle.c +1 -1
-int do_userbutton (cmd_tbl_t *cmdtp, int flag, int argc, char *argv[])
+int do_userbutton(cmd_tbl_t *cmdtp, int flag, int argc, char * const argv[])

?{
? ? ? ?int ? ? button = 0;
? ? ? ?int ? ? gpio;

#2 lore raw

PATCH 1/1 OMAP3: beagle: Fix build warning in beagle.c

In reply to Dirk Behme

Hi Dirk,

Le 22/09/2011 13:53, Dirk Behme a ?crit :

Quoted 6 lines

From: Dirk Behme<[email protected]>

Fix build warning

beagle.c:532: warning: initialization from incompatible pointer type

Quoted 8 lines
CC Jason Kridner<[email protected]>
CC Koen Kooi<[email protected]>
CC Joel A Fernandes<[email protected]>
Cc Greg Turner<[email protected]>
CC Sandeep Paulraj<[email protected]>

---

Applied to u-boot-arm/master, thanks!

Amicalement,

Signature · 1 line
Albert.