shared-mime-info: add libxml-parser-perl to DEPENDS

PATCH In review Darren Hart 4 participants 10 messages Sep 22, 2011

lore

Share & tools

lore

Darren Hart

author

2011-09-22 18:55 UTC #0 lore raw

cover shared-mime-info: add libxml-parser-perl to DEPENDS

The following changes since commit ff8f0ea563ba3e9d6f8b8e770cfbf4dca8ad5288:

libxml2: reinclude a -staticdev package (2011-09-22 05:12:31 +0100)

are available in the git repository at:
git://git.pokylinux.org/poky-contrib dvhart/qemuppc
http://git.pokylinux.org/cgit.cgi/poky-contrib/log/?h=dvhart/qemuppc

Darren Hart (1):
shared-mime-info: add libxml-parser-perl to DEPENDS

 .../shared-mime-info/shared-mime-info.inc          |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

Signature · 1 line

1.7.6.2

Darren Hart

author

2011-09-22 18:55 UTC #1 lore raw

PATCH 1/1 shared-mime-info: add libxml-parser-perl to DEPENDS

Fixes [YOCTO #1514]

Building core-image-minimal on qemuppc (and likely others) can fail in the shared-mime-info configure step with the following error:

checking for XML::Parser... configure: error: XML::Parser perl module is required for intltool

Adding libxml-parser-perl to DEPENDS allows share-mime-info-native to build successfully.

Testing: build tested the native version on qemuppc. I run into tool chain build failures before I can get to building the target version.

Signed-off-by Darren Hart <[email protected]>

CC Joshua Lock <[email protected]>

---
 .../shared-mime-info/shared-mime-info.inc          |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

meta/recipes-support/shared-mime-info/shared-mime-info.inc +2 -2

index 64eef9d..e206305 100644
@@ -5,8 +5,8 @@ SECTION = "base"
 LICENSE = "GPLv2+"
 LIC_FILES_CHKSUM = "file://COPYING;md5=0636e73ff0215e8d672dc4c32c317bb3"
 
-DEPENDS = "libxml2 intltool-native glib-2.0 shared-mime-info-native"
-DEPENDS_virtclass-native = "libxml2-native intltool-native glib-2.0-native"
+DEPENDS = "libxml2 intltool-native glib-2.0 shared-mime-info-native libxml-parser-perl"
+DEPENDS_virtclass-native = "libxml2-native intltool-native glib-2.0-native libxml-parser-perl-native"
 
 SRC_URI = "http://freedesktop.org/~hadess/shared-mime-info-${PV}.tar.bz2"

Signature · 1 line

1.7.6.2

Richard Purdie

2011-09-22 20:04 UTC #2 lore raw

Quoted 25 lines · Darren Hart

Fixes [YOCTO #1514]
Building core-image-minimal on qemuppc (and likely others) can fail in the shared-mime-info configure step with the following error:
checking for XML::Parser... configure: error: XML::Parser perl module is required for intltool
Adding libxml-parser-perl to DEPENDS allows share-mime-info-native to build successfully.
Testing: build tested the native version on qemuppc. I run into tool chain build failures before I can get to building the target version.
Signed-off-by Darren Hart <[email protected]>
CC Joshua Lock <[email protected]>
---
 .../shared-mime-info/shared-mime-info.inc          |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)
meta/recipes-support/shared-mime-info/shared-mime-info.inc +0 -0
index 64eef9d..e206305 100644

meta/recipes-support/shared-mime-info/shared-mime-info.inc SECTION = "base" · line 11

Quoted 9 lines

meta/recipes-support/shared-mime-info/shared-mime-info.inc +2 -2

@@ -5,8 +5,8 @@ SECTION = "base"
 LICENSE = "GPLv2+"
 LIC_FILES_CHKSUM = "file://COPYING;md5=0636e73ff0215e8d672dc4c32c317bb3"
 
-DEPENDS = "libxml2 intltool-native glib-2.0 shared-mime-info-native"
-DEPENDS_virtclass-native = "libxml2-native intltool-native glib-2.0-native"
+DEPENDS = "libxml2 intltool-native glib-2.0 shared-mime-info-native libxml-parser-perl"
+DEPENDS_virtclass-native = "libxml2-native intltool-native glib-2.0-native libxml-parser-perl-native"
 
 SRC_URI = "http://freedesktop.org/~hadess/shared-mime-info-${PV}.tar.bz2"

There must be some underlying problem here. intltool-native should depend on libxml-parser-perl-native so it should already be built. We need to fix the underlying issue, not the symptom :/

Cheers,

Richard

Saul Wold

2011-09-22 20:09 UTC #3 lore raw

Quoted 6 lines · Richard Purdie

Quoted 5 lines · Darren Hart
Fixes [YOCTO #1514]
Building core-image-minimal on qemuppc (and likely others) can fail in the shared-mime-info configure step with the following error:

I was thinking about this and went "why is shared-mime-info even in core-image-minimal", are you sure that was the image you were building. This might point to some other problem also.

Sau!

Quoted 40 lines

Quoted 20 lines
checking for XML::Parser... configure: error: XML::Parser perl module is required for intltool
Adding libxml-parser-perl to DEPENDS allows share-mime-info-native to build successfully.
Testing: build tested the native version on qemuppc. I run into tool chain build failures before I can get to building the target version.
Signed-off-by Darren Hart<[email protected]>
CC Joshua Lock<[email protected]>
---
  .../shared-mime-info/shared-mime-info.inc          |    4 ++--
  1 files changed, 2 insertions(+), 2 deletions(-)
meta/recipes-support/shared-mime-info/shared-mime-info.inc +0 -0
index 64eef9d..e206305 100644
meta/recipes-support/shared-mime-info/shared-mime-info.inc SECTION = "base" · line 11
Quoted 9 lines
meta/recipes-support/shared-mime-info/shared-mime-info.inc +2 -2
@@ -5,8 +5,8 @@ SECTION = "base"
  LICENSE = "GPLv2+"
  LIC_FILES_CHKSUM = "file://COPYING;md5=0636e73ff0215e8d672dc4c32c317bb3"
 
-DEPENDS = "libxml2 intltool-native glib-2.0 shared-mime-info-native"
-DEPENDS_virtclass-native = "libxml2-native intltool-native glib-2.0-native"
+DEPENDS = "libxml2 intltool-native glib-2.0 shared-mime-info-native libxml-parser-perl"
+DEPENDS_virtclass-native = "libxml2-native intltool-native glib-2.0-native libxml-parser-perl-native"
 
  SRC_URI = "http://freedesktop.org/~hadess/shared-mime-info-${PV}.tar.bz2"
There must be some underlying problem here. intltool-native should depend on libxml-parser-perl-native so it should already be built. We need to fix the underlying issue, not the symptom :/
Cheers,
Richard

Darren Hart

author

2011-09-22 20:25 UTC #4 lore raw

Quoted 10 lines · Saul Wold

Quoted 6 lines · Richard Purdie
Quoted 5 lines · Darren Hart
Fixes [YOCTO #1514]
Building core-image-minimal on qemuppc (and likely others) can fail in the shared-mime-info configure step with the following error:
I was thinking about this and went "why is shared-mime-info even in core-image-minimal", are you sure that was the image you were building. This might point to some other problem also.

Yes, core-image-minimal. It also would fail if I just tried to build shared-mime-info-native.

--
Darren

Quoted 43 lines

Sau!
Quoted 40 lines
Quoted 20 lines
checking for XML::Parser... configure: error: XML::Parser perl module is required for intltool
Adding libxml-parser-perl to DEPENDS allows share-mime-info-native to build successfully.
Testing: build tested the native version on qemuppc. I run into tool chain build failures before I can get to building the target version.
Signed-off-by Darren Hart<[email protected]>
CC Joshua Lock<[email protected]>
---
  .../shared-mime-info/shared-mime-info.inc          |    4 ++--
  1 files changed, 2 insertions(+), 2 deletions(-)
meta/recipes-support/shared-mime-info/shared-mime-info.inc +0 -0
index 64eef9d..e206305 100644
meta/recipes-support/shared-mime-info/shared-mime-info.inc SECTION = "base" · line 11
Quoted 9 lines
meta/recipes-support/shared-mime-info/shared-mime-info.inc +2 -2
@@ -5,8 +5,8 @@ SECTION = "base"
  LICENSE = "GPLv2+"
  LIC_FILES_CHKSUM = "file://COPYING;md5=0636e73ff0215e8d672dc4c32c317bb3"
 
-DEPENDS = "libxml2 intltool-native glib-2.0 shared-mime-info-native"
-DEPENDS_virtclass-native = "libxml2-native intltool-native glib-2.0-native"
+DEPENDS = "libxml2 intltool-native glib-2.0 shared-mime-info-native libxml-parser-perl"
+DEPENDS_virtclass-native = "libxml2-native intltool-native glib-2.0-native libxml-parser-perl-native"
 
  SRC_URI = "http://freedesktop.org/~hadess/shared-mime-info-${PV}.tar.bz2"
There must be some underlying problem here. intltool-native should depend on libxml-parser-perl-native so it should already be built. We need to fix the underlying issue, not the symptom :/
Cheers,
Richard

Signature · 3 lines

Darren Hart
Intel Open Source Technology Center
Yocto Project - Linux Kernel

Richard Purdie

2011-09-22 20:59 UTC #5 lore raw

Quoted 8 lines · Darren Hart

Quoted 7 lines · Saul Wold
Quoted 6 lines · Richard Purdie
Quoted 5 lines · Darren Hart
Fixes [YOCTO #1514]
Building core-image-minimal on qemuppc (and likely others) can fail in the shared-mime-info configure step with the following error:

Quoted 6 lines

Quoted 3 lines
I was thinking about this and went "why is shared-mime-info even in core-image-minimal", are you sure that was the image you were building. This might point to some other problem also.
Yes, core-image-minimal. It also would fail if I just tried to build shared-mime-info-native.

Right, its a native dependency being pulled in by one of the tools, not the image itself...

Cheers,

Richard

Darren Hart

author

2011-09-22 20:37 UTC #6 lore raw

In reply to Saul Wold

Quoted 10 lines · Saul Wold

Quoted 6 lines · Richard Purdie
Quoted 5 lines · Darren Hart
Fixes [YOCTO #1514]
Building core-image-minimal on qemuppc (and likely others) can fail in the shared-mime-info configure step with the following error:
I was thinking about this and went "why is shared-mime-info even in core-image-minimal", are you sure that was the image you were building. This might point to some other problem also.

Perhaps these are pulled in from:

EXTRA_IMAGE_FEATURES = "tools-debug tools-profile tools-testapps debug-tweaks"

Removing this does remove shared-mime-info from the package list (per depexp). They do not get built during a subsequent core-image-minimal build either.

--
Darren

Quoted 43 lines

Sau!
Quoted 40 lines
Quoted 20 lines
checking for XML::Parser... configure: error: XML::Parser perl module is required for intltool
Adding libxml-parser-perl to DEPENDS allows share-mime-info-native to build successfully.
Testing: build tested the native version on qemuppc. I run into tool chain build failures before I can get to building the target version.
Signed-off-by Darren Hart<[email protected]>
CC Joshua Lock<[email protected]>
---
  .../shared-mime-info/shared-mime-info.inc          |    4 ++--
  1 files changed, 2 insertions(+), 2 deletions(-)
meta/recipes-support/shared-mime-info/shared-mime-info.inc +0 -0
index 64eef9d..e206305 100644
meta/recipes-support/shared-mime-info/shared-mime-info.inc SECTION = "base" · line 11
Quoted 9 lines
meta/recipes-support/shared-mime-info/shared-mime-info.inc +2 -2
@@ -5,8 +5,8 @@ SECTION = "base"
  LICENSE = "GPLv2+"
  LIC_FILES_CHKSUM = "file://COPYING;md5=0636e73ff0215e8d672dc4c32c317bb3"
 
-DEPENDS = "libxml2 intltool-native glib-2.0 shared-mime-info-native"
-DEPENDS_virtclass-native = "libxml2-native intltool-native glib-2.0-native"
+DEPENDS = "libxml2 intltool-native glib-2.0 shared-mime-info-native libxml-parser-perl"
+DEPENDS_virtclass-native = "libxml2-native intltool-native glib-2.0-native libxml-parser-perl-native"
 
  SRC_URI = "http://freedesktop.org/~hadess/shared-mime-info-${PV}.tar.bz2"
There must be some underlying problem here. intltool-native should depend on libxml-parser-perl-native so it should already be built. We need to fix the underlying issue, not the symptom :/
Cheers,
Richard

Signature · 3 lines

Darren Hart
Intel Open Source Technology Center
Yocto Project - Linux Kernel

Darren Hart

author

2011-09-22 20:33 UTC #7 lore raw

In reply to Richard Purdie

Quoted 34 lines · Richard Purdie

Quoted 33 lines · Darren Hart
Fixes [YOCTO #1514]
Building core-image-minimal on qemuppc (and likely others) can fail in the shared-mime-info configure step with the following error:
checking for XML::Parser... configure: error: XML::Parser perl module is required for intltool
Adding libxml-parser-perl to DEPENDS allows share-mime-info-native to build successfully.
Testing: build tested the native version on qemuppc. I run into tool chain build failures before I can get to building the target version.
Signed-off-by Darren Hart <[email protected]>
CC Joshua Lock <[email protected]>
---
 .../shared-mime-info/shared-mime-info.inc          |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)
meta/recipes-support/shared-mime-info/shared-mime-info.inc +2 -2
index 64eef9d..e206305 100644
@@ -5,8 +5,8 @@ SECTION = "base"
 LICENSE = "GPLv2+"
 LIC_FILES_CHKSUM = "file://COPYING;md5=0636e73ff0215e8d672dc4c32c317bb3"
 
-DEPENDS = "libxml2 intltool-native glib-2.0 shared-mime-info-native"
-DEPENDS_virtclass-native = "libxml2-native intltool-native glib-2.0-native"
+DEPENDS = "libxml2 intltool-native glib-2.0 shared-mime-info-native libxml-parser-perl"
+DEPENDS_virtclass-native = "libxml2-native intltool-native glib-2.0-native libxml-parser-perl-native"
 

Quoted 6 lines

meta/recipes-support/shared-mime-info/shared-mime-info.inc SECTION = "base" · line 11
Quoted 1 line
meta/recipes-support/shared-mime-info/shared-mime-info.inc +0 -0
 SRC_URI = "http://freedesktop.org/~hadess/shared-mime-info-${PV}.tar.bz2"
There must be some underlying problem here. intltool-native should depend on libxml-parser-perl-native so it should already be built. We need to fix the underlying issue, not the symptom :/

So intltool.inc:

DEPENDS = "libxml-parser-perl-native"
#RDEPENDS_${PN} = "libxml-parser-perl"
RRECOMMENDS_${PN} = "perl-modules"
RRECOMMENDS_${PN}_virtclass-native = ""

Shouldn't this instead look like:

DEPENDS = "libxml-parser-perl" DEPENDS_virtclass-native = "libxml-parser-perl-native"

Dropping my change above and using this fix instead allows the build to complete. Does look like the right fix to you? Shall I send this as a patch?

Thanks,

Signature · 3 lines

Darren Hart
Intel Open Source Technology Center
Yocto Project - Linux Kernel

Koen Kooi

2011-09-22 20:39 UTC #8 lore raw

Op 22 sep. 2011, om 22:27 heeft Darren Hart het volgende geschreven:

Quoted 51 lines · Richard Purdie

Quoted 34 lines · Darren Hart
Quoted 33 lines
Fixes [YOCTO #1514]
Building core-image-minimal on qemuppc (and likely others) can fail in the shared-mime-info configure step with the following error:
checking for XML::Parser... configure: error: XML::Parser perl module is required for intltool
Adding libxml-parser-perl to DEPENDS allows share-mime-info-native to build successfully.
Testing: build tested the native version on qemuppc. I run into tool chain build failures before I can get to building the target version.
Signed-off-by Darren Hart <[email protected]>
CC Joshua Lock <[email protected]>
---
.../shared-mime-info/shared-mime-info.inc | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
meta/recipes-support/shared-mime-info/shared-mime-info.inc +0 -0
index 64eef9d..e206305 100644
@@ -5,8 +5,8 @@ SECTION = "base"
LICENSE = "GPLv2+"
LIC_FILES_CHKSUM = "file://COPYING;md5=0636e73ff0215e8d672dc4c32c317bb3"
meta/recipes-support/shared-mime-info/shared-mime-info.inc +2 -2
-DEPENDS = "libxml2 intltool-native glib-2.0 shared-mime-info-native"
-DEPENDS_virtclass-native = "libxml2-native intltool-native glib-2.0-native"
+DEPENDS = "libxml2 intltool-native glib-2.0 shared-mime-info-native libxml-parser-perl"
+DEPENDS_virtclass-native = "libxml2-native intltool-native glib-2.0-native libxml-parser-perl-native"
Quoted 6 lines
Quoted 1 line
SRC_URI = "http://freedesktop.org/~hadess/shared-mime-info-${PV}.tar.bz2"
There must be some underlying problem here. intltool-native should depend on libxml-parser-perl-native so it should already be built. We need to fix the underlying issue, not the symptom :/
So intltool.inc:
DEPENDS = "libxml-parser-perl-native"
#RDEPENDS_${PN} = "libxml-parser-perl"
RRECOMMENDS_${PN} = "perl-modules"
RRECOMMENDS_${PN}_virtclass-native = ""

Quoted 4 lines

Shouldn't this instead look like:
DEPENDS = "libxml-parser-perl" DEPENDS_virtclass-native = "libxml-parser-perl-native"

It needs -native for both, sadly

Richard Purdie

2011-09-22 20:57 UTC #9 lore raw

In reply to Darren Hart

Quoted 50 lines · Darren Hart

Quoted 34 lines · Richard Purdie
Quoted 33 lines · Darren Hart
Fixes [YOCTO #1514]
Building core-image-minimal on qemuppc (and likely others) can fail in the shared-mime-info configure step with the following error:
checking for XML::Parser... configure: error: XML::Parser perl module is required for intltool
Adding libxml-parser-perl to DEPENDS allows share-mime-info-native to build successfully.
Testing: build tested the native version on qemuppc. I run into tool chain build failures before I can get to building the target version.
Signed-off-by Darren Hart <[email protected]>
CC Joshua Lock <[email protected]>
---
 .../shared-mime-info/shared-mime-info.inc          |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)
meta/recipes-support/shared-mime-info/shared-mime-info.inc +2 -2
index 64eef9d..e206305 100644
@@ -5,8 +5,8 @@ SECTION = "base"
 LICENSE = "GPLv2+"
 LIC_FILES_CHKSUM = "file://COPYING;md5=0636e73ff0215e8d672dc4c32c317bb3"
 
-DEPENDS = "libxml2 intltool-native glib-2.0 shared-mime-info-native"
-DEPENDS_virtclass-native = "libxml2-native intltool-native glib-2.0-native"
+DEPENDS = "libxml2 intltool-native glib-2.0 shared-mime-info-native libxml-parser-perl"
+DEPENDS_virtclass-native = "libxml2-native intltool-native glib-2.0-native libxml-parser-perl-native"
 
Quoted 6 lines
meta/recipes-support/shared-mime-info/shared-mime-info.inc SECTION = "base" · line 11
Quoted 1 line
meta/recipes-support/shared-mime-info/shared-mime-info.inc +0 -0
 SRC_URI = "http://freedesktop.org/~hadess/shared-mime-info-${PV}.tar.bz2"
There must be some underlying problem here. intltool-native should depend on libxml-parser-perl-native so it should already be built. We need to fix the underlying issue, not the symptom :/
So intltool.inc:
DEPENDS = "libxml-parser-perl-native"
#RDEPENDS_${PN} = "libxml-parser-perl"
RRECOMMENDS_${PN} = "perl-modules"
RRECOMMENDS_${PN}_virtclass-native = ""

Quoted 8 lines

Shouldn't this instead look like:
DEPENDS = "libxml-parser-perl" DEPENDS_virtclass-native = "libxml-parser-perl-native"
Dropping my change above and using this fix instead allows the build to complete. Does look like the right fix to you? Shall I send this as a patch?

That certainly sounds like the more correct solution, yes.

Cheers,

Richard