Status of the patches under review at LMML (28 patches)

Everything at patchwork were reviewed by me, and I've applied all patches that I didn't notice any review by the drivers maintainers.

Driver maintainers:
Please review the remaining patches.

		== Patches for Manu Abraham <[email protected]> review == 

Jun,11 2010: stb0899: Removed an extra byte sent at init on DiSEqC bus              http://patchwork.linuxtv.org/patch/3639   Florent AUDEBERT <[email protected]>
Aug, 7 2010: Refactor Mantis DMA transfer to deliver 16Kb TS data per interrupt     http://patchwork.linuxtv.org/patch/4104   Marko Ristola <[email protected]>
May,21 2011: Disable dynamic current limit for ttpci budget cards                   http://patchwork.linuxtv.org/patch/6669   Guy Martin <[email protected]>
May,23 2011: Increase a timeout, so that bad scheduling does not accidentially caus http://patchwork.linuxtv.org/patch/7178   Hans Petter Selasky <[email protected]>
Jun, 8 2011: Add remote control support for mantis                                  http://patchwork.linuxtv.org/patch/7217   Christoph Pinkl <[email protected]>
May,24 2011: Fix the derot zig-zag to work with TT-USB2.0 TechnoTrend.              http://patchwork.linuxtv.org/patch/6777   Hans Petter Selasky <[email protected]>
Jun, 1 2011: stv090x: set status bits when there is no lock                         http://patchwork.linuxtv.org/patch/6804   Guy Martin <[email protected]>

		== Patches for Dmitri Belimov <[email protected]> review == 

Apr,23 2009: FM1216ME_MK3 AUX byte for FM mode http://patchwork.linuxtv.org/patch/764 Dmitri Belimov <[email protected]>

		== Patches waiting for Morimoto Kuninori<[email protected]> check == 

Feb, 2 2010: [2/3] soc-camera: mt9t112: modify delay time after initialize http://patchwork.linuxtv.org/patch/2553 Kuninori Morimoto <[email protected]>

		== Patches waiting Mauro Carvalho Chehab <[email protected]> tests with mb86a20s/ISDB-T == 

May,19 2011: saa7134-dvb.c kworld_sbtvd http://patchwork.linuxtv.org/patch/6649 Manoel PN <[email protected]>

		== Patches waiting for Hans de Goede <[email protected]> review == 

Jun, 4 2011: Increase max exposure value to 255 from 26. http://patchwork.linuxtv.org/patch/6850 Marco Diego Aurélio Mesquita <[email protected]>

		== Patches waiting for Laurent Pinchart <[email protected]> review == 

Jun,22 2011: Improve UVC buffering with regard to USB. Add checks to avoid division http://patchwork.linuxtv.org/patch/7290   Hans Petter Selasky <[email protected]>
Jul,11 2011: Error routes through omap3isp ccdc.                                    http://patchwork.linuxtv.org/patch/7428   Jonathan Cameron <[email protected]>
Jul,14 2011: uvcvideo: add fix suspend/resume quirk for Microdia camera             http://patchwork.linuxtv.org/patch/186    Ming Lei <[email protected]>
Jul,13 2011: [RFC, v1] mt9v113: VGA camera sensor driver and support for BeagleBoar http://patchwork.linuxtv.org/patch/184    Joel A Fernandes <[email protected]>
Sep, 6 2011: mt9p031: Do not use PLL if external frequency is the same as target fr http://patchwork.linuxtv.org/patch/7783   Javier Martin <[email protected]>

		== Patches for Andy Walls <Andy Walls <[email protected]>> review == 

May,25 2011: ivtv: use display information in info not in var for panning http://patchwork.linuxtv.org/patch/6706 Laurent Pinchart <[email protected]>

		== Waiting for Andy Walls <[email protected]> double-check == 

Dec,19 2010: [RESEND, for, 2.6.37] cx23885, cx25840: Provide IR Rx timeout event re http://patchwork.linuxtv.org/patch/5133 Andy Walls <[email protected]>

		== Waiting for Jarod Wilson <[email protected]> review == 

Apr,28 2011: [10/10] rc-core: move timeout and checks to lirc http://patchwork.linuxtv.org/patch/6468 David Härdeman <[email protected]>

		== Waiting for Pawel Osiak <[email protected]> review == 

Jul,12 2011: v4l: mem2mem: add wait_{prepare,finish} ops to m2m_testdev http://patchwork.linuxtv.org/patch/7431 Michael Olbrich <[email protected]>

		== waiting for Michael Krufky <[email protected]> review == 

Sep, 4 2011: Medion 95700 analog video support http://patchwork.linuxtv.org/patch/7767 Maciej Szmigiero <[email protected]>

		== Patches waiting for Guennadi Liakhovetski <[email protected]> review == 

Sep,19 2011: [1/4,v2,FOR,3.1] v4l2: add vb2_get_unmapped_area in vb2 core           http://patchwork.linuxtv.org/patch/7870   Scott Jiang <[email protected]>
Sep,19 2011: [2/4,v2,FOR,3.1] v4l2: add adv7183 decoder driver                      http://patchwork.linuxtv.org/patch/7872   Scott Jiang <[email protected]>
Sep,19 2011: [3/4,v2,FOR,3.1] v4l2: add vs6624 sensor driver                        http://patchwork.linuxtv.org/patch/7871   Scott Jiang <[email protected]>
Sep,19 2011: [4/4,v2,FOR,3.1] v4l2: add blackfin capture bridge driver              http://patchwork.linuxtv.org/patch/7869   Scott Jiang <[email protected]>
Sep,22 2011: [v3,1/2,media] Add code to enable/disable ISI_MCK clock.               http://patchwork.linuxtv.org/patch/7917   Josh Wu <[email protected]>
Sep,22 2011: [v3, 2/2] at91: add Atmel ISI and ov2640 support on sam9m10/sam9g45 bo http://patchwork.linuxtv.org/patch/7918   Josh Wu <[email protected]>

		== waiting for Eddi De Pieri <[email protected]> feedback == 

Sep,23 2011: [v2] xc5000: Add support for get_if_frequency http://patchwork.linuxtv.org/patch/7932 Mauro Carvalho Chehab <[email protected]>

Number of pending patches per reviewer:

  Manu Abraham <[email protected]>                                 : 7
  Guennadi Liakhovetski <[email protected]>                         : 6
  Laurent Pinchart <[email protected]>                  : 5
  Andy Walls <[email protected]>                                  : 2
  Pawel Osiak <[email protected]>                                        : 1
  Morimoto Kuninori<[email protected]>                      : 1
  Jarod Wilson <[email protected]>                                       : 1
  Eddi De Pieri <[email protected]>                                      : 1
  Hans de Goede <[email protected]>                                   : 1
  Dmitri Belimov <[email protected]>                                  : 1
  Mauro Carvalho Chehab <[email protected]>                            : 1
  Michael Krufky <[email protected]>                                  : 1

You committed this one from one of my pull requests. The subject line changed a little (ivtv: -> ivtvfb:)

http://www.gossamer-threads.com/lists/ivtv/devel/41425
http://git.linuxtv.org/media_tree.git?a=commitdiff;h=5d9c08dea0c13c09408f97fe61d34c198c4f3277
http://lkml.org/lkml/2011/6/7/311

By inspection, this one is still OK. It is still relevant and looks like it still should apply cleanly. I have not compile tested it recently.

I need to comment on the cx25840 portion of this patch. I plan to make time to do that in a few hours.

Regards,
Andy

Em 24-09-2011 11:52, Andy Walls escreveu:

Ok. Patch updated.

Thanks! Applied.

Thank you!
Mauro

A single byte doesn't make much of a difference, but well it is still a difference. The DiSEqC has some known issues and has some tricky workarounds for different Silicon cuts. This patch *might* be good on some chips while have an adverse effect. But that said I have not tested this patch.

If general users would like to have this patch and is proven good on different versions, I have no objection for this patch to go in.

In which case; Acked-by: Manu Abraham <[email protected]>

Em 24-09-2011 15:11, Manu Abraham escreveu:

Ok. Well, let's apply it and see the feedbacks if any.

Thanks for reviewing it!
Mauro

I did test this patch. It doesn't bring in any side effects in general. It increases the latency, which it is expected. On some PCI-PCI chipset the patch makes the TS handling worser. But in other cases, it looks okay.

Strictly, the patch is incorrect.

- Dynamic Current Limiting is nothing but a PWM operation where Ton = 20mS, Toff = 900mS.
In fact, DCL is much more preferred, since it can protect the Power tracks to the PCI slot in case the fuse on the card doesn't blow out.

This *might* prove problematic with some DiSEqC switches. Only in such a case, it might be wise to disable DCL. But I haven't yet seen anyone complain on the same, otherwise incorrect DiSEqC commands ?

Regards,
Manu

Haven't heard timeout issues recently though ... but still;

Haven't tested this patch. Please hold on with this patch.

Best Regards,
Manu

Em 24-09-2011 15:29, Manu Abraham escreveu:

Ok, status updated at all patches, and added the ones that were acked/reviewed.

Ok.

FYI, this patch looks correct on my eyes, with respect to RC core usage.

Thanks,
Mauro

Patch doesn't make any sense.

Patch looks okay, but untested at my side.

Hi Mauro,

(...)

This is an ack from me.

Best regards,
Pawel Osciak

Hi Mauro,

On my TODO list.

This has been superseded by "[media] omap3isp: Don't accept pipelines with no video source as valid" which is already in your tree.

This has been superseded by "uvcvideo: Set alternate setting 0 on resume if the bus has been reset" which is hopefully in your tree on its way to v3.1 :-)

I've reviewed the patch, waiting for the next version.

I've reviewed the patch, I think we should implement proper PLL support.

Regards,

Laurent Pinchart