Add a check for libdevmapper.h

PATCH In review Steve Dickson 2 participants 3 messages Sep 26, 2011

Subsystems (2)

NFS client NFS server

lore

Share & tools

lore

Steve Dickson

author

2011-09-26 11:42 UTC #0 lore raw

PATCH 1/1 Add a check for libdevmapper.h

When NFS v4.1 is enable, the libdevemapp.h header file has to exist.

Signed-off-by Steve Dickson <[email protected]>

---
 configure.ac |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

configure.ac +1 -0

index 80fb39d..572b33d 100644
@@ -80,6 +80,7 @@ AC_ARG_ENABLE(nfsv41,
 			AC_MSG_ERROR([NFS v4.1 is enabled but NFS v4 is not. Use --disable-nfsv41])
 		fi
 		BLKMAPD=blkmapd
+   		AC_CHECK_HEADER(libdevmapper.h, , AC_MSG_ERROR([Cannot find libdevmapper.h header file. Try installing device-mapper-devel]))
 	else
 		enable_nfsv41=
 		BLKMAPD=

Signature · 1 line

1.7.6

Jim Rees

2011-09-26 12:24 UTC #1 lore raw

Steve Dickson wrote:

When NFS v4.1 is enable, the libdevemapp.h header file has to exist.

Signed-off-by Steve Dickson <[email protected]>

---

   configure.ac |    1 +
   1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/configure.ac b/configure.ac
index 80fb39d..572b33d 100644
--- a/configure.ac
+++ b/configure.ac
@@ -80,6 +80,7 @@ AC_ARG_ENABLE(nfsv41,
AC_MSG_ERROR([NFS v4.1 is enabled but NFS v4 is not. Use --disable-nfsv41])
fi
BLKMAPD=blkmapd
+ AC_CHECK_HEADER(libdevmapper.h, , AC_MSG_ERROR([Cannot find libdevmapper.h header file. Try installing device-mapper-devel]))
else
enable_nfsv41=
BLKMAPD=

On Debian based systems it's libdevmapper-dev.

Did you get the patch I sent? I added the check farther down, with the other checks, and also checked for the library.

Steve Dickson

author

2011-09-26 13:26 UTC #2 lore raw

Quoted 22 lines · Jim Rees

Steve Dickson wrote:
When NFS v4.1 is enable, the libdevemapp.h header file has to exist.
Signed-off-by Steve Dickson <[email protected]>
---
   configure.ac |    1 +
   1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/configure.ac b/configure.ac
index 80fb39d..572b33d 100644
--- a/configure.ac
+++ b/configure.ac
@@ -80,6 +80,7 @@ AC_ARG_ENABLE(nfsv41,
AC_MSG_ERROR([NFS v4.1 is enabled but NFS v4 is not. Use --disable-nfsv41])
fi
BLKMAPD=blkmapd
+ AC_CHECK_HEADER(libdevmapper.h, , AC_MSG_ERROR([Cannot find libdevmapper.h header file. Try installing device-mapper-devel]))
else
enable_nfsv41=
BLKMAPD=

Quoted 4 lines

On Debian based systems it's libdevmapper-dev.
Did you get the patch I sent? I added the check farther down, with the other checks, and also checked for the library.

ah... no I did not but I do now... Lets go with your patch...

steved.