Skip to contentSkip to conversation

net/eth: add newline to "failed MAC address" warning

PATCH New Holger Brunck 4 participants 5 messages Sep 23, 2011 – Oct 1, 2011 Networking

lore
Share & tools
lore

Holger Brunck

author
#0 lore raw

PATCH 1/1 net/eth: add newline to "failed MAC address" warning

This prevents u-boot to display during bootime:

Out:   serial
Err:   serial
Net:   UEC3Warning: failed to set MAC address

Now corrected and it will display:

Out:   serial
Err:   serial
Net:   UEC3
Warning: failed to set MAC address
Signed-off-by Holger Brunck <[email protected]>
---
 net/eth.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
net/eth.c +1 -1
index 02baa37..1c0c780 100644
@@ -302,7 +302,7 @@ int eth_initialize(bd_t *bis)
 				puts("\nWarning: eth device name has a space!\n");
 
 			if (eth_write_hwaddr(dev, "eth", eth_number))
-				puts("Warning: failed to set MAC address\n");
+				puts("\nWarning: failed to set MAC address\n");
 
 			eth_number++;
 			dev = dev->next;
Signature · 1 line
1.7.1
#1 lore raw

PATCH 1/1 net/eth: add newline to "failed MAC address" warning

Quoted 5 lines · Holger Brunck

This prevents u-boot to display during bootime:

Out:   serial
Err:   serial
Net:   UEC3Warning: failed to set MAC address
Quoted 7 lines

Now corrected and it will display:

Out:   serial
Err:   serial
Net:   UEC3
Warning: failed to set MAC address
Signed-off-by Holger Brunck<[email protected]>
Acked-by Philip Balister <[email protected]>

But, when i submitted the same patch, I was told this is not the right way to solve the problem. I would still like to see this patch go in until someone has time to rewrite the problem section of code.

Philip

Quoted 17 lines
---
  net/eth.c |    2 +-
  1 files changed, 1 insertions(+), 1 deletions(-)
net/eth.c +1 -1
index 02baa37..1c0c780 100644
@@ -302,7 +302,7 @@ int eth_initialize(bd_t *bis)
  				puts("\nWarning: eth device name has a space!\n");
 
  			if (eth_write_hwaddr(dev, "eth", eth_number))
-				puts("Warning: failed to set MAC address\n");
+				puts("\nWarning: failed to set MAC address\n");
 
  			eth_number++;
  			dev = dev->next;
#2 lore raw

PATCH 1/1 net/eth: add newline to "failed MAC address" warning

Quoted 12 lines · On Monday, September 26, 2011 10:24:54 Philip Balister wrote:
Quoted 11 lines · Holger Brunck

This prevents u-boot to display during bootime:

Out:   serial
Err:   serial
Net:   UEC3Warning: failed to set MAC address

Now corrected and it will display:

Out:   serial
Err:   serial
Net:   UEC3
Warning: failed to set MAC address
Quoted 7 lines
Quoted 1 line
Signed-off-by Holger Brunck<[email protected]>
Acked-by Philip Balister <[email protected]>

But, when i submitted the same patch, I was told this is not the right way to solve the problem. I would still like to see this patch go in until someone has time to rewrite the problem section of code.

i don't think it is the right way long term, but short term, i think it's correct wrt the surrounding code.
-mike
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: This is a digitally signed message part.
Url : http://lists.denx.de/pipermail/u-boot/attachments/20110926/efaf5d93/attachment.pgp

author
#3 lore raw

PATCH 1/1 net/eth: add newline to "failed MAC address" warning

Quoted 15 lines · Mike Frysinger
Quoted 14 lines · On Monday, September 26, 2011 10:24:54 Philip Balister wrote:
Quoted 12 lines · Holger Brunck

This prevents u-boot to display during bootime:

Out:   serial
Err:   serial
Net:   UEC3Warning: failed to set MAC address

Now corrected and it will display:

Out:   serial
Err:   serial
Net:   UEC3
Warning: failed to set MAC address
Signed-off-by Holger Brunck<[email protected]>
Quoted 8 lines
Quoted 5 lines
Acked-by Philip Balister <[email protected]>

But, when i submitted the same patch, I was told this is not the right way to solve the problem. I would still like to see this patch go in until someone has time to rewrite the problem section of code.

i don't think it is the right way long term, but short term, i think it's correct wrt the surrounding code.

Yes I agree. It never meant to be more than a bootlog improvement. The root cause should be fixed in the long term.

Regards
Holger

Applied
#4 lore raw

PATCH 1/1 net/eth: add newline to "failed MAC address" warning

In reply to Holger Brunck

Dear Holger Brunck,

Quoted 11 lines · In message <[email protected]> you…

This prevents u-boot to display during bootime:

Out:   serial
Err:   serial
Net:   UEC3Warning: failed to set MAC address

Now corrected and it will display:

Out:   serial
Err:   serial
Net:   UEC3
Warning: failed to set MAC address
Quoted 4 lines
Signed-off-by Holger Brunck <[email protected]>
---
 net/eth.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

Applied, thanks.

Best regards,

Wolfgang Denk

Signature · 6 lines
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
On the subject of C program indentation: "In My Egotistical  Opinion,
most  people's  C  programs  should be indented six feet downward and
covered with dirt."                               - Blair P. Houghton