Skip to contentSkip to conversation

fix find_next_system_ram comments

PATCH In review Wizard 3 participants 3 messages Sep 26, 2011 – Sep 28, 2011 Memory management

lore
Share & tools
lore

Wizard

author
#0 lore raw

PATCH 1/1 fix find_next_system_ram comments

The purpose of find_next_system_ram() is to find a the lowest memory resource which contain or overlap the [res->start, res->end), not just contain.

In this patch, I make this comment more exact and fix one typo.

---
 kernel/resource.c |    3 ++-
 1 files changed, 2 insertions(+), 1 deletions(-)
kernel/resource.c +2 -1
index 3b3cedc..2751a8c 100644
@@ -279,7 +279,8 @@ EXPORT_SYMBOL(release_resource);
 
 #if !defined(CONFIG_ARCH_HAS_WALK_MEMORY)
 /*
- * Finds the lowest memory reosurce exists within [res->start.res->end)
+ * Finds the lowest memory resource which contains or overlaps
+ * [res->start.res->end)
  * the caller must specify res->start, res->end, res->flags and "name".
  * If found, returns 0, res is overwritten, if not found, returns -1.
  */
Signature · 8 lines
1.6.3.3

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to [email protected].  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"[email protected]"> [email protected] </a>
#1 lore raw
Quoted 7 lines · Wizard

The purpose of find_next_system_ram() is to find a the lowest memory resource which contain or overlap the [res->start, res->end), not just contain.

In this patch, I make this comment more exact and fix one typo.

For Signed-off-by: Documentation/SubmittingPatches says:

using your real name (sorry, no pseudonyms or anonymous contributions.)

Quoted 9 lines
---
 kernel/resource.c |    3 ++-
 1 files changed, 2 insertions(+), 1 deletions(-)
kernel/resource.c +0 -0
index 3b3cedc..2751a8c 100644

kernel/resource.c EXPORT_SYMBOL(release_resource); · line 283

Quoted 6 lines
kernel/resource.c +2 -1
@@ -279,7 +279,8 @@ EXPORT_SYMBOL(release_resource);
 
 #if !defined(CONFIG_ARCH_HAS_WALK_MEMORY)
 /*
- * Finds the lowest memory reosurce exists within [res->start.res->end)
+ * Finds the lowest memory resource which contains or overlaps
+ * [res->start.res->end)

Your patch description uses ", " (comma) here. I think that's better than keeping the ".".

Quoted 3 lines
kernel/resource.c +0 -0
  * the caller must specify res->start, res->end, res->flags and "name".
  * If found, returns 0, res is overwritten, if not found, returns -1.
  */
Signature · 9 lines
~Randy
*** Remember to use Documentation/SubmitChecklist when testing your code ***

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to [email protected].  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"[email protected]"> [email protected] </a>
#2 lore raw
In reply to Wizard
Quoted 7 lines · On Mon, 26 Sep 2011 21:58:02 +0800 Wizard <[email protected]> wrote:

The purpose of find_next_system_ram() is to find a the lowest memory resource which contain or overlap the [res->start, res->end), not just contain.

In this patch, I make this comment more exact and fix one typo.

Thank you for catching.

Please hear Randy's advice :)

Quoted 22 lines
---
 kernel/resource.c |    3 ++-
 1 files changed, 2 insertions(+), 1 deletions(-)
kernel/resource.c +2 -1
index 3b3cedc..2751a8c 100644
@@ -279,7 +279,8 @@ EXPORT_SYMBOL(release_resource);
 
 #if !defined(CONFIG_ARCH_HAS_WALK_MEMORY)
 /*
- * Finds the lowest memory reosurce exists within [res->start.res->end)
+ * Finds the lowest memory resource which contains or overlaps
+ * [res->start.res->end)
  * the caller must specify res->start, res->end, res->flags and "name".
  * If found, returns 0, res is overwritten, if not found, returns -1.
  */
Signature · 1 line
1.6.3.3