Skip to contentSkip to conversation

opensm/osm_dump.c: Fix FDR10 speed dumping

PATCH In review Hal Rosenstock 2 participants 2 messages Sep 28, 2011 – Nov 1, 2011 1 message not in the archive InfiniBand

lore
Share & tools
lore

Hal Rosenstock

author
#0 lore raw

PATCH 1/1 opensm/osm_dump.c: Fix FDR10 speed dumping

In dump_topology_node, FDR10 can be active regardless of whether PortInfo:CapabilityMask.IsExtendedSpeeds is set or not

Prior to this, FDR10 was only indicated if IsExtendedSpeeds was not set

Signed-off-by Hal Rosenstock <hal-VPRAkNaXOzVWk0Htik3J/[email protected]>

---

opensm/osm_dump.c +4 -2
index 7e58301..8aa8095 100644
@@ -454,6 +454,9 @@ static void dump_topology_node(cl_map_item_t * item, FILE * file, void *cxt)
 		else
 			link_speed_act_str = "??";
 
+		if (p_physp->ext_port_info.link_speed_active & FDR10)
+			link_speed_act_str = "FDR10";
+
 		if (p_default_physp->port_info.capability_mask & IB_PORT_CAP_HAS_EXT_SPEEDS) {
 			link_speed_act =
 			    ib_port_info_get_link_speed_ext_active(&p_physp->port_info);

@@ -463,8 +466,7 @@ static void dump_topology_node(cl_map_item_t * item, FILE * file, void *cxt)
 				link_speed_act_str = "25";
 			else if (link_speed_act != IB_LINK_SPEED_EXT_ACTIVE_NONE)
 				link_speed_act_str = "??";
-		} else if (p_physp->ext_port_info.link_speed_active & FDR10)
-			link_speed_act_str = "FDR10";
+		}
 
 		fprintf(file, "PHY=%s LOG=%s SPD=%s\n",
 			p_physp->port_info.link_width_active == 1 ? "1x" :

--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html

A message that is not in the archive (sent off-list or not yet received): 4E831829.4000106-LDSdmyG8hGV8YrgS2mwiifqBs+8SCbDb@public.gmane.org

#2 lore raw

Hi Hal,

Quoted 8 lines · Hal Rosenstock

In dump_topology_node, FDR10 can be active regardless of whether PortInfo:CapabilityMask.IsExtendedSpeeds is set or not

Prior to this, FDR10 was only indicated if IsExtendedSpeeds was not set

Signed-off-by Hal Rosenstock <hal-VPRAkNaXOzVWk0Htik3J/[email protected]>

---

Applied, thanks.
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html