ASoC: samsung: s3c-i2s-v2.c needs module.h

Include <linux/module.h> to fix below build error:

CC sound/soc/samsung/s3c-i2s-v2.o
sound/soc/samsung/s3c-i2s-v2.c:573: warning: data definition has no type or storage class sound/soc/samsung/s3c-i2s-v2.c:573: warning: type defaults to 'int' in declaration of 'EXPORT_SYMBOL_GPL' sound/soc/samsung/s3c-i2s-v2.c:573: warning: parameter names (without types) in function declaration sound/soc/samsung/s3c-i2s-v2.c:638: warning: data definition has no type or storage class sound/soc/samsung/s3c-i2s-v2.c:638: warning: type defaults to 'int' in declaration of 'EXPORT_SYMBOL_GPL' sound/soc/samsung/s3c-i2s-v2.c:638: warning: parameter names (without types) in function declaration sound/soc/samsung/s3c-i2s-v2.c:677: warning: data definition has no type or storage class sound/soc/samsung/s3c-i2s-v2.c:677: warning: type defaults to 'int' in declaration of 'EXPORT_SYMBOL_GPL' sound/soc/samsung/s3c-i2s-v2.c:677: warning: parameter names (without types) in function declaration sound/soc/samsung/s3c-i2s-v2.c: In function 's3c_i2sv2_register_dai':
sound/soc/samsung/s3c-i2s-v2.c:736: warning: initialization discards qualifiers from pointer target type sound/soc/samsung/s3c-i2s-v2.c: At top level:
sound/soc/samsung/s3c-i2s-v2.c:754: warning: data definition has no type or storage class sound/soc/samsung/s3c-i2s-v2.c:754: warning: type defaults to 'int' in declaration of 'EXPORT_SYMBOL_GPL' sound/soc/samsung/s3c-i2s-v2.c:754: warning: parameter names (without types) in function declaration sound/soc/samsung/s3c-i2s-v2.c:756: error: expected declaration specifiers or '...' before string constant sound/soc/samsung/s3c-i2s-v2.c:756: warning: data definition has no type or storage class sound/soc/samsung/s3c-i2s-v2.c:756: warning: type defaults to 'int' in declaration of 'MODULE_LICENSE' sound/soc/samsung/s3c-i2s-v2.c:756: warning: function declaration isn't a prototype make[3]: *** [sound/soc/samsung/s3c-i2s-v2.o] Error 1
make[2]: *** [sound/soc/samsung] Error 2
make[1]: *** [sound/soc] Error 2
make: *** [sound] Error 2

---
This patch is against linux-next (20110930).

 sound/soc/samsung/s3c-i2s-v2.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

index 52074a2b..7a73380 100644
@@ -16,6 +16,7 @@
  * option) any later version.
  */
 
+#include <linux/module.h>
 #include <linux/delay.h>
 #include <linux/clk.h>
 #include <linux/io.h>

1.7.4.1

What tree is this for? My primary development platform is based on this driver, I'd expect to have noticed any build issues and I rather suspect this isn't what you're supposed to do after all the module.h stuff has settled down.

2011/10/3 Mark Brown <[email protected]>:

I got the build error on linux-next (20110930).

That's exactly what I'm running at the minute with no problem...

Then I'm guessing you don't have the option for it enabled (as the s3c2410_defconfig doesn't enable it, it seems).

I reproduced it with the following commands:

   28  git checkout next-20110930
   29  mkdir ../arm-sam
   30  make O=../arm-sam s3c2410_defconfig
   31  nice make O=../arm-foo/ sound/soc/samsung/s3c-i2s-v2.o

Thanks Axel, I'll squish this into the commit that adds module.h to all the other sound drivers that have it missing.

Paul.

I'm pretty sure I'd have noticed if I wasn't building the driver, my systems would be a lot less noisy than it currently is.

Now that we've worked out what it's for I don't see any reason not to apply Axel's patch right now so I've done that.

It would be useful if you could send your patches for module.h upstream, there's no reason to avoid sending them now and it'd be useful to cut down on the noise from small merge issues.