e2fsprogs: Fix thinko in ext2fs_initialize bigalloc case

PATCH In review Eric Sandeen 2 participants 2 messages Oct 3, 2011 – Oct 4, 2011

lore

Share & tools

lore

Eric Sandeen

author

2011-10-03 22:01 UTC #0 lore raw

PATCH 1/1 e2fsprogs: Fix thinko in ext2fs_initialize bigalloc case

Surely we should be setting s_clusters_per_group, not s_blocks_per_group, to EXT2_MAX_CLUSTERS_PER_GROUP here.

Signed-off-by Eric Sandeen <[email protected]>

---

lib/ext2fs/initialize.c +1 -1

index 47f0b1c..2875f97 100644
@@ -218,7 +218,7 @@ errcode_t ext2fs_initialize(const char *name, int flags,
 		else
 			super->s_clusters_per_group = fs->blocksize * 8;
 		if (super->s_clusters_per_group > EXT2_MAX_CLUSTERS_PER_GROUP(super))
-			super->s_blocks_per_group = EXT2_MAX_CLUSTERS_PER_GROUP(super);
+			super->s_clusters_per_group = EXT2_MAX_CLUSTERS_PER_GROUP(super);
 		super->s_blocks_per_group = EXT2FS_C2B(fs,
 				       super->s_clusters_per_group);
 	} else {

Ted Ts'o

2011-10-04 03:24 UTC #1 lore raw

Quoted 4 lines · Eric Sandeen

Surely we should be setting s_clusters_per_group, not s_blocks_per_group, to EXT2_MAX_CLUSTERS_PER_GROUP here.
Signed-off-by Eric Sandeen <[email protected]>

Yes, oops. Good catch, applied.

- Ted