Skip to contentSkip to conversation

ahci: add DT binding for Calxeda AHCI controller

PATCH In review Rob Herring 2 participants 5 messages Sep 2, 2011 – Nov 3, 2011

Subsystems (3)
Device tree bindings libata libata SATA AHCI platform devices support
lore
Share & tools
lore

Rob Herring

author
#0 lore raw

PATCH 1/1 ahci: add DT binding for Calxeda AHCI controller

From: Rob Herring <[email protected]>

Add devicetree match table to ahci platform driver for Calxeda Highbank AHCI controller.

Signed-off-by Rob Herring <[email protected]>
Cc Jeff Garzik <[email protected]>
Cc [email protected]
Cc [email protected]
Cc [email protected]
---
 .../devicetree/bindings/ata/calxeda-sata.txt       |   17 +++++++++++++++++
 drivers/ata/ahci_platform.c                        |    7 +++++++
 2 files changed, 24 insertions(+), 0 deletions(-)
 create mode 100644 Documentation/devicetree/bindings/ata/calxeda-sata.txt
Documentation/devicetree/bindings/ata/calxeda-sata.txt new file +17 -0
new file mode 100644
index 0000000..79caa56
@@ -0,0 +1,17 @@
+* Calxeda SATA Controller
+
+SATA nodes are defined to describe on-chip Serial ATA controllers.
+Each SATA controller should have its own node.
+
+Required properties:
+- compatible        : compatible list, contains "calxeda,hb-ahci"
+- interrupts        : <interrupt mapping for SATA IRQ>
+- reg               : <registers mapping>
+
+Example:
+        sata@ffe08000 {
+		compatible = "calxeda,hb-ahci";
+                reg = <0xffe08000 0x1000>;
+                interrupts = <115>;
+        };
+
drivers/ata/ahci_platform.c +7 -0
index 6fef1fa..9bfc970 100644
@@ -171,11 +171,18 @@ static int __devexit ahci_remove(struct platform_device *pdev)
 	return 0;
 }
 
+static const struct of_device_id ahci_of_match[] = {
+	{ .compatible = "calxeda,hb-ahci", },
+	{},
+};
+MODULE_DEVICE_TABLE(of, ahci_of_match);
+
 static struct platform_driver ahci_driver = {
 	.remove = __devexit_p(ahci_remove),
 	.driver = {
 		.name = "ahci",
 		.owner = THIS_MODULE,
+		.of_match_table = ahci_of_match,
 	},
 };
Signature · 1 line
1.7.5.4
author
#1 lore raw
Quoted 11 lines · Rob Herring

From: Rob Herring <[email protected]>

Add devicetree match table to ahci platform driver for Calxeda Highbank AHCI controller.

Signed-off-by Rob Herring <[email protected]>
Cc Jeff Garzik <[email protected]>
Cc [email protected]
Cc [email protected]
Cc [email protected]

---

Any comments on this?

Rob

Quoted 51 lines
 .../devicetree/bindings/ata/calxeda-sata.txt       |   17 +++++++++++++++++
 drivers/ata/ahci_platform.c                        |    7 +++++++
 2 files changed, 24 insertions(+), 0 deletions(-)
 create mode 100644 Documentation/devicetree/bindings/ata/calxeda-sata.txt
Documentation/devicetree/bindings/ata/calxeda-sata.txt new file +17 -0
new file mode 100644
index 0000000..79caa56
@@ -0,0 +1,17 @@
+* Calxeda SATA Controller
+
+SATA nodes are defined to describe on-chip Serial ATA controllers.
+Each SATA controller should have its own node.
+
+Required properties:
+- compatible        : compatible list, contains "calxeda,hb-ahci"
+- interrupts        : <interrupt mapping for SATA IRQ>
+- reg               : <registers mapping>
+
+Example:
+        sata@ffe08000 {
+		compatible = "calxeda,hb-ahci";
+                reg = <0xffe08000 0x1000>;
+                interrupts = <115>;
+        };
+
drivers/ata/ahci_platform.c +7 -0
index 6fef1fa..9bfc970 100644
@@ -171,11 +171,18 @@ static int __devexit ahci_remove(struct platform_device *pdev)
 	return 0;
 }
 
+static const struct of_device_id ahci_of_match[] = {
+	{ .compatible = "calxeda,hb-ahci", },
+	{},
+};
+MODULE_DEVICE_TABLE(of, ahci_of_match);
+
 static struct platform_driver ahci_driver = {
 	.remove = __devexit_p(ahci_remove),
 	.driver = {
 		.name = "ahci",
 		.owner = THIS_MODULE,
+		.of_match_table = ahci_of_match,
 	},
 };
author
#2 lore raw

Jeff,

Quoted 6 lines · Rob Herring
Quoted 5 lines · Rob Herring

From: Rob Herring <[email protected]>

Add devicetree match table to ahci platform driver for Calxeda Highbank AHCI controller.

Quoted 9 lines
Quoted 6 lines
Signed-off-by Rob Herring <[email protected]>
Cc Jeff Garzik <[email protected]>
Cc [email protected]
Cc [email protected]
Cc [email protected]

---

Any comments on this?

Ping.

Can you please apply this for 3.2.

Regards,
Rob

Quoted 52 lines
Quoted 51 lines
 .../devicetree/bindings/ata/calxeda-sata.txt       |   17 +++++++++++++++++
 drivers/ata/ahci_platform.c                        |    7 +++++++
 2 files changed, 24 insertions(+), 0 deletions(-)
 create mode 100644 Documentation/devicetree/bindings/ata/calxeda-sata.txt
Documentation/devicetree/bindings/ata/calxeda-sata.txt new file +17 -0
new file mode 100644
index 0000000..79caa56
@@ -0,0 +1,17 @@
+* Calxeda SATA Controller
+
+SATA nodes are defined to describe on-chip Serial ATA controllers.
+Each SATA controller should have its own node.
+
+Required properties:
+- compatible        : compatible list, contains "calxeda,hb-ahci"
+- interrupts        : <interrupt mapping for SATA IRQ>
+- reg               : <registers mapping>
+
+Example:
+        sata@ffe08000 {
+		compatible = "calxeda,hb-ahci";
+                reg = <0xffe08000 0x1000>;
+                interrupts = <115>;
+        };
+
drivers/ata/ahci_platform.c +7 -0
index 6fef1fa..9bfc970 100644
@@ -171,11 +171,18 @@ static int __devexit ahci_remove(struct platform_device *pdev)
 	return 0;
 }
 
+static const struct of_device_id ahci_of_match[] = {
+	{ .compatible = "calxeda,hb-ahci", },
+	{},
+};
+MODULE_DEVICE_TABLE(of, ahci_of_match);
+
 static struct platform_driver ahci_driver = {
 	.remove = __devexit_p(ahci_remove),
 	.driver = {
 		.name = "ahci",
 		.owner = THIS_MODULE,
+		.of_match_table = ahci_of_match,
 	},
 };
author
#3 lore raw
Quoted 16 lines · Rob Herring

Jeff,

Quoted 13 lines · Rob Herring
Quoted 11 lines · Rob Herring

From: Rob Herring <[email protected]>

Add devicetree match table to ahci platform driver for Calxeda Highbank AHCI controller.

Signed-off-by Rob Herring <[email protected]>
Cc Jeff Garzik <[email protected]>
Cc [email protected]
Cc [email protected]
Cc [email protected]

---

Quoted 7 lines
Quoted 2 lines

Any comments on this?

Ping.

Can you please apply this for 3.2.

Anyone out there?

Rob

Acked-by on v1 1/1
#4 lore raw
In reply to Rob Herring
Quoted 10 lines · Rob Herring

From: Rob Herring <[email protected]>

Add devicetree match table to ahci platform driver for Calxeda Highbank AHCI controller.

Signed-off-by Rob Herring <[email protected]>
Cc Jeff Garzik <[email protected]>
Cc [email protected]
Cc [email protected]
Cc [email protected]
Acked-by Grant Likely <[email protected]>
Quoted 60 lines
---
 .../devicetree/bindings/ata/calxeda-sata.txt       |   17 +++++++++++++++++
 drivers/ata/ahci_platform.c                        |    7 +++++++
 2 files changed, 24 insertions(+), 0 deletions(-)
 create mode 100644 Documentation/devicetree/bindings/ata/calxeda-sata.txt
Documentation/devicetree/bindings/ata/calxeda-sata.txt new file +17 -0
new file mode 100644
index 0000000..79caa56
@@ -0,0 +1,17 @@
+* Calxeda SATA Controller
+
+SATA nodes are defined to describe on-chip Serial ATA controllers.
+Each SATA controller should have its own node.
+
+Required properties:
+- compatible        : compatible list, contains "calxeda,hb-ahci"
+- interrupts        : <interrupt mapping for SATA IRQ>
+- reg               : <registers mapping>
+
+Example:
+        sata@ffe08000 {
+		compatible = "calxeda,hb-ahci";
+                reg = <0xffe08000 0x1000>;
+                interrupts = <115>;
+        };
+
drivers/ata/ahci_platform.c +7 -0
index 6fef1fa..9bfc970 100644
@@ -171,11 +171,18 @@ static int __devexit ahci_remove(struct platform_device *pdev)
 	return 0;
 }
 
+static const struct of_device_id ahci_of_match[] = {
+	{ .compatible = "calxeda,hb-ahci", },
+	{},
+};
+MODULE_DEVICE_TABLE(of, ahci_of_match);
+
 static struct platform_driver ahci_driver = {
 	.remove = __devexit_p(ahci_remove),
 	.driver = {
 		.name = "ahci",
 		.owner = THIS_MODULE,
+		.of_match_table = ahci_of_match,
 	},
 };
Signature · 7 lines
1.7.5.4

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/