serial: uartlite: Support for SERIAL_MULTI
PATCH v5 1/1 serial: uartlite: Support for SERIAL_MULTI
Add support for SERIAL MULTI for uartlite.
---
v2: Use in/out_be32 functions
v3: Clean coding style
v4: Simplify userial_ports array initialization
v5: const userial_ports
Do not use u32
Separate declarations and code by a single blank line Update copyright
--- common/serial.c | 14 ++++ drivers/serial/serial_xuartlite.c | 140 ++++++++++++++++++++++++++++++++----- include/serial.h | 7 ++ 3 files changed, 142 insertions(+), 19 deletions(-)
common/serial.c +14 -0
@@ -108,6 +108,20 @@ void serial_initialize (void)#if defined(CONFIG_SYS_BFIN_UART )serial_register_bfin_uart ();#endif +#if defined(CONFIG_XILINX_UARTLITE ) +# ifdef XILINX_UARTLITE_BASEADDR +serial_register (&uartlite_serial0_device); +# endif /* XILINX_UARTLITE_BASEADDR */ +# ifdef XILINX_UARTLITE_BASEADDR1 +serial_register (&uartlite_serial1_device); +# endif /* XILINX_UARTLITE_BASEADDR1 */ +# ifdef XILINX_UARTLITE_BASEADDR2 +serial_register (&uartlite_serial2_device); +# endif /* XILINX_UARTLITE_BASEADDR2 */ +# ifdef XILINX_UARTLITE_BASEADDR3 +serial_register (&uartlite_serial3_device); +# endif /* XILINX_UARTLITE_BASEADDR3 */ +#endif /* CONFIG_XILINX_UARTLITE */ serial_assign (default_serial_console ()->name); }
drivers/serial/serial_xuartlite.c +121 -19
172 lines not on this page · raw message
include/serial.h +7 -0
@@ -50,6 +50,13 @@ extern struct serial_device serial4_device;extern struct serial_device serial6_device;#endif +#if defined(CONFIG_XILINX_UARTLITE ) +extern struct serial_device uartlite_serial0_device; +extern struct serial_device uartlite_serial1_device; +extern struct serial_device uartlite_serial2_device; +extern struct serial_device uartlite_serial3_device; +#endif +#if defined(CONFIG_S3C2410 )extern struct serial_device s3c24xx_serial0_device;extern struct serial_device s3c24xx_serial1_device;
Signature · 1 line
1.5.5.6
PATCH v5 1/1 serial: uartlite: Support for SERIAL_MULTI
Quoted 15 lines · Michal Simek
Add support for SERIAL MULTI for uartlite.
Signed-off-by Michal Simek <[email protected]>---
v2: Use in/out_be32 functionsv3: Clean coding style
v4: Simplify
userial_portsarray initializationv5: const
userial_ports
Do not use u32
Separate declarations and code by a single blank line Update copyright
Quoted 5 lines
--- common/serial.c | 14 ++++ drivers/serial/serial_xuartlite.c | 140 ++++++++++++++++++++++++++++++++----- include/serial.h | 7 ++ 3 files changed, 142 insertions(+), 19 deletions(-)
Wolfgang: Can you please comment it or applied?
Thanks,
Michal
Signature · 4 lines
Michal Simek, Ing. (M.Eng) w: www.monstr.eu p: +42-0-721842854 Maintainer of Linux kernel 2.6 Microblaze Linux - http://www.monstr.eu/fdt/ Microblaze U-BOOT custodian
Wolfgang Denk
AppliedPATCH v5 1/1 serial: uartlite: Support for SERIAL_MULTI
In reply to Michal SimekDear Michal Simek,
Quoted 15 lines · In message <[email protected]> you wrote:
Add support for SERIAL MULTI for uartlite.
Signed-off-by Michal Simek <[email protected]>---
v2: Use in/out_be32 functionsv3: Clean coding style
v4: Simplify
userial_portsarray initializationv5: const
userial_ports
Do not use u32
Separate declarations and code by a single blank line Update copyright
Quoted 5 lines
--- common/serial.c | 14 ++++ drivers/serial/serial_xuartlite.c | 140 ++++++++++++++++++++++++++++++++----- include/serial.h | 7 ++ 3 files changed, 142 insertions(+), 19 deletions(-)
Applied, thanks.
Best regards,
Wolfgang Denk
Signature · 6 lines
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de Humanity has the stars in its future, and that future is too important to be lost under the burden of juvenile folly and ignorant superstition. - Isaac Asimov
PATCH v5 1/1 serial: uartlite: Support for SERIAL_MULTI
In reply to Michal SimekDear Michal Simek,
Quoted 15 lines · In message <[email protected]> you wrote:
Add support for SERIAL MULTI for uartlite.
Signed-off-by Michal Simek <[email protected]>---
v2: Use in/out_be32 functionsv3: Clean coding style
v4: Simplify
userial_portsarray initializationv5: const
userial_ports
Do not use u32
Separate declarations and code by a single blank line Update copyright
Quoted 5 lines
--- common/serial.c | 14 ++++ drivers/serial/serial_xuartlite.c | 140 ++++++++++++++++++++++++++++++++----- include/serial.h | 7 ++ 3 files changed, 142 insertions(+), 19 deletions(-)
This commit causes new warnings for the following boards:
ml507 v5fx30teval_flash xilinx-ppc440-generic ml507_flash xilinx-ppc405-generic xilinx-ppc440-generic_f v5fx30teval xilinx-ppc405-generic_f
For example:
Configuring for xilinx-ppc440-generic - Board: xilinx-ppc440-generic, Options: SYS_TEXT_BASE=0x04000000,RESET_VECTOR_ADDRESS=0x04100000,BOOT_FROM_XMD=1 serial_xuartlite.c: In function 'uartlite_serial_putc':
serial_xuartlite.c:60: warning: initialization discards qualifiers from pointer target typeserial_xuartlite.c: In function 'uartlite_serial_getc':
serial_xuartlite.c:78: warning: initialization discards qualifiers from pointer target typeserial_xuartlite.c: In function 'uartlite_serial_tstc':
serial_xuartlite.c:87: warning: initialization discards qualifiers from pointer target type
Please fix.
Best regards,
Wolfgang Denk
Signature · 5 lines
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de "There is no distinctly American criminal class except Congress." - Mark Twain