Skip to contentSkip to conversation

eCryptfs fixes for 2.6.39-rc5

GIT PULL Tyler Hicks 2 participants 2 messages Apr 26, 2011 – Oct 6, 2011

lore
Share & tools
lore
#0 lore raw

Hi Linus,

The first 3 patches below fix bugs when eCryptfs is mounted on top of NFSv3 client mount points. The 4th patch fixes a bug that occurs when the eCryptfs file metadata can't be read during lookup. The 5th patch fixes a regression, introduced in 2.6.39-rc1, causing mtimes to not be preserved when using cp -p.

The following changes since commit 5dd12af05ca6b7d052c06a9ca4ff755fdfa25ae4:

Merge branch 'dcache-cleanup' (2011-04-24 08:51:15 -0700)

are available in the git repository at:

git://git.kernel.org/pub/scm/linux/kernel/git/ecryptfs/ecryptfs-2.6.git for-linus

Tyler Hicks (5):
eCryptfs: Remove extra d_delete in ecryptfs_rmdir
eCryptfs: dput dentries returned from dget_parent
eCryptfs: Add reference counting to lower files
eCryptfs: Handle failed metadata read in lookup
eCryptfs: Flush dirty pages in setattr

 fs/ecryptfs/crypto.c          |   21 ++++++++++++
 fs/ecryptfs/ecryptfs_kernel.h |    7 +++-
 fs/ecryptfs/file.c            |   25 +++++++-------
 fs/ecryptfs/inode.c           |   60 ++++++++++++++++++----------------
 fs/ecryptfs/kthread.c         |    6 ++--
 fs/ecryptfs/main.c            |   72 ++++++++++++++++++++++++++++------------
 fs/ecryptfs/super.c           |   16 ++-------
 7 files changed, 128 insertions(+), 79 deletions(-)
#1 lore raw
Quoted 5 lines · Tyler Hicks

Hi Linus,

The first 3 patches below fix bugs when eCryptfs is mounted on top of NFSv3 client mount points. The 4th patch fixes a bug that occurs when the eCryptfs file metadata can't be read during lookup.

Hi,

I still see occasional errors:

[33945.269075] ecryptfs_decrypt_page: Error attempting to read lower page; rc = [-4]
[33945.269084] ecryptfs_readpage: Error decrypting page; rc = [-4]

that are reported as "short read: Success" when doing a "git grep" on an encrypted repository. Redoing the grep fixes the problems for those files and may transfer it to others, until all of them are in the cache and the grep succeeds.

Reproduced with 3.0.3 and 3.1-rc8.

Paolo