arm, post, memory: fix bug if sdram base != 0x00000000

PATCH New Heiko Schocher 4 participants 4 messages Oct 7, 2011 – Oct 23, 2011

lore

Share & tools

lore

Heiko Schocher

author

2011-10-07 06:40 UTC #0 lore raw

PATCH 1/1 arm, post, memory: fix bug if sdram base != 0x00000000

commit 8d3fcb5e60b6c8e1d530dbc2e2e33ec6a44670da breaks post memory support for sdram base != 0x00000000. Fix this.

Signed-off-by Heiko Schocher <[email protected]>

Cc Valentin Longchamp <[email protected]>

Cc Holger Brunck <[email protected]>

---

$ /home/git/linux-denx/scripts/checkpatch.pl 0001-arm-post-memory-fix-bug-if-sdram-base-0x00000000.patch
total: 0 errors, 0 warnings, 14 lines checked

0001-arm-post-memory-fix-bug-if-sdram-base-0x00000000.patch has no obvious style problems and is ready for submission.

 post/drivers/memory.c |    7 ++++---
 1 files changed, 4 insertions(+), 3 deletions(-)

post/drivers/memory.c +4 -3

index 69973c0..d25e323 100644
@@ -466,10 +466,11 @@ static int memory_post_test_regions(unsigned long start, unsigned long size)
 
 	for (i = 0; i < (size >> 20) && (!ret); i++) {
 		if (!ret)
-			ret = memory_post_test_patterns(i << 20, 0x800);
-		if (!ret)
-			ret = memory_post_test_patterns((i << 20) + 0xff800,
+			ret = memory_post_test_patterns(start + (i << 20),
 				0x800);
+		if (!ret)
+			ret = memory_post_test_patterns(start + (i << 20) +
+				0xff800, 0x800);
 	}
 
 	return ret;

Signature · 1 line

1.7.6.2

Valentin Longchamp

2011-10-07 06:53 UTC #1 lore raw

PATCH 1/1 arm, post, memory: fix bug if sdram base != 0x00000000

Quoted 24 lines · Heiko Schocher

commit 8d3fcb5e60b6c8e1d530dbc2e2e33ec6a44670da breaks post memory support for sdram base != 0x00000000. Fix this.
Signed-off-by Heiko Schocher <[email protected]>
Cc Valentin Longchamp <[email protected]>
Cc Holger Brunck <[email protected]>
---
$ /home/git/linux-denx/scripts/checkpatch.pl 0001-arm-post-memory-fix-bug-if-sdram-base-0x00000000.patch
total: 0 errors, 0 warnings, 14 lines checked
0001-arm-post-memory-fix-bug-if-sdram-base-0x00000000.patch has no obvious style problems and is ready for submission.
 post/drivers/memory.c |    7 ++++---
 1 files changed, 4 insertions(+), 3 deletions(-)
post/drivers/memory.c +0 -1
index 69973c0..d25e323 100644
@@ -466,10 +466,11 @@ static int memory_post_test_regions(unsigned long start, unsigned long size)
 
 	for (i = 0; i < (size >> 20) && (!ret); i++) {
 		if (!ret)
-			ret = memory_post_test_patterns(i << 20, 0x800);

post/drivers/memory.c static int memory_post_test_regions(unsigned long start, unsigned long size) · line 476

Quoted 10 lines

post/drivers/memory.c +4 -2

-		if (!ret)
-			ret = memory_post_test_patterns((i << 20) + 0xff800,
+			ret = memory_post_test_patterns(start + (i << 20),
 				0x800);
+		if (!ret)
+			ret = memory_post_test_patterns(start + (i << 20) +
+				0xff800, 0x800);
 	}
 
 	return ret;

Thanks for fixing that Heiko: we only have boards starting @0x00000000 so I did not notice this bug.

Ackey-by Valentin Longchamp <[email protected]>

Valentin

Mike Frysinger

2011-10-07 17:19 UTC #2 lore raw

PATCH 1/1 arm, post, memory: fix bug if sdram base != 0x00000000

In reply to Heiko Schocher

Acked-by Mike Frysinger <[email protected]>

-mike
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: This is a digitally signed message part.
Url : http://lists.denx.de/pipermail/u-boot/attachments/20111007/23278bfb/attachment.pgp

Wolfgang Denk

Applied

2011-10-23 20:14 UTC #3 lore raw

PATCH 1/1 arm, post, memory: fix bug if sdram base != 0x00000000

In reply to Heiko Schocher

Dear Heiko Schocher,

Quoted 6 lines · In message <[email protected]> you wrote:

commit 8d3fcb5e60b6c8e1d530dbc2e2e33ec6a44670da breaks post memory support for sdram base != 0x00000000. Fix this.
Signed-off-by Heiko Schocher <[email protected]>
Cc Valentin Longchamp <[email protected]>
Cc Holger Brunck <[email protected]>

Quoted 8 lines

---
$ /home/git/linux-denx/scripts/checkpatch.pl 0001-arm-post-memory-fix-bug-if-sdram-base-0x00000000.patch
total: 0 errors, 0 warnings, 14 lines checked
0001-arm-post-memory-fix-bug-if-sdram-base-0x00000000.patch has no obvious style problems and is ready for submission.
 post/drivers/memory.c |    7 ++++---
 1 files changed, 4 insertions(+), 3 deletions(-)

Applied, thanks.

Best regards,

Wolfgang Denk

Signature · 10 lines

DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
"The History of every  major  Galactic  Civilization  tends  to  pass
through  three  distinct  and recognizable phases, those of Survival,
Inquiry and Sophistication, otherwise known as the How, Why and Where
phases. "For instance,  the  first  phase  is  characterized  by  the
question  'How  can  we  eat?'  the second by the question 'Why do we
eat?' and the third by the question 'Where shall we have lunch?'"
- Hitchhiker's Guide to the Galaxy