Skip to contentSkip to conversation

cifs: warn about deprecation of /proc/fs/cifs/OplockEnabled interface

PATCH In review Suresh Jayaraman 2 participants 2 messages Oct 11, 2011 1 message not in the archive

Subsystems (2)
SMB client (CIFS) Kernel SMB3 server (ksmbd)
lore
Share & tools
lore

Suresh Jayaraman

author
#0 lore raw

PATCH 2/3 cifs: warn about deprecation of /proc/fs/cifs/OplockEnabled interface

The plan is to deprecate this interface by kernel version 3.4.

Reported-by Alexander Swen <[email protected]>
Cc Jeff Layton <[email protected]>
Signed-off-by Suresh Jayaraman <[email protected]>
---
 fs/cifs/cifs_debug.c |    3 +++
 1 files changed, 3 insertions(+), 0 deletions(-)
fs/cifs/cifs_debug.c +3 -0
index 2fe3cf1..b9c06a8 100644
@@ -526,6 +526,9 @@ static ssize_t cifs_oplock_proc_write(struct file *file,
 	char c;
 	int rc;
 
+	printk(KERN_WARNING "CIFS: The /proc/fs/cifs/OplockEnabled interface "
+	       "will be removed in kernel version 3.4. Please migrate to "
+	       "using the 'enable_oplocks' module parameter in cifs.ko.");
 	rc = get_user(c, buffer);
 	if (rc)
 		return rc;

A message that is not in the archive (sent off-list or not yet received): [email protected]

#2 lore raw
Quoted 14 lines · On Tue, 11 Oct 2011 21:28:10 +0530 Suresh Jayaraman…

The plan is to deprecate this interface by kernel version 3.4.

Reported-by Alexander Swen <[email protected]>
Cc Jeff Layton <[email protected]>
Signed-off-by Suresh Jayaraman <[email protected]>
---
 fs/cifs/cifs_debug.c |    3 +++
 1 files changed, 3 insertions(+), 0 deletions(-)
fs/cifs/cifs_debug.c +0 -0
index 2fe3cf1..b9c06a8 100644

fs/cifs/cifs_debug.c static ssize_t cifs_oplock_proc_write(struct file *file, · line 531

Quoted 6 lines
fs/cifs/cifs_debug.c +3 -0
@@ -526,6 +526,9 @@ static ssize_t cifs_oplock_proc_write(struct file *file,
 	char c;
 	int rc;
 
+	printk(KERN_WARNING "CIFS: The /proc/fs/cifs/OplockEnabled interface "
+	       "will be removed in kernel version 3.4. Please migrate to "
+	       "using the 'enable_oplocks' module parameter in cifs.ko.");

You probably want a \n at the end of that line.

Quoted 3 lines
fs/cifs/cifs_debug.c +0 -0
 	rc = get_user(c, buffer);
 	if (rc)
 		return rc;
Signature · 1 line
Jeff Layton <[email protected]>