Skip to contentSkip to conversation

rgmanager: Resolve rare deadlock [RHEL5]

PATCH New Lon Hohberger 2 participants 2 messages Oct 11, 2011 – Oct 12, 2011

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 rgmanager: Resolve rare deadlock [RHEL5]

In very rare cases, it was possible to fill up a pipe used for IPC between threads during reconfiguration, causing a deadlock. This patch resolves the issue.

Resolves: rhbz#713243

---
 rgmanager/src/daemons/groups.c |    2 --
 1 files changed, 0 insertions(+), 2 deletions(-)
rgmanager/src/daemons/groups.c +0 -2
index b546421..1e93e03 100644
@@ -1737,8 +1737,6 @@ init_resource_groups(int reconfigure, int do_init, int new_config_version)
 		free(val);
 	}
 
-	/* Wait for any pending requests */
-	rg_wait_threads();
 	/* Block operations that would break during configuration
 	   changes */
 	rg_clear_initialized(FL_CONFIG);
Signature · 1 line
1.7.3.4
#1 lore raw

PATCH 1/1 rgmanager: Resolve rare deadlock [RHEL5]

ACK.

Quoted 24 lines · Lon Hohberger

In very rare cases, it was possible to fill up a pipe used for IPC between threads during reconfiguration, causing a deadlock. This patch resolves the issue.

Resolves: rhbz#713243

---
 rgmanager/src/daemons/groups.c |    2 --
 1 files changed, 0 insertions(+), 2 deletions(-)
rgmanager/src/daemons/groups.c +0 -2
index b546421..1e93e03 100644
@@ -1737,8 +1737,6 @@ init_resource_groups(int reconfigure, int do_init, int new_config_version)
 		free(val);
 	}
 
-	/* Wait for any pending requests */
-	rg_wait_threads();
 	/* Block operations that would break during configuration
 	   changes */
 	rg_clear_initialized(FL_CONFIG);