Fix possible unterminated readlink() result buffer

PATCH Applied Thomas Jarosch 2 participants 2 messages Oct 14, 2011 perf events

lore

Share & tools

lore

Thomas Jarosch

author

2011-10-14 17:28 UTC #0 lore raw

PATCH 1/1 Fix possible unterminated readlink() result buffer

No need to do "buf[len] = '\0';" since the buffer
is allocated with zalloc().

Signed-off-by Thomas Jarosch <[email protected]>

---
 tools/perf/util/header.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

tools/perf/util/header.c +1 -1

index b6c1ad1..1a1c026 100644
@@ -267,7 +267,7 @@ int build_id_cache__remove_s(const char *sbuild_id, const char *debugdir)
 	if (access(linkname, F_OK))
 		goto out_free;
 
-	if (readlink(linkname, filename, size) < 0)
+	if (readlink(linkname, filename, size-1) < 0)
 		goto out_free;
 
 	if (unlink(linkname))

Signature · 1 line

1.7.6.4

Arnaldo Carvalho de Melo

Applied

2011-10-14 17:27 UTC #1 lore raw

Em Fri, Oct 14, 2011 at 07:00:47PM +0200, Thomas Jarosch escreveu:

Quoted 4 lines

No need to do "buf[len] = '\0';" since the buffer
is allocated with zalloc().
Signed-off-by Thomas Jarosch <[email protected]>

Thanks, applied.

- Arnaldo