Skip to contentSkip to conversation

arm: comment request

U-Boot Heiko Schocher 4 participants 10 messages Oct 5, 2011 – Oct 15, 2011

lore
Share & tools
lore
#0 lore raw

Hello Albert,

can you comment/apply the following patches? As the new merge window is open, I think they can go to mainline:

arm, logbuffer: make it compileclean
http://patchwork.ozlabs.org/patch/114740/

post, arm: make post support for arm compile clean
http://patchwork.ozlabs.org/patch/114741/

cosmetic, post: Codingstyle cleanup
http://patchwork.ozlabs.org/patch/114742/

arm, post: add missing post_time_ms for arm
http://patchwork.ozlabs.org/patch/114743/

Thanks!

bye,
Heiko

Signature · 2 lines
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
#1 lore raw

Le 05/10/2011 07:55, Heiko Schocher a ?crit :

Quoted 14 lines

Hello Albert,

can you comment/apply the following patches? As the new merge window is open, I think they can go to mainline:

arm, logbuffer: make it compileclean
http://patchwork.ozlabs.org/patch/114740/

post, arm: make post support for arm compile clean
http://patchwork.ozlabs.org/patch/114741/

cosmetic, post: Codingstyle cleanup
http://patchwork.ozlabs.org/patch/114742/

Quoted 7 lines

arm, post: add missing post_time_ms for arm
http://patchwork.ozlabs.org/patch/114743/

Thanks!

bye,
Heiko

Hi Heiko,

Sorry I was unavailable for some time. I'm going through my backlog and will comment on these soon.

Amicalement,

Signature · 1 line
Albert.
#2 lore raw
Quoted 20 lines · Albert ARIBAUD

Le 05/10/2011 07:55, Heiko Schocher a ?crit :

Quoted 19 lines

Hello Albert,

can you comment/apply the following patches? As the new merge window is open, I think they can go to mainline:

arm, logbuffer: make it compileclean
http://patchwork.ozlabs.org/patch/114740/

post, arm: make post support for arm compile clean
http://patchwork.ozlabs.org/patch/114741/

cosmetic, post: Codingstyle cleanup
http://patchwork.ozlabs.org/patch/114742/

arm, post: add missing post_time_ms for arm
http://patchwork.ozlabs.org/patch/114743/

Thanks!

Quoted 7 lines
Quoted 2 lines

bye,
Heiko

Hi Heiko,

Sorry I was unavailable for some time. I'm going through my backlog and will comment on these soon.

Hi Albert,

if you can, can you also take a look at this one ?

http://patchwork.ozlabs.org/patch/114909/

This is a simply move, but it blocks other patches for i.MX.

Thanks,
Stefano

Signature · 5 lines
=====================================================================
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-0 Fax: +49-8142-66989-80  Email: office at denx.de
=====================================================================
#3 lore raw

Hi Stefano,

Le 12/10/2011 11:39, Stefano Babic a ?crit :

Quoted 29 lines · Albert ARIBAUD
Quoted 20 lines

Le 05/10/2011 07:55, Heiko Schocher a ?crit :

Quoted 19 lines

Hello Albert,

can you comment/apply the following patches? As the new merge window is open, I think they can go to mainline:

arm, logbuffer: make it compileclean
http://patchwork.ozlabs.org/patch/114740/

post, arm: make post support for arm compile clean
http://patchwork.ozlabs.org/patch/114741/

cosmetic, post: Codingstyle cleanup
http://patchwork.ozlabs.org/patch/114742/

arm, post: add missing post_time_ms for arm
http://patchwork.ozlabs.org/patch/114743/

Thanks!

Quoted 7 lines
Quoted 2 lines

bye,
Heiko

Hi Heiko,

Sorry I was unavailable for some time. I'm going through my backlog and will comment on these soon.

Quoted 7 lines

Hi Albert,

if you can, can you also take a look at this one ?

http://patchwork.ozlabs.org/patch/114909/

This is a simply move, but it blocks other patches for i.MX.

Apparently this is not a move. Did you use option -C or -M with git format-patch?

Quoted 2 lines

Thanks,
Stefano

Amicalement,

Signature · 1 line
Albert.
#4 lore raw
Quoted 10 lines · Albert ARIBAUD
Quoted 7 lines

Hi Albert,

if you can, can you also take a look at this one ?

http://patchwork.ozlabs.org/patch/114909/

This is a simply move, but it blocks other patches for i.MX.

Apparently this is not a move. Did you use option -C or -M with git format-patch?

I see..I was not aware of the -C/-M switch, thanks for this hint. I have learned something new...

I repost V2.

Thanks,
Stefano

Signature · 5 lines
=====================================================================
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-0 Fax: +49-8142-66989-80  Email: office at denx.de
=====================================================================
#5 lore raw
In reply to Heiko Schocher

Hello Heiko
I tried to apply your patches to the current master, since they are a prerequisite for your enbw_cmc patches but

[U-Boot] cosmetic, post: Codingstyle cleanup
http://patchwork.ozlabs.org/patch/114742/

did not cleanly apply.

I got it from patchwork via

$ wget -nv http://patchwork.ozlabs.org/patch/114742/mbox/ -O 114742.patch
2011-10-12 10:20:09 URL:http://patchwork.ozlabs.org/patch/114742/mbox/
[10772/10772] -> "114742.patch" [1]
$ git am 114742.patch
Applying: cosmetic, post: Codingstyle cleanup
error: patch failed: post/post.c:95
error: post/post.c: patch does not apply
Patch failed at 0001 cosmetic, post: Codingstyle cleanup
When you have resolved this problem run "git am --resolved".
If you would prefer to skip this patch, instead run "git am --skip".
To restore the original branch and stop patching run "git am --abort".

Best regards, Christian

Quoted 29 lines · Heiko Schocher

Hello Albert,

can you comment/apply the following patches? As the new merge window is open, I think they can go to mainline:

arm, logbuffer: make it compileclean
http://patchwork.ozlabs.org/patch/114740/

post, arm: make post support for arm compile clean
http://patchwork.ozlabs.org/patch/114741/

cosmetic, post: Codingstyle cleanup
http://patchwork.ozlabs.org/patch/114742/

arm, post: add missing post_time_ms for arm
http://patchwork.ozlabs.org/patch/114743/

Thanks!

bye,
Heiko
--
DENX Software Engineering GmbH, ? ? MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
_______________________________________________
U-Boot mailing list
U-Boot at lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

#6 lore raw

Hello Christian,

Quoted 8 lines · Christian Riesch

Hello Heiko
I tried to apply your patches to the current master, since they are a prerequisite for your enbw_cmc patches but

[U-Boot] cosmetic, post: Codingstyle cleanup
http://patchwork.ozlabs.org/patch/114742/

did not cleanly apply.

Oh! I just did a rebase to current TOT ... maxbe I missed something, I check this, thanks!

bye,
Heiko

Signature · 2 lines
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
#7 lore raw
In reply to Christian Riesch

Hello Christian, Albert,

Quoted 10 lines · Christian Riesch

Hello Heiko
I tried to apply your patches to the current master, since they are a prerequisite for your enbw_cmc patches but

[U-Boot] cosmetic, post: Codingstyle cleanup
http://patchwork.ozlabs.org/patch/114742/

did not cleanly apply.

I got it from patchwork via

Quoted 11 lines
$ wget -nv http://patchwork.ozlabs.org/patch/114742/mbox/ -O 114742.patch
2011-10-12 10:20:09 URL:http://patchwork.ozlabs.org/patch/114742/mbox/
[10772/10772] -> "114742.patch" [1]
$ git am 114742.patch
Applying: cosmetic, post: Codingstyle cleanup
error: patch failed: post/post.c:95
error: post/post.c: patch does not apply
Patch failed at 0001 cosmetic, post: Codingstyle cleanup
When you have resolved this problem run "git am --resolved".
If you would prefer to skip this patch, instead run "git am --skip".
To restore the original branch and stop patching run "git am --abort".

updated patches through rebase:

[U-Boot,v2] arm, logbuffer: make it compileclean
http://patchwork.ozlabs.org/patch/119183/

[U-Boot,v2] cosmetic, post: Codingstyle cleanup
http://patchwork.ozlabs.org/patch/119184/

patches not changed through rebase:

arm, post: add missing post_time_ms for arm
http://patchwork.ozlabs.org/patch/114743/

no longer needed patch:

post, arm: make post support for arm compile clean
http://patchwork.ozlabs.org/patch/114741/

bye,
Heiko

Signature · 2 lines
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
#8 lore raw

Hello Heiko,
thanks a lot, now they apply fine :-)
Christian

Quoted 53 lines · Heiko Schocher

Hello Christian, Albert,

Quoted 10 lines · Christian Riesch

Hello Heiko
I tried to apply your patches to the current master, since they are a prerequisite for your enbw_cmc patches but

[U-Boot] cosmetic, post: Codingstyle cleanup
http://patchwork.ozlabs.org/patch/114742/

did not cleanly apply.

I got it from patchwork via

Quoted 11 lines
$ wget -nv http://patchwork.ozlabs.org/patch/114742/mbox/ -O 114742.patch
2011-10-12 10:20:09 URL:http://patchwork.ozlabs.org/patch/114742/mbox/
[10772/10772] -> "114742.patch" [1]
$ git am 114742.patch
Applying: cosmetic, post: Codingstyle cleanup
error: patch failed: post/post.c:95
error: post/post.c: patch does not apply
Patch failed at 0001 cosmetic, post: Codingstyle cleanup
When you have resolved this problem run "git am --resolved".
If you would prefer to skip this patch, instead run "git am --skip".
To restore the original branch and stop patching run "git am --abort".

updated patches through rebase:

[U-Boot,v2] arm, logbuffer: make it compileclean
http://patchwork.ozlabs.org/patch/119183/

[U-Boot,v2] cosmetic, post: Codingstyle cleanup
http://patchwork.ozlabs.org/patch/119184/

patches not changed through rebase:

arm, post: add missing post_time_ms for arm
http://patchwork.ozlabs.org/patch/114743/

no longer needed patch:

post, arm: make post support for arm compile clean
http://patchwork.ozlabs.org/patch/114741/

bye,
Heiko
--
DENX Software Engineering GmbH, ? ? MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
_______________________________________________
U-Boot mailing list
U-Boot at lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

#9 lore raw
In reply to Heiko Schocher

Hi Heiko,

Le 12/10/2011 13:36, Heiko Schocher a ?crit :

Quoted 30 lines

Hello Christian, Albert,

Quoted 10 lines · Christian Riesch

Hello Heiko
I tried to apply your patches to the current master, since they are a prerequisite for your enbw_cmc patches but

[U-Boot] cosmetic, post: Codingstyle cleanup
http://patchwork.ozlabs.org/patch/114742/

did not cleanly apply.

I got it from patchwork via

Quoted 11 lines
$ wget -nv http://patchwork.ozlabs.org/patch/114742/mbox/ -O 114742.patch
2011-10-12 10:20:09 URL:http://patchwork.ozlabs.org/patch/114742/mbox/
[10772/10772] ->  "114742.patch" [1]
$ git am 114742.patch
Applying: cosmetic, post: Codingstyle cleanup
error: patch failed: post/post.c:95
error: post/post.c: patch does not apply
Patch failed at 0001 cosmetic, post: Codingstyle cleanup
When you have resolved this problem run "git am --resolved".
If you would prefer to skip this patch, instead run "git am --skip".
To restore the original branch and stop patching run "git am --abort".

updated patches through rebase:

[U-Boot,v2] arm, logbuffer: make it compileclean
http://patchwork.ozlabs.org/patch/119183/

Quoted 7 lines

[U-Boot,v2] cosmetic, post: Codingstyle cleanup
http://patchwork.ozlabs.org/patch/119184/

patches not changed through rebase:

arm, post: add missing post_time_ms for arm
http://patchwork.ozlabs.org/patch/114743/

All three patches applied, thanks.

Quoted 4 lines

no longer needed patch:

post, arm: make post support for arm compile clean
http://patchwork.ozlabs.org/patch/114741/

This patch marked superseded.

Quoted 2 lines

bye,
Heiko

Amicalement,

Signature · 1 line
Albert.