Fix logic in sanity check

PATCH New Thomas Jarosch 1 participant 1 message Oct 15, 2011 Media (V4L/DVB)

lore

Share & tools

lore

Thomas Jarosch

author

2011-10-15 21:36 UTC #0 lore raw

PATCH 1/1 Fix logic in sanity check

Detected by "cppcheck".

---
 drivers/media/video/m5mols/m5mols_core.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

drivers/media/video/m5mols/m5mols_core.c +1 -1

index fb8e4a7..e485e9e 100644
@@ -333,7 +333,7 @@ int m5mols_mode(struct m5mols_info *info, u8 mode)
 	int ret = -EINVAL;
 	u8 reg;
 
-	if (mode < REG_PARAMETER && mode > REG_CAPTURE)
+	if (mode < REG_PARAMETER || mode > REG_CAPTURE)
 		return ret;
 
 	ret = m5mols_read_u8(sd, SYSTEM_SYSMODE, &reg);

Signature · 1 line

1.7.6.4