Skip to contentSkip to conversation

cifs-utils: mention the kernel version that introduced getcifsacl

PATCH In review Suresh Jayaraman 2 participants 3 messages Oct 18, 2011 2 messages not in the archive

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 cifs-utils: mention the kernel version that introduced getcifsacl

Cc Shirish Pargaonkar <[email protected]>
---
 getcifsacl.8.in |    3 +++
 1 files changed, 3 insertions(+), 0 deletions(-)
getcifsacl.8.in +3 -0
index 02e1355..f79f7ff 100644
@@ -40,6 +40,9 @@ Print version number and exit\&.
 .RS 4
 Display a security descriptor in raw mode. Values such as type and flags are displayed in hexadecimal format, a SID is not mapped to a name.
 .RE
+.SH "NOTES"
+.PP
+Kernel support for getcifsacl/setcifsacl utilities was initially introduced in the 2.6.37 kernel.
 .SH "SEE ALSO"
 .PP
 \fBmount.cifs\fR(8),

A message that is not in the archive (sent off-list or not yet received): [email protected]

Reviewed-by
#2 lore raw
Quoted 12 lines · Suresh Jayaraman
Cc Shirish Pargaonkar <[email protected]>

---
 getcifsacl.8.in |    3 +++

 1 files changed, 3 insertions(+), 0 deletions(-)
getcifsacl.8.in +0 -0
index 02e1355..f79f7ff 100644
@@ -40,6 +40,9 @@ Print version number and exit\&.
Quoted 6 lines

 .RS 4
 Display a security descriptor in raw mode. Values such as type and flags are displayed in hexadecimal format, a SID is not mapped to a name. .RE
+.SH "NOTES"
+.PP
+Kernel support for getcifsacl/setcifsacl utilities was initially introduced in the 2.6.37 kernel.

Looks fine. Just a nitpicking, since this is a getcifsacl manpage, does setcifsacl also need to be mentioned here?

Quoted 4 lines

 .SH "SEE ALSO"
 .PP
 \fBmount.cifs\fR(8),

A message that is not in the archive (sent off-list or not yet received): CADT32eLiG_oqKEu6dtEXyH6kepMwGt+G_+5OJTxefO8y85oCHA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org

#4 lore raw
Quoted 8 lines · Shirish Pargaonkar
Quoted 7 lines · Suresh Jayaraman
Cc Shirish Pargaonkar <[email protected]>
---
 getcifsacl.8.in |    3 +++
 1 files changed, 3 insertions(+), 0 deletions(-)
Quoted 14 lines

getcifsacl.8.in Print version number and exit\&. · line 45

Quoted 11 lines
getcifsacl.8.in +3 -0
index 02e1355..f79f7ff 100644
@@ -40,6 +40,9 @@ Print version number and exit\&.
 .RS 4
 Display a security descriptor in raw mode. Values such as type and flags are displayed in hexadecimal format, a SID is not mapped to a name.
 .RE
+.SH "NOTES"
+.PP
+Kernel support for getcifsacl/setcifsacl utilities was initially introduced in the 2.6.37 kernel.

Looks fine. Just a nitpicking, since this is a getcifsacl manpage, does setcifsacl also need to be mentioned here?

The thought behind this was that - though the man pages are different, users will see them as single facility and would want to use them together mostly (assumption here is that a user who is reading and using getcifsacl or setcifsacl would also read and use the other sooner).

Suresh

Quoted 6 lines
Quoted 4 lines
getcifsacl.8.in +0 -0
 .SH "SEE ALSO"
 .PP
 \fBmount.cifs\fR(8),