spi/pl022: skip default configuration before suspending
Subsystems (2)
PATCH 3/3 spi/pl022: skip default configuration before suspending
From: Virupax Sadashivpetimath <[email protected]>
The loading of the default configuration before suspending has been in the driver since its inception, but it is not really needed. Especially so since we take to all the trouble of enabling and disabling power and clock just to do this. Let's scrap this now.
--- drivers/spi/spi-pl022.c | 5 ----- 1 files changed, 0 insertions(+), 5 deletions(-)
drivers/spi/spi-pl022.c +0 -5
@@ -2342,11 +2342,6 @@ static int pl022_suspend(struct amba_device *adev, pm_message_t state)return status; } -amba_vcore_enable (adev); -amba_pclk_enable (adev); -load_ssp_default_config (pl022); -amba_pclk_disable (adev); -amba_vcore_disable (adev);dev_dbg (&adev->dev,"suspended\n" );return 0 ; }
Signature · 1 line
1.7.3.2
PATCH 3/3 spi/pl022: skip default configuration before suspending
Quoted 20 lines · Linus WALLEIJ
From: Virupax Sadashivpetimath <[email protected]>
The loading of the default configuration before suspending has been in the driver since its inception, but it is not really needed. Especially so since we take to all the trouble of enabling and disabling power and clock just to do this. Let's scrap this now.
Signed-off-by Virupax Sadashivpetimath <[email protected]>Signed-off-by Linus Walleij <[email protected]>--- drivers/spi/spi-pl022.c | 5 ----- 1 files changed, 0 insertions(+), 5 deletions(-)drivers/spi/spi-pl022.c +0
-0@@ -2342,11 +2342,6 @@ static int pl022_suspend(struct amba_device *adev, pm_message_t state)return status;
drivers/spi/spi-pl022.c static int pl022_suspend(struct amba_device *adev, pm_message_t state) · line 2347
Quoted 10 lines
drivers/spi/spi-pl022.c +0
-5} -amba_vcore_enable (adev); -amba_pclk_enable (adev); -load_ssp_default_config (pl022); -amba_pclk_disable (adev); -amba_vcore_disable (adev);dev_dbg (&adev->dev,"suspended\n" );return 0 ; }
Signature · 1 line
viresh
PATCH 3/3 spi/pl022: skip default configuration before suspending
Quoted 23 lines · Viresh Kumar
Quoted 22 lines · Linus WALLEIJ
From: Virupax Sadashivpetimath <[email protected]>
The loading of the default configuration before suspending has been in the driver since its inception, but it is not really needed. Especially so since we take to all the trouble of enabling and disabling power and clock just to do this. Let's scrap this now.
Signed-off-by Virupax Sadashivpetimath <[email protected]>Signed-off-by Linus Walleij <[email protected]>--- drivers/spi/spi-pl022.c | 5 ----- 1 files changed, 0 insertions(+), 5 deletions(-)drivers/spi/spi-pl022.c +0
-0@@ -2342,11 +2342,6 @@ static int pl022_suspend(struct amba_device *adev, pm_message_t state)return status; }
Quoted 10 lines
drivers/spi/spi-pl022.c static int pl022_suspend(struct amba_device *adev, pm_message_t state) · line 2347
Quoted 8 lines
drivers/spi/spi-pl022.c +0
-5-amba_vcore_enable (adev); -amba_pclk_enable (adev); -load_ssp_default_config (pl022); -amba_pclk_disable (adev); -amba_vcore_disable (adev);dev_dbg (&adev->dev,"suspended\n" );return 0 ; }Reviewed-by Viresh Kumar <[email protected]>
This definitely conflicts with patches I have queued for this window.