Skip to contentSkip to conversation

unicore32: EXPORT_SYMBOL needs export.h

PATCH In review Axel Lin 3 participants 3 messages Oct 18, 2011

lore
Share & tools
lore

Axel Lin

author
#0 lore raw

PATCH 1/1 unicore32: EXPORT_SYMBOL needs export.h

Include export.h to fix below warning:

CC arch/unicore32/mm/init.o
arch/unicore32/mm/init.c:227: warning: data definition has no type or storage class arch/unicore32/mm/init.c:227: warning: type defaults to 'int' in declaration of 'EXPORT_SYMBOL' arch/unicore32/mm/init.c:227: warning: parameter names (without types) in function declaration

Signed-off-by Axel Lin <[email protected]>

---
This patch is against linux-next 20111014.
export.h only exist in Paul's tree now.
I think this patch should route via Paul's module.h splitup tree.

Axel

 arch/unicore32/mm/init.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)
arch/unicore32/mm/init.c +1 -0
index 2d3e711..3b379cd 100644
@@ -20,6 +20,7 @@
 #include <linux/memblock.h>
 #include <linux/sort.h>
 #include <linux/dma-mapping.h>
+#include <linux/export.h>
 
 #include <asm/sections.h>
 #include <asm/setup.h>
Signature · 1 line
1.7.5.4
#1 lore raw

It seems the same problem with cross-compiler.
And I can't produce the same warnings.

Thanks Axel.

Guan Xuetao

Quoted 29 lines · Axel Lin

Include export.h to fix below warning:

CC arch/unicore32/mm/init.o
arch/unicore32/mm/init.c:227: warning: data definition has no type or storage class arch/unicore32/mm/init.c:227: warning: type defaults to 'int' in declaration of 'EXPORT_SYMBOL' arch/unicore32/mm/init.c:227: warning: parameter names (without types) in function declaration

Signed-off-by Axel Lin <[email protected]>

---
This patch is against linux-next 20111014.
export.h only exist in Paul's tree now.
I think this patch should route via Paul's module.h splitup tree.

Axel

 arch/unicore32/mm/init.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)
arch/unicore32/mm/init.c +1 -0
index 2d3e711..3b379cd 100644
@@ -20,6 +20,7 @@
 #include <linux/memblock.h>
 #include <linux/sort.h>
 #include <linux/dma-mapping.h>
+#include <linux/export.h>
 
 #include <asm/sections.h>
 #include <asm/setup.h>
#2 lore raw
In reply to Axel Lin
Quoted 7 lines · Axel Lin

Include export.h to fix below warning:

CC arch/unicore32/mm/init.o
arch/unicore32/mm/init.c:227: warning: data definition has no type or storage class arch/unicore32/mm/init.c:227: warning: type defaults to 'int' in declaration of 'EXPORT_SYMBOL' arch/unicore32/mm/init.c:227: warning: parameter names (without types) in function declaration

Quoted 5 lines
Signed-off-by Axel Lin <[email protected]>

---
This patch is against linux-next 20111014.
export.h only exist in Paul's tree now.
I think this patch should route via Paul's module.h splitup tree.

Correct. I will add it.

Thanks.
Paul.

Quoted 17 lines

Axel

 arch/unicore32/mm/init.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)
arch/unicore32/mm/init.c +1 -0
index 2d3e711..3b379cd 100644
@@ -20,6 +20,7 @@
 #include <linux/memblock.h>
 #include <linux/sort.h>
 #include <linux/dma-mapping.h>
+#include <linux/export.h>
 
 #include <asm/sections.h>
 #include <asm/setup.h>