Skip to contentSkip to conversation

Add SPL malloc to devkit 8000

PATCH New Tom Rini 3 participants 5 messages Oct 18, 2011 – Oct 21, 2011

lore
Share & tools
lore

Tom Rini

author
#0 lore raw

cover Add SPL malloc to devkit 8000

Hey all,

As part of fixing FAT support in SPL, Aneesh V added a requirement that all omap-common/spl.c using platforms (so omap3 and omap4 currently) also define malloc space. Based on how this was done for omap4 I've added in a scratch space for devkit 8000. This change is required for the devkit8000 + MMC SPL changes that are currently in u-boot-arm (which require the changes from Aneesh V for malloc with vfat).

Signature · 1 line
Tom 
author
#1 lore raw

PATCH 1/1 devkit8000: Add malloc space for SPL

With malloc support being a new requirement for all ARM SPL implementations, define a small area for use on devkit8000.

Cc Frederik Kriewitz <[email protected]>
Cc Albert ARIBAUD <[email protected]>
Cc Simon Schwarz <[email protected]>
---
 include/configs/devkit8000.h |    3 +++
 1 files changed, 3 insertions(+), 0 deletions(-)
include/configs/devkit8000.h +3 -0
index ba0d23e..dc884e9 100644
@@ -353,4 +353,7 @@
 #define CONFIG_SYS_NAND_U_BOOT_OFFS	0x80000
 #define CONFIG_SYS_NAND_U_BOOT_SIZE	0x200000
 
+#define CONFIG_SYS_SPL_MALLOC_START	0x80108000
+#define CONFIG_SYS_SPL_MALLOC_SIZE	0x100000	/* 1 MB */
+
 #endif /* __CONFIG_H */
Signature · 1 line
1.7.0.4
#2 lore raw

PATCH 1/1 devkit8000: Add malloc space for SPL

Hi Tom,

Le 18/10/2011 21:54, Tom Rini a ?crit :

Quoted 16 lines

With malloc support being a new requirement for all ARM SPL implementations, define a small area for use on devkit8000.

Cc Frederik Kriewitz<[email protected]>
Cc Albert ARIBAUD<[email protected]>
Cc Simon Schwarz<[email protected]>
---
  include/configs/devkit8000.h |    3 +++
  1 files changed, 3 insertions(+), 0 deletions(-)
include/configs/devkit8000.h +0 -0
index ba0d23e..dc884e9 100644

include/configs/devkit8000.h line 359

Quoted 7 lines
include/configs/devkit8000.h +3 -0
@@ -353,4 +353,7 @@
  #define CONFIG_SYS_NAND_U_BOOT_OFFS	0x80000
  #define CONFIG_SYS_NAND_U_BOOT_SIZE	0x200000
 
+#define CONFIG_SYS_SPL_MALLOC_START	0x80108000
+#define CONFIG_SYS_SPL_MALLOC_SIZE	0x100000	/* 1 MB */
+
  #endif /* __CONFIG_H */

Hadn't you submitted this already twelve minutes before?

Amicalement,

Signature · 1 line
Albert.
author
#3 lore raw

PATCH 1/1 devkit8000: Add malloc space for SPL

Quoted 22 lines · Albert ARIBAUD

Hi Tom,

Le 18/10/2011 21:54, Tom Rini a ?crit :

Quoted 19 lines

With malloc support being a new requirement for all ARM SPL implementations, define a small area for use on devkit8000.

Cc Frederik Kriewitz<[email protected]>
Cc Albert ARIBAUD<[email protected]>
Cc Simon Schwarz<[email protected]>
---
  include/configs/devkit8000.h |    3 +++
  1 files changed, 3 insertions(+), 0 deletions(-)
include/configs/devkit8000.h +0 -0
index ba0d23e..dc884e9 100644
@@ -353,4 +353,7 @@
  #define CONFIG_SYS_NAND_U_BOOT_OFFS    0x80000
  #define CONFIG_SYS_NAND_U_BOOT_SIZE    0x200000
 
Quoted 6 lines

include/configs/devkit8000.h line 359

Quoted 4 lines
include/configs/devkit8000.h +3 -0
+#define CONFIG_SYS_SPL_MALLOC_START    0x80108000
+#define CONFIG_SYS_SPL_MALLOC_SIZE    0x100000    /* 1 MB */
+
  #endif /* __CONFIG_H */

Hadn't you submitted this already twelve minutes before?

Yes, but not to the ML, sorry for the duplicates to the CC'd folks.

Signature · 1 line
Tom
#4 lore raw

PATCH 1/1 devkit8000: Add malloc space for SPL

In reply to Tom Rini
Quoted 16 lines · Tom Rini

With malloc support being a new requirement for all ARM SPL implementations, define a small area for use on devkit8000.

Cc Frederik Kriewitz<[email protected]>
Cc Albert ARIBAUD<[email protected]>
Cc Simon Schwarz<[email protected]>
---
  include/configs/devkit8000.h |    3 +++
  1 files changed, 3 insertions(+), 0 deletions(-)
include/configs/devkit8000.h +0 -0
index ba0d23e..dc884e9 100644

include/configs/devkit8000.h line 359

Quoted 7 lines
include/configs/devkit8000.h +3 -0
@@ -353,4 +353,7 @@
  #define CONFIG_SYS_NAND_U_BOOT_OFFS	0x80000
  #define CONFIG_SYS_NAND_U_BOOT_SIZE	0x200000
 
+#define CONFIG_SYS_SPL_MALLOC_START	0x80108000
+#define CONFIG_SYS_SPL_MALLOC_SIZE	0x100000	/* 1 MB */
+
  #endif /* __CONFIG_H */

With NAND it works fine.

But with MMC there seems to be another problem with u-boot-arm. (is not booting at all) so:

Presumably I won't have the time to look into the MMC problem until next week - volunteers? ;)

Regards
Simon