Add getenv_ulong to return an environment var as a number

subject is "int" but implementation is "ulong"
-mike

Quoted 1 line · Mike Frysinger

subject is "int" but implementation is "ulong"

Yes - I wonder if I can just submit a V2 for that one patch with a new subject?

Quoted 5 lines · On Friday 14 October 2011 12:47:56 Simon Glass wrote:

Quoted 1 line · Mike Frysinger

subject is "int" but implementation is "ulong"

Yes - I wonder if I can just submit a V2 for that one patch with a new subject?

that's fine (i do it all the time). ?although in the future, your v2 should probably have the reply-to field set to the v1 patch.
-mike

Quoted 7 lines · Mike Frysinger

Quoted 5 lines · On Friday 14 October 2011 12:47:56 Simon Glass wrote:

Quoted 1 line · Mike Frysinger

subject is "int" but implementation is "ulong"

Yes - I wonder if I can just submit a V2 for that one patch with a new subject?

Quoted 2 lines

that's fine (i do it all the time). although in the future, your v2 should probably have the reply-to field set to the v1 patch.

OK I need to figure out how to do that with git send-email. I can see how to do it with a single email, but I suppose if I post a V2 then every email should be in reply to its corresponding V1, is that right?

BTW I also need some patchwork automation since a lot of the patches marked 'NEW' in there are not - 'pwclient update' is most of it I suppose, if it had an option to get my password back - no reply to this:

http://lists.ozlabs.org/pipermail/patchwork/2010-December/000347.html

Quoted 11 lines · On Friday 14 October 2011 13:42:07 Simon Glass wrote:

Quoted 9 lines · Mike Frysinger

Quoted 5 lines · On Friday 14 October 2011 12:47:56 Simon Glass wrote:

Quoted 1 line · Mike Frysinger

subject is "int" but implementation is "ulong"

Yes - I wonder if I can just submit a V2 for that one patch with a new subject?

that's fine (i do it all the time). ?although in the future, your v2 should probably have the reply-to field set to the v1 patch.

Quoted 3 lines

OK I need to figure out how to do that with git send-email. I can see how to do it with a single email, but I suppose if I post a V2 then every email should be in reply to its corresponding V1, is that right?

if you send out a whole new patchseries, i don't think each sub patch should be a reply to the original. ?having it be a new tree by itself is fine.

Quoted 6 lines

BTW I also need some patchwork automation since a lot of the patches marked 'NEW' in there are not - 'pwclient update' is most of it I suppose, if it had an option to get my password back - no reply to this:

Quoted 1 line

http://lists.ozlabs.org/pipermail/patchwork/2010-December/000347.html

i've only used the web interface so far. ?and this extension makes life a lot easier when you have to select a lot (but not all) of the patches in a query:
https://chrome.google.com/webstore/detail/ldopaogbegnhconlboidfjcmidndkbeg
-mike

include/common.h +0 -0

+/**
+ * Decode the value of an environment variable and return it.
+ *
+ * @param name Name of environemnt variable
+ * @param base Number base to use (normally 10, or 16 for hex)
+ * @param default_val Default value to return if the variable is not
+ * found
+ * @return the decoded value, or default_val if not found
+ */

This changes the board code to use the new getenv_ulong() function.

Signed-off-by Simon Glass <[email protected]>

---
 arch/arm/lib/board.c |   36 +++++++++++-------------------------
 1 files changed, 11 insertions(+), 25 deletions(-)

This changes the board code to use the new getenv_ulong() function.

Signed-off-by Simon Glass <[email protected]>

---
 arch/arm/lib/board.c |   36 +++++++++++-------------------------
 1 files changed, 11 insertions(+), 25 deletions(-)

Dear Simon Glass,

Quoted 6 lines · In message <[email protected]> you wrote:

This changes the board code to use the new getenv_ulong() function.

Signed-off-by Simon Glass <[email protected]>

---
?arch/arm/lib/board.c | ? 36 +++++++++++------------------------- ?1 files changed, 11 insertions(+), 25 deletions(-)

Urgh...

This breaks almost all ARM boards like this:

Configuring for a320evb board...
board.c: In function 'board_init_r':
board.c:569: error: 's' undeclared (first use in this function) board.c:569: error: (Each undeclared identifier is reported only once board.c:569: error: for each function it appears in.) make[1]: *** [/work/wd/tmp-arm/arch/arm/lib/board.o] Error 1
make: *** [/work/wd/tmp-arm/arch/arm/lib/libarm.o] Error 2

Didn't you run MAKELL?

Best regards,

Wolfgang Denk

--
DENX Software Engineering GmbH, ? ? MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
ADVISORY: ?There is ?an ?Extremely Small ?but ?Nonzero ?Chance ?That, Through a Process Know as "Tunneling," This Product May Spontaneously Disappear ?from Its Present Location and Reappear at Any Random Place in the Universe, Including Your Neighbor's Domicile. The Manufacturer Will Not Be Responsible for Any Damages ?or ?Inconvenience ?That ?May Result.

Commit dc8bbea "arm: Use getenv_ulong() in place of getenv(), strtoul" introduced a build error for all ARM boards with network support:

board.c: In function 'board_init_r':
board.c:569: error: 's' undeclared (first use in this function) board.c:569: error: (Each undeclared identifier is reported only once board.c:569: error: for each function it appears in.)

Fix it.

Signed-off-by Wolfgang Denk <[email protected]>

---
?arch/arm/lib/board.c | ? ?3 +++
?1 files changed, 3 insertions(+), 0 deletions(-)

arch/arm/lib/board.c +0 -0

index c764844..367cf6b 100644
@@ -441,6 +441,9 @@ void board_init_r(gd_t *id, ulong dest_addr)
 ?#if !defined(CONFIG_SYS_NO_FLASH)
 ? ? ? ?ulong flash_size;

?#endif

arch/arm/lib/board.c +3 -0

+#if defined(CONFIG_CMD_NET)
+ ? ? ? char *s;
+#endif

? ? ? ?gd = id;

--
1.7.6.2

_______________________________________________
U-Boot mailing list
U-Boot at lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

Commit dc8bbea "arm: Use getenv_ulong() in place of getenv(), strtoul" introduced a build error for all ARM boards with network support:

board.c: In function 'board_init_r':
board.c:569: error: 's' undeclared (first use in this function) board.c:569: error: (Each undeclared identifier is reported only once board.c:569: error: for each function it appears in.)

Fix it.

Signed-off-by Wolfgang Denk <[email protected]>

This changes the board code to use the new getenv_ulong() function.

Signed-off-by Simon Glass <[email protected]>

---
 arch/avr32/lib/board.c |   16 +++-------------
 1 files changed, 3 insertions(+), 13 deletions(-)

This changes the board code to use the new getenv_ulong() function.

Signed-off-by Simon Glass <[email protected]>

---
 arch/blackfin/lib/board.c |    9 ++-------
 1 files changed, 2 insertions(+), 7 deletions(-)

This changes the board code to use the new getenv_ulong() function.

Signed-off-by Simon Glass <[email protected]>

---
 arch/m68k/lib/board.c |   33 ++++++++-------------------------
 1 files changed, 8 insertions(+), 25 deletions(-)

This changes the board code to use the new getenv_ulong() function.

Signed-off-by Simon Glass <[email protected]>

---
 arch/microblaze/lib/board.c |    6 ++----
 1 files changed, 2 insertions(+), 4 deletions(-)

This changes the board code to use the new getenv_ulong() function.

Signed-off-by Simon Glass <[email protected]>

---
 arch/mips/lib/board.c |   14 +++-----------
 1 files changed, 3 insertions(+), 11 deletions(-)

This changes the board code to use the new getenv_ulong() function.

Signed-off-by Simon Glass <[email protected]>

This changes the board code to use the new getenv_ulong() function.

Signed-off-by Simon Glass <[email protected]>

---
 arch/powerpc/lib/board.c |   33 ++++++++-------------------------
 1 files changed, 8 insertions(+), 25 deletions(-)

Commit 1272592 "powerpc: Use getenv_ulong() in place of getenv(), strtoul" instroduced a build warning for some PPC systems:

board.c: In function 'board_init_r':
board.c:626: warning: unused variable 's'

Fix it.

Signed-off-by Wolfgang Denk <[email protected]>

---
?arch/powerpc/lib/board.c | ? ?5 +++--
?1 files changed, 3 insertions(+), 2 deletions(-)

arch/powerpc/lib/board.c +0 -0

index 6cb0ed6..aff1a0c 100644
@@ -623,10 +623,11 @@ void board_init_f (ulong bootflag)

?*/
?void board_init_r (gd_t *id, ulong dest_addr)
?{
- ? ? ? char *s;
? ? ? ?bd_t *bd;
? ? ? ?ulong malloc_start;

arch/powerpc/lib/board.c +3 -1

-
+#if defined(CONFIG_SYS_FLASH_CHECKSUM) || defined(CONFIG_CMD_NET)
+ ? ? ? char *s;
+#endif

?#ifndef CONFIG_SYS_NO_FLASH
? ? ? ?ulong flash_size;
?#endif
--
1.7.6.2

_______________________________________________
U-Boot mailing list
U-Boot at lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

Hi Wolfgang,

Quoted 6 lines · Wolfgang Denk

Commit 1272592 "powerpc: Use getenv_ulong() in place of getenv(), strtoul" instroduced a build warning for some PPC systems:

board.c: In function 'board_init_r':
board.c:626: warning: unused variable 's'

Quoted 3 lines

Fix it.

Signed-off-by Wolfgang Denk <[email protected]>

I sent an alternative to this but they are roughly equivalent so:

Acked-by Simon Glass <[email protected]>

Commit 1272592 "powerpc: Use getenv_ulong() in place of getenv(), strtoul" instroduced a build warning for some PPC systems:

board.c: In function 'board_init_r':
board.c:626: warning: unused variable 's'

Fix it.

Signed-off-by Wolfgang Denk <[email protected]>

---
 arch/powerpc/lib/board.c |    5 +++--
 1 files changed, 3 insertions(+), 2 deletions(-)

Dear Wolfgang Denk,

Quoted 6 lines · In message <[email protected]> you wrote:

Commit 1272592 "powerpc: Use getenv_ulong() in place of getenv(), strtoul" instroduced a build warning for some PPC systems:

board.c: In function 'board_init_r':
board.c:626: warning: unused variable 's'

Quoted 6 lines

Fix it.

Signed-off-by Wolfgang Denk <[email protected]>

---
arch/powerpc/lib/board.c | 5 +++--

1 files changed, 3 insertions(+), 2 deletions(-)

Applied, thanks.

Best regards,

Wolfgang Denk

Quoted 16 lines · Wolfgang Denk

Dear Wolfgang Denk,

Quoted 6 lines · In message <[email protected]> you wrote:

Commit 1272592 "powerpc: Use getenv_ulong() in place of getenv(), strtoul" instroduced a build warning for some PPC systems:

board.c: In function 'board_init_r':
board.c:626: warning: unused variable 's'

Quoted 6 lines

Fix it.

Signed-off-by Wolfgang Denk <[email protected]>

---
arch/powerpc/lib/board.c | 5 +++--

1 files changed, 3 insertions(+), 2 deletions(-)

Quoted 5 lines

Applied, thanks.

Best regards,

Wolfgang Denk

I'm still seeing this warning when building MPC8536DS_config

- k
_______________________________________________
U-Boot mailing list
U-Boot at lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

Quoted 10 lines · Kumar Gala

Quoted 9 lines · Wolfgang Denk

Quoted 8 lines · In message <[email protected]> you wrote:

Commit 1272592 "powerpc: Use getenv_ulong() in place of getenv(), strtoul" instroduced a build warning for some PPC systems:

board.c: In function 'board_init_r':
board.c:626: warning: unused variable 's'

Fix it.

Quoted 8 lines

Quoted 6 lines

Quoted 4 lines

Signed-off-by Wolfgang Denk <[email protected]>

---
arch/powerpc/lib/board.c | 5 +++--

1 files changed, 3 insertions(+), 2 deletions(-)

Applied, thanks.

I'm still seeing this warning when building MPC8536DS_config

I think we need to revert this now.

I don't see why you'd need it.

Quoted 17 lines · Kumar Gala

Quoted 16 lines · Wolfgang Denk

Quoted 6 lines · Wolfgang Denk

Commit 1272592 "powerpc: Use getenv_ulong() in place of getenv(), strtoul" instroduced a build warning for some PPC systems:

board.c: In function 'board_init_r':
board.c:626: warning: unused variable 's'

Quoted 6 lines

Fix it.

Signed-off-by Wolfgang Denk <[email protected]>

---
arch/powerpc/lib/board.c | 5 +++--

1 files changed, 3 insertions(+), 2 deletions(-)

Applied, thanks.

Quoted 5 lines

Quoted 3 lines

Best regards,

Wolfgang Denk

I'm still seeing this warning when building MPC8536DS_config

I think we need to revert this now.

I don't see why you'd need it.

This reverts commit a9f4fc3fe571cc99260b063ad0ff291d31bafed0.

commit aab773a47a8f7f40b9d7c4877853b00d22fb1347 already fixed the issue.

Signed-off-by Kim Phillips <[email protected]>

---
 arch/powerpc/lib/board.c |    4 +---
 1 files changed, 1 insertions(+), 3 deletions(-)

arch/powerpc/lib/board.c +0 -0

index 3a1b375..508075f 100644

Quoted 14 lines · Kim Phillips

This reverts commit a9f4fc3fe571cc99260b063ad0ff291d31bafed0.

commit aab773a47a8f7f40b9d7c4877853b00d22fb1347 already fixed the issue.

arch/powerpc/lib/board.c +0 -0

@@ -625,9 +625,7 @@ void board_init_r (gd_t *id, ulong dest_addr)
 
 {
 
 	bd_t *bd;
 	ulong malloc_start;
 

arch/powerpc/lib/board.c void board_init_r (gd_t *id, ulong dest_addr) · line 628

Quoted 4 lines

arch/powerpc/lib/board.c +1 -3

-#if defined(CONFIG_SYS_FLASH_CHECKSUM) || defined(CONFIG_CMD_NET)
-	char *s;
-#endif
+

Which tree / version is your patch based on? It does not apply to master. We fixed this with commit commit ecfd752.

have you pushed out your master in a while ? i see your tree sitting at fec79acc864bed049b6beae719ccbf2bbec5403a which still has this warning. i also don't see commit ecfd752 in your tree.

This changes the board code to use the new getenv_ulong() function.

Signed-off-by Simon Glass <[email protected]>

---
 arch/sparc/lib/board.c |   13 +++----------
 1 files changed, 3 insertions(+), 10 deletions(-)

This changes the board code to use the new getenv_ulong() function.

Signed-off-by Simon Glass <[email protected]>

---
 arch/x86/lib/board.c |   14 +++-----------
 1 files changed, 3 insertions(+), 11 deletions(-)

Several places in U-Boot's board files can make use of a function like this, so this patch series creates the function, and changes the board files to use it.

As suggested by Mike Frysinger<[email protected]>.

Simon Glass (10):
Add getenv_int() to read an integer from an environment variable

Dear Simon Glass,

Quoted 11 lines

Several places in U-Boot's board files can make use of a function like this,
so this patch series creates the function, and changes the board files to use it.

As suggested by Mike Frysinger<[email protected]>.

Simon Glass (10):
? Add getenv_int() to read an integer from an environment variable

Just a question (I cannot dig deep into this):

Since getenv_* might be used before relocation (it is for baudrate, am I right?),
and I cannot see how getenv_int() would work before relocation.

Quoted 11 lines · Reinhard Meyer

Quoted 10 lines

Several places in U-Boot's board files can make use of a function like this,
so this patch series creates the function, and changes the board files to use it.

As suggested by Mike Frysinger<[email protected]>.

Simon Glass (10):
Add getenv_int() to read an integer from an environment variable

Quoted 5 lines

Just a question (I cannot dig deep into this):

Since getenv_* might be used before relocation (it is for baudrate, am I right?),
and I cannot see how getenv_int() would work before relocation.

From what I can tell the existing getenv() function deals with this automatically by looking at the global flags.

Quoted 3 lines

From what I can tell the existing getenv() function deals with this automatically by looking at the global flags.

yep, and that should be sufficient. in the pre-relocation stages, you can only have one active getenv() at a time, but that isn't anything new, and in this particular case, it's fine.

Dear Mike Frysinger,

Quoted 1 line · In message <[email protected]> you wrote:

Quoted 6 lines

Quoted 2 lines

From what I can tell the existing getenv() function deals with this automatically by looking at the global flags.

yep, and that should be sufficient. ?in the pre-relocation stages, you can only have one active getenv() at a time, but that isn't anything new, and in this particular case, it's fine.

No, it's not. ?I NAK this.

Best regards,

Wolfgang Denk

--
DENX Software Engineering GmbH, ? ? MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de A wise person makes his ?own ?decisions, ?a ?weak ?one ?obeys ?public opinion. ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? -- Chinese proverb
_______________________________________________
U-Boot mailing list
U-Boot at lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

Quoted 2 lines

and I cannot see how getenv_int() would work before relocation.

From what I can tell the existing getenv() function deals with this automatically by looking at the global flags.

Quoted 4 lines · Simon Glass

Quoted 1 line

and I cannot see how getenv_int() would work before relocation.

From what I can tell the existing getenv() function deals with this automatically by looking at the global flags.

This is intended just for emergency cases to fix a number of places where code is broken, and maintainers don't bother to fix their code.

It is NOT recommended to use this in general.

Please do NOT replace the use of getenv_f() with (direct or indirect) calls to getenv().

Quoted 9 lines · On Friday 14 October 2011 15:27:59 Wolfgang Denk wrote:

Quoted 4 lines · Simon Glass

Quoted 1 line

and I cannot see how getenv_int() would work before relocation.

From what I can tell the existing getenv() function deals with this automatically by looking at the global flags.

This is intended just for emergency cases to fix a number of places where code is broken, and maintainers don't bother to fix their code.

Quoted 4 lines

It is NOT recommended to use this in general.

Please do NOT replace the use of getenv_f() with (direct or indirect) calls to getenv().

should we have getenv_ulong() and getenv_ulong_r() then ? -mike