rtc: Make mc13783-rtc driver generic

PATCH New Fabio Estevam 2 participants 5 messages Oct 24, 2011 – Oct 25, 2011

Subsystems (2)

Arm i.MX and Layerscape Real time clock (RTC)

lore

Share & tools

lore

Fabio Estevam

author

2011-10-24 16:44 UTC #0 lore raw

PATCH v2 1/2 rtc: Make mc13783-rtc driver generic

Rename mc13783-rtc so that it can be used for both MC13783 and MC13892 PMICs.

efikamx board, for example, does use a MC13892 PMIC, but the RTC selection is currently made as:

#define CONFIG_RTC_MC13783

,which is not very obvious.

Let the MC13783 and MC13892 RTC be selected by:

#define CONFIG_RTC_MC13XXX

Signed-off-by Fabio Estevam <[email protected]>

---
Changes since v1:
- Properly handle the file rename via git.

 README                                       |    2 +-
 drivers/rtc/Makefile                         |    2 +-
 drivers/rtc/{mc13783-rtc.c => mc13xxx-rtc.c} |    0
 include/configs/efikamx.h                    |    2 +-
 include/configs/imx31_litekit.h              |    2 +-
 include/configs/mx31ads.h                    |    2 +-
 include/configs/mx31pdk.h                    |    2 +-
 include/configs/qong.h                       |    2 +-
 include/configs/vision2.h                    |    2 +-
 9 files changed, 8 insertions(+), 8 deletions(-)
 rename drivers/rtc/{mc13783-rtc.c => mc13xxx-rtc.c} (100%)

README +1 -1

index eb9ade9..1e20452 100644
@@ -841,7 +841,7 @@ The following options need to be configured:
 
 		CONFIG_RTC_MPC8xx	- use internal RTC of MPC8xx
 		CONFIG_RTC_PCF8563	- use Philips PCF8563 RTC
-		CONFIG_RTC_MC13783	- use MC13783 RTC
+		CONFIG_RTC_MC13XXX	- use MC13783 or MC13892 RTC
 		CONFIG_RTC_MC146818	- use MC146818 RTC
 		CONFIG_RTC_DS1307	- use Maxim, Inc. DS1307 RTC
 		CONFIG_RTC_DS1337	- use Maxim, Inc. DS1337 RTC

drivers/rtc/Makefile +1 -1

index df440c6..a16f590 100644
@@ -50,7 +50,7 @@ COBJS-$(CONFIG_RTC_M41T62) += m41t62.o
 COBJS-$(CONFIG_RTC_M41T94) += m41t94.o
 COBJS-$(CONFIG_RTC_M48T35A) += m48t35ax.o
 COBJS-$(CONFIG_RTC_MAX6900) += max6900.o
-COBJS-$(CONFIG_RTC_MC13783) += mc13783-rtc.o
+COBJS-$(CONFIG_RTC_MC13XXX) += mc13xxx-rtc.o
 COBJS-$(CONFIG_RTC_MC146818) += mc146818.o
 COBJS-$(CONFIG_MCFRTC) += mcfrtc.o
 COBJS-$(CONFIG_RTC_MK48T59) += mk48t59.o

drivers/rtc/mc13xxx-rtc.c renamed from drivers/rtc/mc13783-rtc.c +0 -0

similarity index 100%
rename from drivers/rtc/mc13783-rtc.c
rename to drivers/rtc/mc13xxx-rtc.c

include/configs/efikamx.h +1 -1

index 7e4b424..68bede9 100644
@@ -132,7 +132,7 @@
 #define CONFIG_FSL_PMIC_CLK		25000000
 #define CONFIG_FSL_PMIC_MODE		(SPI_MODE_0 | SPI_CS_HIGH)
 #define CONFIG_FSL_PMIC_BITLEN	32
-#define CONFIG_RTC_MC13783
+#define CONFIG_RTC_MC13XXX
 #endif
 
 /*

include/configs/imx31_litekit.h +1 -1

index 89e71c0..1455ea2 100644
@@ -81,7 +81,7 @@
 #define CONFIG_FSL_PMIC_CLK	1000000
 #define CONFIG_FSL_PMIC_MODE	(SPI_MODE_0 | SPI_CS_HIGH)
 #define CONFIG_FSL_PMIC_BITLEN	32
-#define CONFIG_RTC_MC13783
+#define CONFIG_RTC_MC13XXX
 
 /* allow to overwrite serial and ethaddr */
 #define CONFIG_ENV_OVERWRITE

include/configs/mx31ads.h +1 -1

index c9d80ef..7e011ae 100644
@@ -78,7 +78,7 @@
 #define CONFIG_FSL_PMIC_CLK	1000000
 #define CONFIG_FSL_PMIC_MODE	(SPI_MODE_0 | SPI_CS_HIGH)
 #define CONFIG_FSL_PMIC_BITLEN	32
-#define CONFIG_RTC_MC13783
+#define CONFIG_RTC_MC13XXX
 
 /* allow to overwrite serial and ethaddr */
 #define CONFIG_ENV_OVERWRITE

include/configs/mx31pdk.h +1 -1

index b72f30b..9d64827 100644
@@ -79,7 +79,7 @@
 #define CONFIG_FSL_PMIC_CLK	1000000
 #define CONFIG_FSL_PMIC_MODE	(SPI_MODE_0 | SPI_CS_HIGH)
 #define CONFIG_FSL_PMIC_BITLEN	32
-#define CONFIG_RTC_MC13783
+#define CONFIG_RTC_MC13XXX
 
 /* allow to overwrite serial and ethaddr */
 #define CONFIG_ENV_OVERWRITE

include/configs/qong.h +1 -1

index 4820914..4409186 100644
@@ -58,7 +58,7 @@
 #define CONFIG_MXC_SPI
 #define CONFIG_DEFAULT_SPI_BUS	1
 #define CONFIG_DEFAULT_SPI_MODE	(SPI_MODE_0 | SPI_CS_HIGH)
-#define CONFIG_RTC_MC13783
+#define CONFIG_RTC_MC13XXX
 
 #define CONFIG_PMIC
 #define CONFIG_PMIC_SPI

include/configs/vision2.h +1 -1

index a2a9f3f..5a4cd66 100644
@@ -95,7 +95,7 @@
 #define CONFIG_FSL_PMIC_CLK	2500000
 #define CONFIG_FSL_PMIC_MODE	SPI_MODE_0
 #define CONFIG_FSL_PMIC_BITLEN	32
-#define CONFIG_RTC_MC13783
+#define CONFIG_RTC_MC13XXX
 
 /*
  * MMC Configs

Signature · 1 line

1.6.0.4

Fabio Estevam

author

2011-10-24 16:44 UTC #1 lore raw

PATCH v2 2/2 mx51evk: Add RTC support

MX51EVK has a MC13892 PMIC. Add RTC support.

Tested via 'date' command that reads the PMIC RTC registers:

MX51EVK U-Boot > date
Date: 1970-01-01 (Thursday) Time: 0:40:35

Signed-off-by Fabio Estevam <[email protected]>

---
Changes since v1:
- No changes

 include/configs/mx51evk.h |    3 +++
 1 files changed, 3 insertions(+), 0 deletions(-)

include/configs/mx51evk.h +3 -0

index 2c449b8..67b5f0b 100644
@@ -79,6 +79,7 @@
 #define CONFIG_FSL_PMIC_CLK	2500000
 #define CONFIG_FSL_PMIC_MODE	(SPI_MODE_0 | SPI_CS_HIGH)
 #define CONFIG_FSL_PMIC_BITLEN	32
+#define CONFIG_RTC_MC13XXX
 
 /*
  * MMC Configs

@@ -124,6 +125,8 @@
 
 #undef CONFIG_CMD_IMLS
 
+#define CONFIG_CMD_DATE
+
 #define CONFIG_BOOTDELAY	3
 
 #define CONFIG_ETHPRIME		"FEC0"

Signature · 1 line

1.6.0.4

Stefano Babic

2011-10-25 09:28 UTC #2 lore raw

PATCH v2 2/2 mx51evk: Add RTC support

Quoted 9 lines · Fabio Estevam

MX51EVK has a MC13892 PMIC. Add RTC support.
Tested via 'date' command that reads the PMIC RTC registers:
MX51EVK U-Boot > date
Date: 1970-01-01 (Thursday) Time: 0:40:35
Signed-off-by Fabio Estevam <[email protected]>
---

Applied to u-boot-imx, thanks

Best regards,
Stefano Babic

Signature · 5 lines

=====================================================================
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-0 Fax: +49-8142-66989-80  Email: office at denx.de
=====================================================================

Stefano Babic

2011-10-25 09:23 UTC #3 lore raw

PATCH v2 1/2 rtc: Make mc13783-rtc driver generic

In reply to Fabio Estevam

Quoted 8 lines · Fabio Estevam

Rename mc13783-rtc so that it can be used for both MC13783 and MC13892 PMICs.
efikamx board, for example, does use a MC13892 PMIC, but the RTC selection is currently made as:
#define CONFIG_RTC_MC13783
,which is not very obvious.

Quoted 8 lines

Let the MC13783 and MC13892 RTC be selected by:
#define CONFIG_RTC_MC13XXX
Signed-off-by Fabio Estevam <[email protected]>
---
Changes since v1:
- Properly handle the file rename via git.

Ah, ok, I have not seen your V2 - forget my previous comment.

This is only a cosmetic change - I do not see any issue.

Acked-by Stefano Babic <[email protected]>

Best regards,
Stefano Babic

Signature · 5 lines

=====================================================================
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-0 Fax: +49-8142-66989-80  Email: office at denx.de
=====================================================================

Stefano Babic

2011-10-25 09:28 UTC #4 lore raw

PATCH v2 1/2 rtc: Make mc13783-rtc driver generic

In reply to Fabio Estevam

Quoted 6 lines · Fabio Estevam

Rename mc13783-rtc so that it can be used for both MC13783 and MC13892 PMICs.
efikamx board, for example, does use a MC13892 PMIC, but the RTC selection is currently made as:
#define CONFIG_RTC_MC13783

Quoted 8 lines

,which is not very obvious.
Let the MC13783 and MC13892 RTC be selected by:
#define CONFIG_RTC_MC13XXX
Signed-off-by Fabio Estevam <[email protected]>
---

Applied to u-boot-imx, thanks.

Best regards,
Stefano Babic

Signature · 5 lines

=====================================================================
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-0 Fax: +49-8142-66989-80  Email: office at denx.de
=====================================================================