Skip to contentSkip to conversation

fs/Makefile: Always inspect exofs/

PATCH In review Boaz Harrosh 3 participants 3 messages Oct 25, 2011 – Oct 27, 2011 2 messages not in the archive

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 fs/Makefile: Always inspect exofs/

fs/exofs directory has multiple targets now, of which the ore.ko will be needed by the pnfs-objects-layout-driver (fs/nfs/objlayout).

As suggested by: Michal Marek <[email protected]> convert inclusion of exofs/ from obj-$(CONFIG_EXOFS_FS) => obj-$(y). So ORE can be selected also from fs/nfs/Kconfig

---
 fs/Makefile |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
fs/Makefile +1 -1
index afc1096..5c30a13 100644
@@ -120,6 +120,6 @@ obj-$(CONFIG_DEBUG_FS)		+= debugfs/
 obj-$(CONFIG_OCFS2_FS)		+= ocfs2/
 obj-$(CONFIG_BTRFS_FS)		+= btrfs/
 obj-$(CONFIG_GFS2_FS)           += gfs2/
-obj-$(CONFIG_EXOFS_FS)          += exofs/
+obj-$(y)          		+= exofs/ # Multiple mods, used by nfs/objlayout
 obj-$(CONFIG_CEPH_FS)		+= ceph/
 obj-$(CONFIG_PSTORE)		+= pstore/
Signature · 1 line
1.7.6.4

A message that is not in the archive (sent off-list or not yet received): [email protected]

#2 lore raw
Quoted 7 lines · Boaz Harrosh

fs/exofs directory has multiple targets now, of which the ore.ko will be needed by the pnfs-objects-layout-driver (fs/nfs/objlayout).

As suggested by: Michal Marek <[email protected]> convert inclusion of exofs/ from obj-$(CONFIG_EXOFS_FS) => obj-$(y).

I suggested obj-y verbatim, at least this is what I meant. obj-$(y) expands to "obj-" and will do nothing.

Michal
--
To unsubscribe from this list: send the line "unsubscribe linux-nfs" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html

A message that is not in the archive (sent off-list or not yet received): [email protected]

#4 lore raw
Quoted 6 lines · Michal Marek
Quoted 5 lines · Boaz Harrosh

fs/exofs directory has multiple targets now, of which the ore.ko will be needed by the pnfs-objects-layout-driver (fs/nfs/objlayout).

Quoted 7 lines
Quoted 2 lines

As suggested by: Michal Marek <[email protected]> convert inclusion of exofs/ from obj-$(CONFIG_EXOFS_FS) => obj-$(y).

I suggested obj-y verbatim, at least this is what I meant. obj-$(y) expands to "obj-" and will do nothing.

Michal

Thanks Michal.

Yes that was a stupid, stupid TYPO bug I did and I'm so embarrassed I already sent a fix to Linus, he pulled it.

Dear, you have eyes of an hawk, how did you see it? I stared at it for 15 minutes and did not get it.

Boaz
--
To unsubscribe from this list: send the line "unsubscribe linux-nfs" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html