Skip to contentSkip to conversation

pm9261: add mach-type localy for the board

PATCH New Asen Chavdarov Dimov 3 participants 4 messages Oct 28, 2011 – Oct 31, 2011

lore
Share & tools
lore

Asen Chavdarov Dimov

author
#0 lore raw

PATCH 1/1 pm9261: add mach-type localy for the board

Signed-off-by Asen Chavdarov Dimov <[email protected]>
---
 board/ronetix/pm9261/mach-type.h |   31 +++++++++++++++++++++++++++++++
 board/ronetix/pm9261/pm9261.c    |    1 +
 2 files changed, 32 insertions(+), 0 deletions(-)
 create mode 100644 board/ronetix/pm9261/mach-type.h
board/ronetix/pm9261/mach-type.h new file +31 -0
new file mode 100644
index 0000000..ca07c18
@@ -0,0 +1,31 @@
+/*
+ * This was manually generated from arch/arm/include/asm/mach-types.h
+ * and add this machine ID removed with commit
+ * 47af6f61bcd9fdd5dcf389cff0a7406eba756c6.
+ * Do fix this.
+ */
+
+#ifndef __ASM_ARM_MACH_TYPE_PM9261_H
+#define __ASM_ARM_MACH_TYPE_PM9261_H
+
+#ifndef __ASSEMBLY__
+/* The type of machine we're running on */
+extern unsigned int __machine_arch_type;
+#endif
+
+/* see arch/arm/kernel/arch.c for a description of these */
+#define MACH_TYPE_PM9261              1187
+
+#ifdef CONFIG_MACH_PM9261
+# ifdef machine_arch_type
+#  undef machine_arch_type
+#  define machine_arch_type	__machine_arch_type
+# else
+#  define machine_arch_type	MACH_TYPE_PM9261
+# endif
+# define machine_is_pm9261()	(machine_arch_type == MACH_TYPE_PM9261)
+#else
+# define machine_is_pm9261()	(0)
+#endif
+
+#endif
board/ronetix/pm9261/pm9261.c +1 -0
index 871b94a..e394a93 100644
@@ -25,6 +25,7 @@
  */
 
 #include <common.h>
+#include "mach-type.h"
 #include <asm/sizes.h>
 #include <asm/io.h>
 #include <asm/arch/at91sam9_smc.h>
Signature · 1 line
1.7.4.4
NAK
#1 lore raw

PATCH 1/1 pm9261: add mach-type localy for the board

Hi Asen,

You should copy Ilko as the maintainer, unless you are taking over maintainership of this board (and pm9263 and pm9g45), in which case please modify MAINTAINERS file as well.

Le 28/10/2011 18:10, Asen Chavdarov Dimov a ?crit :

Quoted 3 lines
Signed-off-by Asen Chavdarov Dimov<[email protected]>
---
  board/ronetix/pm9261/mach-type.h |   31 +++++++++++++++++++++++++++++++

NAK. Do not copy-paste mach-type.h, just add the MACH_TYPE_PM9261 define in include/configs/pm9261.h.

Quoted 46 lines
  board/ronetix/pm9261/pm9261.c    |    1 +
  2 files changed, 32 insertions(+), 0 deletions(-)

create mode 100644 board/ronetix/pm9261/mach-type.h

board/ronetix/pm9261/mach-type.h new file +31 -0
new file mode 100644
index 0000000..ca07c18
@@ -0,0 +1,31 @@
+/*
+ * This was manually generated from arch/arm/include/asm/mach-types.h
+ * and add this machine ID removed with commit
+ * 47af6f61bcd9fdd5dcf389cff0a7406eba756c6.
+ * Do fix this.
+ */
+
+#ifndef __ASM_ARM_MACH_TYPE_PM9261_H
+#define __ASM_ARM_MACH_TYPE_PM9261_H
+
+#ifndef __ASSEMBLY__
+/* The type of machine we're running on */
+extern unsigned int __machine_arch_type;
+#endif
+
+/* see arch/arm/kernel/arch.c for a description of these */
+#define MACH_TYPE_PM9261              1187
+
+#ifdef CONFIG_MACH_PM9261
+# ifdef machine_arch_type
+#  undef machine_arch_type
+#  define machine_arch_type	__machine_arch_type
+# else
+#  define machine_arch_type	MACH_TYPE_PM9261
+# endif
+# define machine_is_pm9261()	(machine_arch_type == MACH_TYPE_PM9261)
+#else
+# define machine_is_pm9261()	(0)
+#endif
+
+#endif
board/ronetix/pm9261/pm9261.c +0 -0
index 871b94a..e394a93 100644

board/ronetix/pm9261/pm9261.c line 28

Quoted 4 lines
board/ronetix/pm9261/pm9261.c +1 -0
@@ -25,6 +25,7 @@
   */
 
  #include<common.h>
+#include "mach-type.h"

NAK -- you don't need this if you add MACH_TYPE_PM9261.

board/ronetix/pm9261/pm9261.c line 31

Quoted 3 lines
board/ronetix/pm9261/pm9261.c +0 -0
  #include<asm/sizes.h>
  #include<asm/io.h>
  #include<asm/arch/at91sam9_smc.h>

Same applies to the other two boards -- you can actually submit a single patch for all three of them.

Amicalement,

Signature · 1 line
Albert.
#2 lore raw

PATCH 1/1 pm9261: add mach-type localy for the board

Hi Asen,

Quoted 6 lines · Albert ARIBAUD

Hi Asen,

You should copy Ilko as the maintainer, unless you are taking over maintainership of this board (and pm9263 and pm9g45), in which case please modify MAINTAINERS file as well.

Quoted 7 lines

Le 28/10/2011 18:10, Asen Chavdarov Dimov a ?crit :

Quoted 3 lines
Signed-off-by Asen Chavdarov Dimov<[email protected]>
---
  board/ronetix/pm9261/mach-type.h |   31 +++++++++++++++++++++++++++++++

NAK. Do not copy-paste mach-type.h, just add the MACH_TYPE_PM9261 define in include/configs/pm9261.h.

Also, consider using CONFIG_MACH_TYPE (see README).

Quoted 62 lines
Quoted 47 lines
  board/ronetix/pm9261/pm9261.c    |    1 +
  2 files changed, 32 insertions(+), 0 deletions(-)

create mode 100644 board/ronetix/pm9261/mach-type.h

board/ronetix/pm9261/mach-type.h new file +31 -0
new file mode 100644
index 0000000..ca07c18
@@ -0,0 +1,31 @@
+/*
+ * This was manually generated from arch/arm/include/asm/mach-types.h
+ * and add this machine ID removed with commit
+ * 47af6f61bcd9fdd5dcf389cff0a7406eba756c6.
+ * Do fix this.
+ */
+
+#ifndef __ASM_ARM_MACH_TYPE_PM9261_H
+#define __ASM_ARM_MACH_TYPE_PM9261_H
+
+#ifndef __ASSEMBLY__
+/* The type of machine we're running on */
+extern unsigned int __machine_arch_type;
+#endif
+
+/* see arch/arm/kernel/arch.c for a description of these */
+#define MACH_TYPE_PM9261              1187
+
+#ifdef CONFIG_MACH_PM9261
+# ifdef machine_arch_type
+#  undef machine_arch_type
+#  define machine_arch_type	__machine_arch_type
+# else
+#  define machine_arch_type	MACH_TYPE_PM9261
+# endif
+# define machine_is_pm9261()	(machine_arch_type == MACH_TYPE_PM9261)
+#else
+# define machine_is_pm9261()	(0)
+#endif
+
+#endif
board/ronetix/pm9261/pm9261.c +0 -0
index 871b94a..e394a93 100644

board/ronetix/pm9261/pm9261.c line 28

Quoted 4 lines
board/ronetix/pm9261/pm9261.c +1 -0
@@ -25,6 +25,7 @@
   */
 
  #include<common.h>
+#include "mach-type.h"

NAK -- you don't need this if you add MACH_TYPE_PM9261.

board/ronetix/pm9261/pm9261.c line 31

Quoted 3 lines
board/ronetix/pm9261/pm9261.c +0 -0
  #include<asm/sizes.h>
  #include<asm/io.h>
  #include<asm/arch/at91sam9_smc.h>

Same applies to the other two boards -- you can actually submit a single patch for all three of them.

Amicalement,

Signature · 2 lines
Regards,
Igor.
author
#3 lore raw

PATCH 1/1 pm9261: add mach-type localy for the board

In reply to Albert ARIBAUD

Hi Albert,

Quoted 5 lines · Albert ARIBAUD

Hi Asen,

You should copy Ilko as the maintainer, unless you are taking over maintainership of this board (and pm9263 and pm9g45), in which case please modify MAINTAINERS file as well.

Ok, I will CC: him next time.

Quoted 13 lines

Le 28/10/2011 18:10, Asen Chavdarov Dimov a ?crit :

Quoted 4 lines
Signed-off-by Asen Chavdarov Dimov<[email protected]>
---
  board/ronetix/pm9261/mach-type.h |   31

+++++++++++++++++++++++++++++++

NAK. Do not copy-paste mach-type.h, just add the MACH_TYPE_PM9261 define in include/configs/pm9261.h.

Quoted 3 lines
  board/ronetix/pm9261/pm9261.c    |    1 +
  2 files changed, 32 insertions(+), 0 deletions(-)

create mode 100644 board/ronetix/pm9261/mach-type.h

...

Quoted 12 lines
Quoted 2 lines

#include<common.h>
+#include "mach-type.h"

NAK -- you don't need this if you add MACH_TYPE_PM9261.

Quoted 3 lines
  #include<asm/sizes.h>
  #include<asm/io.h>
  #include<asm/arch/at91sam9_smc.h>

Same applies to the other two boards -- you can actually submit a single patch for all three of them.

Ok.

Quoted 1 line

Amicalement,

Regards,
Asen