Skip to contentSkip to conversation

ARM: define CONFIG_MACH_TYPE for all keymile boards

PATCH New Valentin Longchamp 4 participants 5 messages Oct 31, 2011 – Nov 1, 2011

lore
Share & tools
lore

Valentin Longchamp

author
#0 lore raw

PATCH 1/1 ARM: define CONFIG_MACH_TYPE for all keymile boards

As this is a mandatory CONFIG for ARM boards now.

Signed-off-by Valentin Longchamp <[email protected]>
Signed-off-by Holger Brunck <[email protected]>
---
 include/configs/km/km_arm.h |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)
include/configs/km/km_arm.h +2 -0
index eaf6017..f30088d 100644
@@ -48,6 +48,8 @@
 #define CONFIG_KW88F6281		/* SOC Name */
 #define CONFIG_MACH_KM_KIRKWOOD		/* Machine type */
 
+#define CONFIG_MACH_TYPE	MACH_TYPE_KM_KIRKWOOD
+
 /* include common defines/options for all Keymile boards */
 #include "keymile-common.h"
Signature · 1 line
1.7.1
#1 lore raw

PATCH 1/1 ARM: define CONFIG_MACH_TYPE for all keymile boards

Hi Valentin,

Quoted 13 lines · Valentin Longchamp

As this is a mandatory CONFIG for ARM boards now.

Signed-off-by Valentin Longchamp <[email protected]>
Signed-off-by Holger Brunck <[email protected]>
---
 include/configs/km/km_arm.h |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)
include/configs/km/km_arm.h +0 -0
index eaf6017..f30088d 100644

include/configs/km/km_arm.h line 52

Quoted 5 lines
include/configs/km/km_arm.h +2 -0
@@ -48,6 +48,8 @@
 #define CONFIG_KW88F6281		/* SOC Name */
 #define CONFIG_MACH_KM_KIRKWOOD		/* Machine type */
 
+#define CONFIG_MACH_TYPE	MACH_TYPE_KM_KIRKWOOD
+

Probably, you also want to remove the gd->bd->bi_arch_number assignment from board files using this mach id?

Signature · 2 lines
Regards,
Igor.
#2 lore raw

PATCH 1/1 ARM: define CONFIG_MACH_TYPE for all keymile boards

Quoted 32 lines

-----Original Message-----
From: u-boot-bounces at lists.denx.de [mailto:u-boot- bounces at lists.denx.de] On Behalf Of Igor Grinberg
Sent: Monday, October 31, 2011 4:18 PM
To: Valentin Longchamp
Cc: u-boot at lists.denx.de; Holger Brunck
Subject: Re: [U-Boot] [PATCH] ARM: define CONFIG_MACH_TYPE for all keymile boards

Hi Valentin,

Quoted 3 lines · Valentin Longchamp

As this is a mandatory CONFIG for ARM boards now.

Signed-off-by Valentin Longchamp

<[email protected]>

Review

Quoted 6 lines
Signed-off-by Holger Brunck <[email protected]>
---
 include/configs/km/km_arm.h |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)
(quoted diff) +0 -0

b/include/configs/km/km_arm.h

Quoted 7 lines

index eaf6017..f30088d 100644

include/configs/km/km_arm.h +0 -0
@@ -48,6 +48,8 @@
 #define CONFIG_KW88F6281		/* SOC Name */
 #define CONFIG_MACH_KM_KIRKWOOD		/* Machine type */
Quoted 5 lines

include/configs/km/km_arm.h line 52

Quoted 2 lines
include/configs/km/km_arm.h +2 -0
+#define CONFIG_MACH_TYPE	MACH_TYPE_KM_KIRKWOOD
+

Probably, you also want to remove the gd->bd->bi_arch_number assignment from board files using this mach id?

Hi Valentin

Please post one patch for all this
(including above, MACH_TYPE_KM_KIRKDOOD definition and CONFIG_MACH_TYPE definition)

Regards...
Prafulla . . .

#3 lore raw

PATCH 1/1 ARM: define CONFIG_MACH_TYPE for all keymile boards

In reply to Igor Grinberg
Quoted 5 lines · On Monday 31 October 2011 06:48:06 Igor Grinberg wrote:
Quoted 4 lines · Valentin Longchamp
include/configs/km/km_arm.h +0 -0
@@ -48,6 +48,8 @@
Quoted 8 lines

include/configs/km/km_arm.h line 52

Quoted 5 lines
include/configs/km/km_arm.h +2 -0
 #define CONFIG_KW88F6281		/* SOC Name */
 #define CONFIG_MACH_KM_KIRKWOOD		/* Machine type */
 
+#define CONFIG_MACH_TYPE	MACH_TYPE_KM_KIRKWOOD
+

Probably, you also want to remove the gd->bd->bi_arch_number assignment from board files using this mach id?

if possible, i'd like to punt bi_arch_number from everyone ...
-mike
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: This is a digitally signed message part.
Url : http://lists.denx.de/pipermail/u-boot/attachments/20111031/6bc9bf6c/attachment.pgp

#4 lore raw

PATCH 1/1 ARM: define CONFIG_MACH_TYPE for all keymile boards

Quoted 9 lines · Mike Frysinger
Quoted 8 lines · On Monday 31 October 2011 06:48:06 Igor Grinberg wrote:
Quoted 7 lines · Valentin Longchamp
include/configs/km/km_arm.h +0 -0
@@ -48,6 +48,8 @@
 
 #define CONFIG_KW88F6281		/* SOC Name */
 #define CONFIG_MACH_KM_KIRKWOOD		/* Machine type */
Quoted 7 lines
Quoted 5 lines

include/configs/km/km_arm.h line 52

Quoted 2 lines
include/configs/km/km_arm.h +2 -0
+#define CONFIG_MACH_TYPE	MACH_TYPE_KM_KIRKWOOD
+

Probably, you also want to remove the gd->bd->bi_arch_number assignment from board files using this mach id?

if possible, i'd like to punt bi_arch_number from everyone ...

Apart from those who have the mach id runtime discoverable, it would be great idea, but we cannot request this from someone who fixes his/her boards.

Patches are welcome ;)

Signature · 2 lines
Regards,
Igor.