Skip to contentSkip to conversation

Staging: iio/dac/ad5360.c: signedness bug in

PATCH In review Dan Carpenter 3 participants 3 messages Oct 29, 2011 – Oct 31, 2011

Subsystems (5)
Staging Kernel janitors IIO Analog Devices IIO drivers +1 more subsystems
lore
Share & tools
lore

Dan Carpenter

author
#0 lore raw

PATCH 1/1 Staging: iio/dac/ad5360.c: signedness bug in

ad5360_get_channel_vref() returns an int and scale_uv should be the same. Making it unsigned here breaks the error handling.

Signed-off-by Dan Carpenter <[email protected]>
drivers/staging/iio/dac/ad5360.c +1 -1
index 72d0f3f..cfeea72 100644
@@ -371,8 +371,8 @@ static int ad5360_read_raw(struct iio_dev *indio_dev,
 			   long m)
 {
 	struct ad5360_state *st = iio_priv(indio_dev);
-	unsigned long scale_uv;
 	unsigned int ofs_index;
+	int scale_uv;
 	int ret;
 
 	switch (m) {
Acked-by on v1 1/1
#1 lore raw

Re: [patch] Staging: iio/dac/ad5360.c: signedness bug in ad5360_read_raw()

Quoted 5 lines · Dan Carpenter

ad5360_get_channel_vref() returns an int and scale_uv should be the same. Making it unsigned here breaks the error handling.

Signed-off-by Dan Carpenter <[email protected]>
Acked-by Lars-Peter Clausen <[email protected]>

Thanks.

Quoted 14 lines
drivers/staging/iio/dac/ad5360.c +1 -1
index 72d0f3f..cfeea72 100644
@@ -371,8 +371,8 @@ static int ad5360_read_raw(struct iio_dev *indio_dev,
 			   long m)
 {
 	struct ad5360_state *st = iio_priv(indio_dev);
-	unsigned long scale_uv;
 	unsigned int ofs_index;
+	int scale_uv;
 	int ret;
 
 	switch (m) {
Acked-by
#2 lore raw

Re: [patch] Staging: iio/dac/ad5360.c: signedness bug in ad5360_read_raw()

Quoted 8 lines · Lars-Peter Clausen
Quoted 5 lines · Dan Carpenter

ad5360_get_channel_vref() returns an int and scale_uv should be the same. Making it unsigned here breaks the error handling.

Signed-off-by Dan Carpenter <[email protected]>
Acked-by Lars-Peter Clausen <[email protected]>
Acked-by Jonathan Cameron <jic23cam.ac.uk>
Quoted 19 lines

Thanks.

Quoted 14 lines
drivers/staging/iio/dac/ad5360.c +1 -1
index 72d0f3f..cfeea72 100644
@@ -371,8 +371,8 @@ static int ad5360_read_raw(struct iio_dev *indio_dev,
 			   long m)
 {
 	struct ad5360_state *st = iio_priv(indio_dev);
-	unsigned long scale_uv;
 	unsigned int ofs_index;
+	int scale_uv;
 	int ret;
 
 	switch (m) {