distclean: Remove generated .dtb files
PATCH 1/1 distclean: Remove generated .dtb files
The patch 'arm/dt: Add dtb make rule' adds support to create a .dtb file. But this is never removed afterwards. Remove the generated .dtb file if 'distclean' is called.
--- arch/arm/boot/Makefile | 2 ++ 1 files changed, 2 insertions(+), 0 deletions(-)
arch/arm/boot/Makefile +2 -0
@@ -71,6 +71,8 @@ $(obj)/%.dtb: $(src)/dts/%.dts $(obj)/dtbs: $(addprefix $(obj)/, $(dtb-y)) +clean-files := *.dtb + quiet_cmd_uimage = UIMAGE $@ cmd_uimage = $(CONFIG_SHELL) $(MKIMAGE) -A arm -O linux -T kernel \ -C none -a $(LOADADDR) -e $(STARTADDR) \
Signature · 1 line
1.7.0.4
PATCH 1/1 distclean: Remove generated .dtb files
Quoted 9 lines · Dirk Behme
The patch 'arm/dt: Add dtb make rule' adds support to create a .dtb file. But this is never removed afterwards. Remove the generated .dtb file if 'distclean' is called.
Signed-off-by Dirk Behme <[email protected]>CC Rob Herring <[email protected]>CC Shawn Guo <[email protected]>CC Jason Liu <[email protected]>CC Grant Likely <[email protected]>
Quoted 20 lines
--- arch/arm/boot/Makefile | 2 ++ 1 files changed, 2 insertions(+), 0 deletions(-)arch/arm/boot/Makefile +2
-0@@ -71,6 +71,8 @@ $(obj)/%.dtb: $(src)/dts/%.dts $(obj)/dtbs: $(addprefix $(obj)/, $(dtb-y)) +clean-files := *.dtb + quiet_cmd_uimage = UIMAGE $@ cmd_uimage = $(CONFIG_SHELL) $(MKIMAGE) -A arm -O linux -T kernel \ -C none -a $(LOADADDR) -e $(STARTADDR) \Signature · 1 line
1.7.0.4
PATCH 1/1 distclean: Remove generated .dtb files
Quoted 5 lines · Grant Likely
Quoted 4 lines · Dirk Behme
The patch 'arm/dt: Add dtb make rule' adds support to create a .dtb file. But this is never removed afterwards. Remove the generated .dtb file if 'distclean' is called.
Quoted 7 lines
Quoted 5 lines
Signed-off-by Dirk Behme <[email protected]>CC Rob Herring <[email protected]>CC Shawn Guo <[email protected]>CC Jason Liu <[email protected]>CC Grant Likely <[email protected]>Acked-by Grant Likely <[email protected]>
... although why are only the .dtb files needed in the clean list? How are the other built files cleaned? 'make clean' does remove the other images, but I don't know what the mechanism is.
g.
Quoted 22 lines
Quoted 21 lines
---
?arch/arm/boot/Makefile | ? ?2 ++
?1 files changed, 2 insertions(+), 0 deletions(-)arch/arm/boot/Makefile +2
-0@@ -71,6 +71,8 @@ $(obj)/%.dtb: $(src)/dts/%.dts ?$(obj)/dtbs: $(addprefix $(obj)/, $(dtb-y)) +clean-files := *.dtb +?quiet_cmd_uimage = UIMAGE ?$@
? ? ? ?cmd_uimage = $(CONFIG_SHELL) $(MKIMAGE) -A arm -O linux -T kernel \
? ? ? ? ? ? ? ? ?-C none -a $(LOADADDR) -e $(STARTADDR) \
--
1.7.0.4
Signature · 2 lines
Grant Likely, B.Sc., P.Eng. Secret Lab Technologies Ltd.
PATCH 1/1 distclean: Remove generated .dtb files
Quoted 12 lines · Grant Likely
Quoted 11 lines · Grant Likely
Quoted 9 lines · Dirk Behme
The patch 'arm/dt: Add dtb make rule' adds support to create a .dtb file. But this is never removed afterwards. Remove the generated .dtb file if 'distclean' is called.
Signed-off-by Dirk Behme<[email protected]>CC Rob Herring<[email protected]>CC Shawn Guo<[email protected]>CC Jason Liu<[email protected]>CC Grant Likely<[email protected]>
Quoted 5 lines
Quoted 1 line
Acked-by Grant Likely<[email protected]>... although why are only the .dtb files needed in the clean list? How are the other built files cleaned? 'make clean' does remove the other images, but I don't know what the mechanism is.
A lot of stuff is removed by the top level Makefile [1]. But as the patch "arm/dt: Add dtb make rule" adds the .dtb generation to arch/arm/boot/Makefile, we thought it would be a good place to add the removal of that file there, too.
Hmm, not sure if this answers your question, though ;)
Best regards
Dirk
Quoted 25 lines
Quoted 22 lines
Quoted 21 lines
--- arch/arm/boot/Makefile | 2 ++ 1 files changed, 2 insertions(+), 0 deletions(-)arch/arm/boot/Makefile +2
-1@@ -71,6 +71,8 @@ $(obj)/%.dtb: $(src)/dts/%.dts $(obj)/dtbs: $(addprefix $(obj)/, $(dtb-y)) +clean-files := *.dtb + quiet_cmd_uimage = UIMAGE $@ cmd_uimage = $(CONFIG_SHELL) $(MKIMAGE) -A arm -O linux -T kernel \ -C none -a $(LOADADDR) -e $(STARTADDR) \ --1.7.0.4
A message that is not in the archive (sent off-list or not yet received): 4EB779CF.4040007-gM/[email protected]
Quoted 4 lines · Dirk Behme
Quoted 2 lines · Grant Likely
On Sun, Nov 6, 2011 at 11:38 AM, Grant Likely<grant.likely-s3s/[email protected]>
Quoted 17 lines · wrote:
Quoted 17 lines
Quoted 15 lines · Dirk Behme
Quoted 10 lines
The patch 'arm/dt: Add dtb make rule' adds support to create a .dtb file. But this is never removed afterwards. Remove the generated .dtb file if 'distclean' is called.
CC Rob Herring<rob.herring-bsGFqQB8/[email protected]>CC Shawn Guo<[email protected]>CC Jason Liu<[email protected]>CC Grant Likely<grant.likely-s3s/[email protected]>
Quoted 6 lines
Quoted 3 lines
... although why are only the .dtb files needed in the clean list? How are the other built files cleaned? 'make clean' does remove the other images, but I don't know what the mechanism is.
A lot of stuff is removed by the top level
Makefile[1]. But as the patch
"arm/dt: Add dtb make rule" adds the .dtb generation to arch/arm/boot/Makefile, we thought it would be a good place to add the removal of that file there, too.
Quoted 2 lines
Hmm, not sure if this answers your question, though ;)
Okay. Good enough for me.
g.
_______________________________________________
devicetree-discuss mailing list devicetree-discuss-uLR06cmDAlY/[email protected]
https://lists.ozlabs.org/listinfo/devicetree-discuss
PATCH 1/1 distclean: Remove generated .dtb files
In reply to Dirk BehmeQuoted 10 lines · Dirk Behme
The patch 'arm/dt: Add dtb make rule' adds support to create a .dtb file. But this is never removed afterwards. Remove the generated .dtb file if 'distclean' is called.
Signed-off-by Dirk Behme <[email protected]>CC Rob Herring <[email protected]>CC Shawn Guo <[email protected]>CC Jason Liu <[email protected]>CC Grant Likely <[email protected]>---
Quoted 16 lines
arch/arm/boot/Makefile | 2 ++ 1 files changed, 2 insertions(+), 0 deletions(-)arch/arm/boot/Makefile +2
-0@@ -71,6 +71,8 @@ $(obj)/%.dtb: $(src)/dts/%.dts $(obj)/dtbs: $(addprefix $(obj)/, $(dtb-y)) +clean-files := *.dtb + quiet_cmd_uimage = UIMAGE $@ cmd_uimage = $(CONFIG_SHELL) $(MKIMAGE) -A arm -O linux -T kernel \ -C none -a $(LOADADDR) -e $(STARTADDR) \
PATCH 1/1 distclean: Remove generated .dtb files
Quoted 13 lines · Rob Herring
Quoted 10 lines · Dirk Behme
The patch 'arm/dt: Add dtb make rule' adds support to create a .dtb file. But this is never removed afterwards. Remove the generated .dtb file if 'distclean' is called.
Signed-off-by Dirk Behme<[email protected]>CC Rob Herring<[email protected]>CC Shawn Guo<[email protected]>CC Jason Liu<[email protected]>CC Grant Likely<[email protected]>---
Acked-by Rob Herring<[email protected]>
...
Quoted 1 line
Acked-by Grant Likely <[email protected]>
Submitted to Russell King's Patch Tracking System:
http://www.arm.linux.org.uk/developer/patches/viewpatch.php?id=7152/1
Thanks
Dirk
Quoted 18 lines
Quoted 16 lines
arch/arm/boot/Makefile | 2 ++ 1 files changed, 2 insertions(+), 0 deletions(-)arch/arm/boot/Makefile +2
-0@@ -71,6 +71,8 @@ $(obj)/%.dtb: $(src)/dts/%.dts $(obj)/dtbs: $(addprefix $(obj)/, $(dtb-y)) +clean-files := *.dtb + quiet_cmd_uimage = UIMAGE $@ cmd_uimage = $(CONFIG_SHELL) $(MKIMAGE) -A arm -O linux -T kernel \ -C none -a $(LOADADDR) -e $(STARTADDR) \