recvmsg01: kill child only if one was forked

If start_server() fails, then pid will end up with -1 and cleanup() will do kill(-1, SIGKILL), which kills everything this process can kill.

Change the test to kill pid (child) only when it successfully creates one.

Signed-off-by Jan Stancek <[email protected]>

---
  testcases/kernel/syscalls/recvmsg/recvmsg01.c |    5 +++--
  1 files changed, 3 insertions(+), 2 deletions(-)

From: "Wanlong Gao" <[email protected]>
To: "Jan Stancek" <[email protected]>
Cc: [email protected]
Sent: Tuesday, November 8, 2011 4:07:56 AM
Subject: Re: [LTP] [PATCH] recvmsg01: kill child only if one was forked

Quoted 8 lines · Jan Stancek

If start_server() fails, then pid will end up with -1 and cleanup() will do kill(-1, SIGKILL), which kills everything this process can kill.

Change the test to kill pid (child) only when it successfully creates one.

Yeah, but this can't fix the problem in this case?

recvmsg01 1 TBROK : server bind failed: errno=???(98): Address
already in use
recvmsg01 2 TBROK : Remaining cases broken

Thanks
-Wanlong Gao

Quoted 6 lines

Signed-off-by Jan Stancek <[email protected]>

---
  testcases/kernel/syscalls/recvmsg/recvmsg01.c |    5 +++--
  1 files changed, 3 insertions(+), 2 deletions(-)

----- Original Message -----

Quoted 20 lines

From: "Wanlong Gao" <[email protected]>
To: "Jan Stancek" <[email protected]>
Cc: [email protected]
Sent: Tuesday, November 8, 2011 4:07:56 AM
Subject: Re: [LTP] [PATCH] recvmsg01: kill child only if one was forked

Quoted 8 lines · Jan Stancek

If start_server() fails, then pid will end up with -1 and cleanup() will do kill(-1, SIGKILL), which kills everything this process can kill.

Change the test to kill pid (child) only when it successfully creates one.

Yeah, but this can't fix the problem in this case?

Quoted 4 lines

recvmsg01 1 TBROK : server bind failed: errno=???(98): Address
already in use
recvmsg01 2 TBROK : Remaining cases broken

I'm not sure I follow you here.
In case you described start_server() returns -1, so pid = -1, and cleanup won't do kill(-1, SIGKILL).

From: "Wanlong Gao" <[email protected]>
To: "Jan Stancek" <[email protected]>
Cc: [email protected]
Sent: Tuesday, November 8, 2011 8:21:01 AM
Subject: Re: [LTP] [PATCH] recvmsg01: kill child only if one was forked

Quoted 30 lines · Jan Stancek

----- Original Message -----

Quoted 19 lines

From: "Wanlong Gao" <[email protected]>
To: "Jan Stancek" <[email protected]>
Cc: [email protected]
Sent: Tuesday, November 8, 2011 4:07:56 AM
Subject: Re: [LTP] [PATCH] recvmsg01: kill child only if one was forked

Quoted 8 lines · Jan Stancek

If start_server() fails, then pid will end up with -1 and cleanup() will do kill(-1, SIGKILL), which kills everything this process can kill.

Change the test to kill pid (child) only when it successfully creates one.

Quoted 7 lines

Yeah, but this can't fix the problem in this case?

recvmsg01 1 TBROK : server bind failed: errno=???(98):
Address
already in use
recvmsg01 2 TBROK : Remaining cases broken

Quoted 4 lines

I'm not sure I follow you here.
In case you described start_server() returns -1, so pid = -1, and cleanup won't do kill(-1, SIGKILL).

Yeah, I understood you.

But we wanna fix the case to TPASS but not TBROK, do we?

So, I mean that the issues of this case is not only what you said.

----- Original Message -----

Quoted 44 lines

From: "Wanlong Gao" <[email protected]>
To: "Jan Stancek" <[email protected]>
Cc: [email protected]
Sent: Tuesday, November 8, 2011 8:21:01 AM
Subject: Re: [LTP] [PATCH] recvmsg01: kill child only if one was forked

Quoted 30 lines · Jan Stancek

----- Original Message -----

Quoted 19 lines

From: "Wanlong Gao" <[email protected]>
To: "Jan Stancek" <[email protected]>
Cc: [email protected]
Sent: Tuesday, November 8, 2011 4:07:56 AM
Subject: Re: [LTP] [PATCH] recvmsg01: kill child only if one was forked

Quoted 8 lines · Jan Stancek

If start_server() fails, then pid will end up with -1 and cleanup() will do kill(-1, SIGKILL), which kills everything this process can kill.

Change the test to kill pid (child) only when it successfully creates one.

Quoted 7 lines

Yeah, but this can't fix the problem in this case?

recvmsg01 1 TBROK : server bind failed: errno=???(98):
Address
already in use
recvmsg01 2 TBROK : Remaining cases broken

Quoted 4 lines

I'm not sure I follow you here.
In case you described start_server() returns -1, so pid = -1, and cleanup won't do kill(-1, SIGKILL).

Quoted 3 lines

Yeah, I understood you.

But we wanna fix the case to TPASS but not TBROK, do we?

True, but until we have such fix, we should at least make it less annoying when it fails.

Quoted 1 line

So, I mean that the issues of this case is not only what you said.

I didn't actually get to see yet what those are, because those TBROK messages didn't make it to log:

<<<test_start>>>
tag=recvmsg01 stime=1320555319
cmdline="recvmsg01"
contacts=""
analysis=exit
<<<test_output>>>
<<<execution_status>>>
initiation_status="ok"
duration=0 termination_type=signaled termination_id=9 corefile=no cutime=0 cstime=0
<<<test_end>>>

Regards,
Jan

If start_server() fails, then pid will end up with -1 and cleanup() will do kill(-1, SIGKILL), which kills everything this process can kill.

Change the test to kill pid (child) only when it successfully creates one.