Skip to contentSkip to conversation

at91: fix compile breakage with VMALLOC_END

PATCH New Jamie Iles 2 participants 2 messages Nov 8, 2011

Subsystems (3)
lore
Share & tools
lore

Jamie Iles

author
#0 lore raw

PATCH 1/1 at91: fix compile breakage with VMALLOC_END

From: Jamie Iles <[email protected]>

VMALLOC_END is defined in terms of AT91_VIRT_BASE but this needs mach/hardware.h for it's definition.

In file included from arch/arm/mach-at91/board-usb-a926x.c:26:0:
include/linux/mm.h: In function 'is_vmalloc_addr':
include/linux/mm.h:305:41: error: 'AT91_VIRT_BASE' undeclared (first use in this function) include/linux/mm.h:305:41: note: each undeclared identifier is reported only once for each function it appears in

Cc Nicolas Ferre <[email protected]>
Cc Jean-Christophe Plagniol-Villard <[email protected]>

---

This is a bit more heavyweight than most of the other platforms, but it's the simplest fix.

 arch/arm/mach-at91/include/mach/vmalloc.h |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)
arch/arm/mach-at91/include/mach/vmalloc.h +2 -0
index 8eb459f..8e4a1bd 100644
@@ -21,6 +21,8 @@
 #ifndef __ASM_ARCH_VMALLOC_H
 #define __ASM_ARCH_VMALLOC_H
 
+#include <mach/hardware.h>
+
 #define VMALLOC_END		(AT91_VIRT_BASE & PGDIR_MASK)
 
 #endif
Signature · 1 line
1.7.4.1
#1 lore raw

PATCH 1/1 at91: fix compile breakage with VMALLOC_END

On 11/08/2011 11:28 AM, Jamie Iles :

Quoted 5 lines

From: Jamie Iles <[email protected]>

VMALLOC_END is defined in terms of AT91_VIRT_BASE but this needs mach/hardware.h for it's definition.

Quoted 8 lines

In file included from arch/arm/mach-at91/board-usb-a926x.c:26:0:
include/linux/mm.h: In function 'is_vmalloc_addr':
include/linux/mm.h:305:41: error: 'AT91_VIRT_BASE' undeclared (first use in this function) include/linux/mm.h:305:41: note: each undeclared identifier is reported only once for each function it appears in

Cc Nicolas Ferre <[email protected]>
Cc Jean-Christophe Plagniol-Villard <[email protected]>

Jean-Christophe already posted the very same patch for this. But maybe he can take your description...

Best regards,

Quoted 21 lines

---

This is a bit more heavyweight than most of the other platforms, but it's the simplest fix.

 arch/arm/mach-at91/include/mach/vmalloc.h |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)
arch/arm/mach-at91/include/mach/vmalloc.h +2 -0
index 8eb459f..8e4a1bd 100644
@@ -21,6 +21,8 @@
 #ifndef __ASM_ARCH_VMALLOC_H
 #define __ASM_ARCH_VMALLOC_H
 
+#include <mach/hardware.h>
+
 #define VMALLOC_END		(AT91_VIRT_BASE & PGDIR_MASK)
 
 #endif
Signature · 1 line
Nicolas Ferre