Skip to contentSkip to conversation

mm/memblock.c: return -ENOMEM instead of -ENXIO on failure of debugfs_create_dir in memblock_init_debugfs

PATCH Superseded Wang Sheng-Hui 2 participants 2 messages Nov 9, 2011 – Nov 22, 2011

Subsystems (2)
Memory management memblock and memory management initialization
lore
Share & tools
lore

Wang Sheng-Hui

author
#0 lore raw

PATCH 1/2 mm/memblock.c: return -ENOMEM instead of -ENXIO on failure of debugfs_create_dir in memblock_init_debugfs

On the failure of debugfs_create_dir, we should return -ENOMEM instead of -ENXIO.

The patch is against 3.1.

Signed-off-by Wang Sheng-Hui <[email protected]>
---
 mm/memblock.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
mm/memblock.c +1 -1
index ccbf973..4d4d5ee 100644
@@ -852,7 +852,7 @@ static int __init memblock_init_debugfs(void)
 {
 	struct dentry *root = debugfs_create_dir("memblock", NULL);
 	if (!root)
-		return -ENXIO;
+		return -ENOMEM;
 	debugfs_create_file("memory", S_IRUGO, root, &memblock.memory, &memblock_debug_fops);
 	debugfs_create_file("reserved", S_IRUGO, root, &memblock.reserved, &memblock_debug_fops);
Signature · 8 lines
1.7.1

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to [email protected].  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"[email protected]"> [email protected] </a>
maintainer
#1 lore raw
Quoted 16 lines · On Wed, 09 Nov 2011 10:01:26 +0800 Wang Sheng-Hui <[email protected]> wrote:

On the failure of debugfs_create_dir, we should return -ENOMEM instead of -ENXIO.

The patch is against 3.1.

Signed-off-by Wang Sheng-Hui <[email protected]>
---
 mm/memblock.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
mm/memblock.c +0 -0
index ccbf973..4d4d5ee 100644

mm/memblock.c static int __init memblock_init_debugfs(void) · line 857

Quoted 7 lines
mm/memblock.c +1 -1
@@ -852,7 +852,7 @@ static int __init memblock_init_debugfs(void)
 {
 	struct dentry *root = debugfs_create_dir("memblock", NULL);
 	if (!root)
-		return -ENXIO;
+		return -ENOMEM;
 	debugfs_create_file("memory", S_IRUGO, root, &memblock.memory, &memblock_debug_fops);
 	debugfs_create_file("reserved", S_IRUGO, root, &memblock.reserved, &memblock_debug_fops);

Well, we don't know what we should return because debugfs_create_file() is misdesigned - it should return an ERR_PTR.

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to [email protected]. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"[email protected]"> [email protected] </a>