Skip to contentSkip to conversation

spi/pl022: disable the PL022 block when unused

PATCH New Linus Walleij 2 participants 2 messages Nov 9, 2011

Subsystems (2)
SPI Arm primecell ssp PL022 SPI driver
lore
Share & tools
lore

Linus Walleij

author
#0 lore raw

PATCH 3/6 spi/pl022: disable the PL022 block when unused

From: Virupax Sadashivpetimath <[email protected]>

Make sure we clear the enable bit when the block is not used. This will save some energy in certain hardware versions.

Signed-off-by Virupax Sadashivpetimath <[email protected]>
Signed-off-by Linus Walleij <[email protected]>
---
 drivers/spi/spi-pl022.c |    5 +++++
 1 files changed, 5 insertions(+), 0 deletions(-)
drivers/spi/spi-pl022.c +5 -0
index 305f2ba..fa3eaae 100644
@@ -512,6 +512,11 @@ static void giveback(struct pl022 *pl022)
 	msg->state = NULL;
 	if (msg->complete)
 		msg->complete(msg->context);
+
+	/* disable the SPI/SSP operation */
+	writew((readw(SSP_CR1(pl022->virtbase)) &
+		(~SSP_CR1_MASK_SSE)), SSP_CR1(pl022->virtbase));
+
 	/* This message is completed, so let's turn off the clocks & power */
 	pm_runtime_put(&pl022->adev->dev);
 }
Signature · 1 line
1.7.3.2
#1 lore raw

PATCH 3/6 spi/pl022: disable the PL022 block when unused

Quoted 17 lines · Linus WALLEIJ

From: Virupax Sadashivpetimath <[email protected]>

Make sure we clear the enable bit when the block is not used. This will save some energy in certain hardware versions.

Signed-off-by Virupax Sadashivpetimath <[email protected]>
Signed-off-by Linus Walleij <[email protected]>
---
 drivers/spi/spi-pl022.c |    5 +++++
 1 files changed, 5 insertions(+), 0 deletions(-)
drivers/spi/spi-pl022.c +0 -0
index 305f2ba..fa3eaae 100644
@@ -512,6 +512,11 @@ static void giveback(struct pl022 *pl022)
 	msg->state = NULL;

drivers/spi/spi-pl022.c static void giveback(struct pl022 *pl022) · line 522

Quoted 10 lines
drivers/spi/spi-pl022.c +5 -0
 	if (msg->complete)
 		msg->complete(msg->context);
+
+	/* disable the SPI/SSP operation */
+	writew((readw(SSP_CR1(pl022->virtbase)) &
+		(~SSP_CR1_MASK_SSE)), SSP_CR1(pl022->virtbase));
+
 	/* This message is completed, so let's turn off the clocks & power */
 	pm_runtime_put(&pl022->adev->dev);
 }
Reviewed-by Viresh Kumar <[email protected]>
Signature · 1 line
viresh