Skip to contentSkip to conversation

Fix constness of the fdt void pointer in fdt_getprop_u32_default

PATCH New Gabe Black 4 participants 4 messages Nov 8, 2011 – Nov 13, 2011

lore
Share & tools
lore

Gabe Black

author
#0 lore raw

PATCH 1/1 Fix constness of the fdt void pointer in fdt_getprop_u32_default

The function fdt_getprop_u32_default doesn't modify the fdt, so it can use a const void * for its fdt argument.

Signed-off-by Gabe Black <[email protected]>
---
 common/fdt_support.c  |    4 ++--
 include/fdt_support.h |    4 ++--
 2 files changed, 4 insertions(+), 4 deletions(-)
common/fdt_support.c +2 -2
index bdda64d..bd3a014 100644
@@ -49,8 +49,8 @@ DECLARE_GLOBAL_DATA_PTR;
  * Convenience function to find a node and return it's property or a
  * default value if it doesn't exist.
  */
-u32 fdt_getprop_u32_default(void *fdt, const char *path, const char *prop,
-				const u32 dflt)
+u32 fdt_getprop_u32_default(const void *fdt, const char *path,
+				const char *prop, const u32 dflt)
 {
 	const u32 *val;
 	int off;
include/fdt_support.h +2 -2
index c7b4605..cef3c65 100644
@@ -28,8 +28,8 @@
 
 #include <fdt.h>
 
-u32 fdt_getprop_u32_default(void *fdt, const char *path, const char *prop,
-				const u32 dflt);
+u32 fdt_getprop_u32_default(const void *fdt, const char *path,
+				const char *prop, const u32 dflt);
 int fdt_chosen(void *fdt, int force);
 int fdt_initrd(void *fdt, ulong initrd_start, ulong initrd_end, int force);
 void do_fixup_by_path(void *fdt, const char *path, const char *prop,
Signature · 1 line
1.7.3.1
#1 lore raw

PATCH 1/1 Fix constness of the fdt void pointer in fdt_getprop_u32_default

+fdt maintainer

Quoted 38 lines · On Tuesday 08 November 2011 04:09:44 Gabe Black wrote:

The function fdt_getprop_u32_default doesn't modify the fdt, so it can use a const void * for its fdt argument.

Signed-off-by Gabe Black <[email protected]>
---
 common/fdt_support.c  |    4 ++--
 include/fdt_support.h |    4 ++--
 2 files changed, 4 insertions(+), 4 deletions(-)
common/fdt_support.c +2 -2
index bdda64d..bd3a014 100644
@@ -49,8 +49,8 @@ DECLARE_GLOBAL_DATA_PTR;
  * Convenience function to find a node and return it's property or a
  * default value if it doesn't exist.
  */
-u32 fdt_getprop_u32_default(void *fdt, const char *path, const char *prop,
-				const u32 dflt)
+u32 fdt_getprop_u32_default(const void *fdt, const char *path,
+				const char *prop, const u32 dflt)
 {
 	const u32 *val;
 	int off;
include/fdt_support.h +2 -2
index c7b4605..cef3c65 100644
@@ -28,8 +28,8 @@
 
 #include <fdt.h>
 
-u32 fdt_getprop_u32_default(void *fdt, const char *path, const char *prop,
-				const u32 dflt);
+u32 fdt_getprop_u32_default(const void *fdt, const char *path,
+				const char *prop, const u32 dflt);
 int fdt_chosen(void *fdt, int force);
 int fdt_initrd(void *fdt, ulong initrd_start, ulong initrd_end, int
Quoted 2 lines

force); void do_fixup_by_path(void *fdt, const char *path, const char *prop,

-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: This is a digitally signed message part.
Url : http://lists.denx.de/pipermail/u-boot/attachments/20111108/e19d79cf/attachment.pgp

#2 lore raw

PATCH 1/1 Fix constness of the fdt void pointer in fdt_getprop_u32_default

Bump.

Quoted 47 lines · Mike Frysinger

+fdt maintainer

Quoted 1 line · On Tuesday 08 November 2011 04:09:44 Gabe Black wrote:

The function fdt_getprop_u32_default doesn't modify the fdt, so it can

use

Quoted 13 lines

a const void * for its fdt argument.

Signed-off-by Gabe Black <[email protected]>
---
 common/fdt_support.c  |    4 ++--
 include/fdt_support.h |    4 ++--
 2 files changed, 4 insertions(+), 4 deletions(-)
common/fdt_support.c +0 -0
index bdda64d..bd3a014 100644

common/fdt_support.c DECLARE_GLOBAL_DATA_PTR; · line 52

Quoted 4 lines
common/fdt_support.c +0 -1
@@ -49,8 +49,8 @@ DECLARE_GLOBAL_DATA_PTR;
  * Convenience function to find a node and return it's property or a
  * default value if it doesn't exist.
  */
-u32 fdt_getprop_u32_default(void *fdt, const char *path, const char

*prop,

Quoted 11 lines
common/fdt_support.c +2 -1
-                             const u32 dflt)
+u32 fdt_getprop_u32_default(const void *fdt, const char *path,
+                             const char *prop, const u32 dflt)
 {
      const u32 *val;
      int off;
include/fdt_support.h +0 -0
index c7b4605..cef3c65 100644

include/fdt_support.h line 31

Quoted 4 lines
include/fdt_support.h +0 -1
@@ -28,8 +28,8 @@
 
 #include <fdt.h>
 
-u32 fdt_getprop_u32_default(void *fdt, const char *path, const char

*prop,

Quoted 7 lines
include/fdt_support.h +2 -1
-                             const u32 dflt);
+u32 fdt_getprop_u32_default(const void *fdt, const char *path,
+                             const char *prop, const u32 dflt);
 int fdt_chosen(void *fdt, int force);
 int fdt_initrd(void *fdt, ulong initrd_start, ulong initrd_end, int

force); void do_fixup_by_path(void *fdt, const char *path, const char *prop,