mmc: support BKOPS feature for eMMC
PATCH v2 1/1 mmc: support BKOPS feature for eMMC
Enable eMMC background operations (BKOPS) feature.
If URGENT_BKOPS is set after a response, note that BKOPS are required. After all I/O requests are finished, run BKOPS if required. Should read/write operations be requested during BKOPS, first issue HPI to interrupt the ongoing BKOPS and then service the request.
If you want to enable this feature, set MMC_CAP2_BKOPS.
---
Changelog V2:
- Use EXCEPTION_STATUS instead of URGENT_BKOPS
- Add function to check Exception_status(for eMMC4.5)
- remove unnecessary code.
drivers/mmc/card/block.c | 9 +++++ drivers/mmc/card/queue.c | 4 ++ drivers/mmc/core/core.c | 87 ++++++++++++++++++++++++++++++++++++++++++++ drivers/mmc/core/mmc.c | 9 ++++- drivers/mmc/core/mmc_ops.c | 4 ++ include/linux/mmc/card.h | 12 ++++++ include/linux/mmc/core.h | 3 ++ include/linux/mmc/host.h | 1 + include/linux/mmc/mmc.h | 14 +++++++ 9 files changed, 142 insertions(+), 1 deletions(-)
drivers/mmc/card/block.c +9 -0
@@ -1192,6 +1192,15 @@ static int mmc_blk_issue_rw_rq(struct mmc_queue *mq, struct request *rqc)case MMC_BLK_SUCCESS :case MMC_BLK_PARTIAL :/* +* Check BKOPS urgency from each R1 response +*/ +if (mmc_card_mmc (card) && + (brq->cmd.resp[0 ] &R1_EXCEPTION_EVENT )) { +if (mmc_is_exception_event (card, +EXT_CSD_URGENT_BKOPS )) +mmc_card_set_need_bkops (card); + } +/* * A block was successfully transferred. */ mmc_blk_reset_success (md, type);
drivers/mmc/card/queue.c +4 -0
@@ -61,6 +61,9 @@ static int mmc_queue_thread(void *d)spin_unlock_irq (q->queue_lock);if (req || mq->mqrq_prev->req) { +if (mmc_card_doing_bkops (mq->card)) +mmc_interrupt_bkops (mq->card); +set_current_state (TASK_RUNNING ); mq->issue_fn (mq, req); }else {
@@ -68,6 +71,7 @@ static int mmc_queue_thread(void *d)set_current_state (TASK_RUNNING );break ; } +mmc_start_bkops (mq->card);up (&mq->thread_sem);schedule ();down (&mq->thread_sem);
drivers/mmc/core/core.c +87 -0
99 lines not on this page · raw message
drivers/mmc/core/mmc.c +8 -1
@@ -448,6 +448,14 @@ static int mmc_read_ext_csd(struct mmc_card *card, u8 *ext_csd) }if (card->ext_csd.rev >=5 ) { +/* check whether the eMMC card support BKOPS */ +if (ext_csd[EXT_CSD_BKOPS_SUPPORT ] &0x1 ) { + card->ext_csd.bkops =1 ; + card->ext_csd.bkops_en =1 ; + card->ext_csd.raw_bkops_status = + ext_csd[EXT_CSD_BKOPS_STATUS ]; + } +/* check whether the eMMC card supports HPI */ if (ext_csd[EXT_CSD_HPI_FEATURES ] &0x1 ) { card->ext_csd.hpi =1 ;
@@ -498,7 +506,6 @@ static inline void mmc_free_ext_csd(u8 *ext_csd)kfree (ext_csd); } -static int mmc_compare_ext_csds (struct mmc_card *card,unsigned bus_width) {u8 *bw_ext_csd;
drivers/mmc/core/mmc_ops.c +4 -0
@@ -398,6 +398,10 @@ int mmc_switch(struct mmc_card *card, u8 set, u8 index, u8 value,if (err)return err; +/* No need to check card status in case of BKOPS switch*/ +if (index ==EXT_CSD_BKOPS_START ) +return 0 ; +/* Must check status to be sure of no errors */ do { err = mmc_send_status(card, &status);
include/linux/mmc/card.h +12 -0
@@ -71,6 +71,8 @@ struct mmc_ext_csd {bool hpi_en;/* HPI enablebit */ bool hpi;/* HPI support bit */ unsigned int hpi_cmd;/* cmd used as HPI */ +bool bkops;/* background support bit */ +bool bkops_en;/* background enable bit */ u8 raw_partition_support;/* 160 */ u8 raw_erased_mem_count;/* 181 */ u8 raw_ext_csd_structure;/* 194 */
@@ -84,6 +86,7 @@ struct mmc_ext_csd {u8 raw_sec_erase_mult;/* 230 */ u8 raw_sec_feature_support;/* 231 */ u8 raw_trim_mult;/* 232 */ +u8 raw_bkops_status;/* 246 */ u8 raw_sectors[4 ];/* 212 - 4 bytes */ unsigned int feature_support;
@@ -206,6 +209,8 @@ struct mmc_card {#define MMC_STATE_HIGHSPEED_DDR (1<<4)/* card is in high speed mode */ #define MMC_STATE_ULTRAHIGHSPEED (1<<5)/* card is in ultra high speed mode */ #define MMC_CARD_SDXC (1<<6)/* card is SDXC */ +#define MMC_STATE_NEED_BKOPS (1<<7)/* card need to do BKOPS */ +#define MMC_STATE_DOING_BKOPS (1<<8)/* card is doing BKOPS */ unsigned int quirks;/* card quirks */ #define MMC_QUIRK_LENIENT_FN0 (1<<0)/* allow SDIO FN0 writes outside of the VS CCCR range */ #define MMC_QUIRK_BLKSZ_FOR_BYTE_MODE (1<<1)/* use func->cur_blksize */
@@ -365,6 +370,8 @@ static inline void __maybe_unused remove_quirk(struct mmc_card *card, int data)#define mmc_card_ddr_mode (c) ((c)->state & MMC_STATE_HIGHSPEED_DDR)#define mmc_sd_card_uhs (c) ((c)->state & MMC_STATE_ULTRAHIGHSPEED)#define mmc_card_ext_capacity (c) ((c)->state & MMC_CARD_SDXC) +#define mmc_card_need_bkops (c) ((c)->state & MMC_STATE_NEED_BKOPS) +#define mmc_card_doing_bkops (c) ((c)->state & MMC_STATE_DOING_BKOPS)#define mmc_card_set_present (c) ((c)->state |= MMC_STATE_PRESENT)#define mmc_card_set_readonly (c) ((c)->state |= MMC_STATE_READONLY)
@@ -373,6 +380,11 @@ static inline void __maybe_unused remove_quirk(struct mmc_card *card, int data)#define mmc_card_set_ddr_mode (c) ((c)->state |= MMC_STATE_HIGHSPEED_DDR)#define mmc_sd_card_set_uhs (c) ((c)->state |= MMC_STATE_ULTRAHIGHSPEED)#define mmc_card_set_ext_capacity (c) ((c)->state |= MMC_CARD_SDXC) +#define mmc_card_set_need_bkops (c) ((c)->state |= MMC_STATE_NEED_BKOPS) +#define mmc_card_set_doing_bkops (c) ((c)->state |= MMC_STATE_DOING_BKOPS) + +#define mmc_card_clr_need_bkops (c) ((c)->state &= ~MMC_STATE_NEED_BKOPS) +#define mmc_card_clr_doing_bkops (c) ((c)->state &= ~MMC_STATE_DOING_BKOPS)/* * Quirk add/remove for MMC products.
include/linux/mmc/core.h +3 -0
@@ -134,6 +134,8 @@ struct mmc_host;struct mmc_card ;struct mmc_async_req ; +extern int mmc_interrupt_bkops (struct mmc_card *); +extern int mmc_is_exception_event (struct mmc_card *,unsigned int );extern struct mmc_async_req *mmc_start_req (struct mmc_host *,struct mmc_async_req *,int *);extern int mmc_interrupt_hpi (struct mmc_card *);
@@ -163,6 +165,7 @@ extern int mmc_can_sanitize(struct mmc_card *card);extern int mmc_can_secure_erase_trim (struct mmc_card *card);extern int mmc_erase_group_aligned (struct mmc_card *card,unsigned int from,unsigned int nr); +extern void mmc_start_bkops (struct mmc_card *card);extern unsigned int mmc_calc_max_discard (struct mmc_card *card);extern int mmc_set_blocklen (struct mmc_card *card,unsigned int blocklen);
include/linux/mmc/host.h +1 -0
@@ -242,6 +242,7 @@ struct mmc_host {#define MMC_CAP2_CACHE_CTRL (1 << 1)/* Allow cache control */ #define MMC_CAP2_POWEROFF_NOTIFY (1 << 2)/* Notify poweroff supported */ #define MMC_CAP2_NO_MULTI_READ (1 << 3)/* Multiblock reads don't work */ +#define MMC_CAP2_BKOPS (1 << 4)/* BKOPS supported */ mmc_pm_flag_t pm_caps;/* supported pm features */ unsigned int power_notify_type;
include/linux/mmc/mmc.h +14 -0
@@ -138,6 +138,7 @@ static inline bool mmc_op_multi(u32 opcode)#define R1_CURRENT_STATE (x) ((x & 0x00001E00) >> 9)/* sx, b (4 bits) */ #define R1_READY_FOR_DATA (1 << 8)/* sx, a */ #define R1_SWITCH_ERROR (1 << 7)/* sx, c */ +#define R1_EXCEPTION_EVENT (1 << 6)/* sx, a */ #define R1_APP_CMD (1 << 5)/* sr, c */ #define R1_STATE_IDLE 0
@@ -273,11 +274,14 @@ struct _mmc_csd {#define EXT_CSD_FLUSH_CACHE 32/* W */ #define EXT_CSD_CACHE_CTRL 33/* R/W */ #define EXT_CSD_POWER_OFF_NOTIFICATION 34/* R/W */ +#define EXT_CSD_EXCEPTION_STATUS 54/* RO */ #define EXT_CSD_GP_SIZE_MULT 143/* R/W */ #define EXT_CSD_PARTITION_ATTRIBUTE 156/* R/W */ #define EXT_CSD_PARTITION_SUPPORT 160/* RO */ #define EXT_CSD_HPI_MGMT 161/* R/W */ #define EXT_CSD_RST_N_FUNCTION 162/* R/W */ +#define EXT_CSD_BKOPS_EN 163/* R/W */ +#define EXT_CSD_BKOPS_START 164/* W */ #define EXT_CSD_SANITIZE_START 165/* W */ #define EXT_CSD_WR_REL_PARAM 166/* RO */ #define EXT_CSD_ERASE_GROUP_DEF 175/* R/W */
@@ -310,9 +314,11 @@ struct _mmc_csd {#define EXT_CSD_PWR_CL_200_360 237/* RO */ #define EXT_CSD_PWR_CL_DDR_52_195 238/* RO */ #define EXT_CSD_PWR_CL_DDR_52_360 239/* RO */ +#define EXT_CSD_BKOPS_STATUS 246/* RO */ #define EXT_CSD_POWER_OFF_LONG_TIME 247/* RO */ #define EXT_CSD_GENERIC_CMD6_TIME 248/* RO */ #define EXT_CSD_CACHE_SIZE 249/* RO, 4 bytes */ +#define EXT_CSD_BKOPS_SUPPORT 502/* RO */ #define EXT_CSD_HPI_FEATURES 503/* RO */ /*
@@ -373,4 +379,12 @@ struct _mmc_csd {#define MMC_SWITCH_MODE_CLEAR_BITS 0x02/* Clear bits which are 1 in value */ #define MMC_SWITCH_MODE_WRITE_BYTE 0x03/* Set target to value */ +/* +* EXCEPTION_EVENT_STATUS field (eMMC4.5) +*/ +#define EXT_CSD_URGENT_BKOPS BIT(0) +#define EXT_CSD_DYNCAP_NEEDED BIT(1) +#define EXT_CSD_SYSPOOL_EXHAUSTED BIT(2) +#define EXT_CSD_PACKED_FAILURE BIT(3) +#endif /* LINUX_MMC_MMC_H */
Hi Jaehoon,
Quoted 86 lines · Jaehoon Chung
Enable eMMC background operations (BKOPS) feature.
If
URGENT_BKOPSis set after a response, note that BKOPS are required. After all I/O requests are finished, run BKOPS if required. Should read/write operations be requested during BKOPS, first issue HPI to interrupt the ongoing BKOPS and then service the request.If you want to enable this feature, set
MMC_CAP2_BKOPS.Signed-off-by Jaehoon Chung <[email protected]>Signed-off-by Kyungmin Park <[email protected]>CC Hanumath Prasad <[email protected]>---
Changelog V2:
- UseEXCEPTION_STATUSinstead ofURGENT_BKOPS
- Add function to checkException_status(for eMMC4.5)
- remove unnecessary code.drivers/mmc/card/block.c | 9 +++++
drivers/mmc/card/queue.c | 4 ++
drivers/mmc/core/core.c | 87 ++++++++++++++++++++++++++++++++++++++++++++drivers/mmc/core/mmc.c| 9 ++++-drivers/mmc/core/mmc_ops.c| 4 ++include/linux/mmc/card.h | 12 ++++++ include/linux/mmc/core.h | 3 ++ include/linux/mmc/host.h | 1 + include/linux/mmc/mmc.h | 14 +++++++ 9 files changed, 142 insertions(+), 1 deletions(-)drivers/mmc/card/block.c +0
-0@@ -1192,6 +1192,15 @@ static int mmc_blk_issue_rw_rq(struct mmc_queue *mq, struct request *rqc)case
MMC_BLK_SUCCESS:
caseMMC_BLK_PARTIAL:
/*
+ * Check BKOPS urgency from each R1 response
+ */
+ if (mmc_card_mmc(card)&&
+ (brq->cmd.resp[0] &R1_EXCEPTION_EVENT)) {
+ if (mmc_is_exception_event(card,
+EXT_CSD_URGENT_BKOPS))
+mmc_card_set_need_bkops(card);
+ }
+ /*
* A block was successfully transferred. */
mmc_blk_reset_success(md, type);drivers/mmc/card/queue.c +4
-0@@ -61,6 +61,9 @@ static int mmc_queue_thread(void *d) spin_unlock_irq(q->queue_lock); if (req || mq->mqrq_prev->req) { + if (mmc_card_doing_bkops(mq->card)) + mmc_interrupt_bkops(mq->card); + set_current_state(TASK_RUNNING); mq->issue_fn(mq, req); } else {@@ -68,6 +71,7 @@ static int mmc_queue_thread(void *d) set_current_state(TASK_RUNNING); break; } + mmc_start_bkops(mq->card); up(&mq->thread_sem); schedule(); down(&mq->thread_sem);drivers/mmc/core/core.c +5
-0@@ -238,6 +238,50 @@ mmc_start_request(struct mmc_host *host, struct mmc_request *mrq) host->ops->request(host, mrq); } +/** +* mmc_start_bkops - start BKOPS for supported cards +* @card: MMC card to start BKOPS +* +* Start background operations whenever requested.
drivers/mmc/core/core.c mmc_start_request(struct mmc_host *host, struct mmc_request *mrq) · line 255
Quoted 10 lines
drivers/mmc/core/core.c +9
-0+* when the urgent BKOPS bit is set in a R1 command response +* then background operations should be started immediately. +*/ +void mmc_start_bkops (struct mmc_card *card) +{ + int err; + unsigned long flags; + + card->host->caps2 |= MMC_CAP2_BKOPS;
I guess this should be set by the host driver?
drivers/mmc/core/core.c mmc_start_request(struct mmc_host *host, struct mmc_request *mrq) · line 256
Quoted 2 lines
drivers/mmc/core/core.c +2
-0+ if ((!card || !card->ext_csd.bkops_en) && + !(card->host->caps2 & MMC_CAP2_BKOPS))
I don't really understand this. If card is NULL it will seg-fault.
Do you mean:
if (!card)
return
if (!card->ext_csd.bkops_en ||
!(card->host->caps2 & MMC_CAP2_BKOPS))
return
Do you really need to check card != NULL? Consider BUG_ON
Quoted 86 lines
drivers/mmc/core/core.c +28
-0+ return; + + /* + * If card is already doing bkops or need for + * bkops flag is not set, then do nothing just + * return + */ + if (mmc_card_doing_bkops(card) + || !mmc_card_need_bkops(card)) + return; + + mmc_claim_host(card->host); + err = mmc_switch(card, EXT_CSD_CMD_SET_NORMAL, + EXT_CSD_BKOPS_START, 1, 0); + if (err) { + pr_warning("error %d starting bkops\n", err); + mmc_card_clr_need_bkops(card); + goto out; + } + spin_lock_irqsave(&card->host->lock, flags); + mmc_card_clr_need_bkops(card); + mmc_card_set_doing_bkops(card); + spin_unlock_irqrestore(&card->host->lock, flags); +out: + mmc_release_host(card->host); +} +EXPORT_SYMBOL (mmc_start_bkops); + static void mmc_wait_done(struct mmc_request *mrq) {complete(&mrq->completion);
drivers/mmc/core/core.c +43
-0@@ -466,6 +510,49 @@ int mmc_wait_for_cmd(struct mmc_host *host, struct mmc_command *cmd, int retries EXPORT_SYMBOL(mmc_wait_for_cmd); /** +* mmc_interrupt_bkops - interrupt ongoing BKOPS +* @card: MMC card to check BKOPS +* +* Send HPI command to interrupt ongoing background operations, +* to allow rapid servicing of foreground operations,e.g. read/ +* writes. Wait until the card comes out of the programming state +* to avoid errors in servicing read/write requests. +*/ +int mmc_interrupt_bkops (struct mmc_card *card) +{ + int err = 0; + unsigned long flags; + + BUG_ON(!card); + + err = mmc_interrupt_hpi(card); + + spin_lock_irqsave(&card->host->lock, flags); + mmc_card_clr_doing_bkops(card); + spin_unlock_irqrestore(&card->host->lock, flags); + + return err; +} +EXPORT_SYMBOL (mmc_interrupt_bkops); + +int mmc_is_exception_event (struct mmc_card *card,unsigned int value) +{ + int err; + u8 ext_csd[512]; + + /* In eMMC 4.41, R1_EXCEPTION_EVENT is URGENT_BKOPS */ + if (card->ext_csd.rev == 5) + return 1; + + err = mmc_send_ext_csd(card, ext_csd); + if (err) + return err; + + return (ext_csd[EXT_CSD_EXCEPTION_STATUS] & value) ? 1 : 0; +} +EXPORT_SYMBOL (mmc_is_exception_event); + +/** * mmc_set_data_timeout - set the timeout for a data command * @data: data phase for command * @card: the MMC card associated with the data transfer drivers/mmc/core/mmc.c +0
-0
drivers/mmc/core/mmc.c static int mmc_read_ext_csd(struct mmc_card *card, u8 *ext_csd) · line 454
Quoted 7 lines
drivers/mmc/core/mmc.c +4
-0@@ -448,6 +448,14 @@ static int mmc_read_ext_csd(struct mmc_card *card, u8 *ext_csd) } if (card->ext_csd.rev >= 5) { + /* check whether the eMMC card support BKOPS */ + if (ext_csd[EXT_CSD_BKOPS_SUPPORT] & 0x1) { + card->ext_csd.bkops = 1; + card->ext_csd.bkops_en = 1;
What if the card has not enabled bkops? This bit could be unset. card->ext_csd.bkops_en = ext_csd[EXT_CSD_BKOPS_EN];
Quoted 167 lines
drivers/mmc/core/mmc.c +4
-1+ card->ext_csd.raw_bkops_status = + ext_csd[EXT_CSD_BKOPS_STATUS]; + } + /* check whether the eMMC card supports HPI */ if (ext_csd[EXT_CSD_HPI_FEATURES] & 0x1) { card->ext_csd.hpi = 1;@@ -498,7 +506,6 @@ static inline void mmc_free_ext_csd(u8 *ext_csd) kfree(ext_csd); } - static int mmc_compare_ext_csds(struct mmc_card *card, unsigned bus_width) { u8 *bw_ext_csd;drivers/mmc/core/mmc_ops.c +4
-0@@ -398,6 +398,10 @@ int mmc_switch(struct mmc_card *card, u8 set, u8 index, u8 value, if (err) return err; + /* No need to check card status in case of BKOPS switch*/ + if (index == EXT_CSD_BKOPS_START) + return 0; + /* Must check status to be sure of no errors */ do { err = mmc_send_status(card, &status);include/linux/mmc/card.h +0
-0@@ -71,6 +71,8 @@ struct mmc_ext_csd {bool hpi_en; /* HPI enablebit */ bool hpi; /* HPI support bit */ unsigned int hpi_cmd; /* cmd used as HPI */
+ bool bkops; /* background support bit */
+ bool bkops_en; /* background enable bit */ u8 raw_partition_support; /* 160 */ u8 raw_erased_mem_count; /* 181 */ u8 raw_ext_csd_structure; /* 194 */include/linux/mmc/card.h +0
-0@@ -84,6 +86,7 @@ struct mmc_ext_csd {u8 raw_sec_erase_mult; /* 230 */ u8 raw_sec_feature_support;/* 231 */ u8 raw_trim_mult; /* 232 */
+ u8 raw_bkops_status; /* 246 */ u8 raw_sectors[4]; /* 212 - 4 bytes */unsigned int feature_support;
include/linux/mmc/card.h +2
-0@@ -206,6 +209,8 @@ struct mmc_card { #define MMC_STATE_HIGHSPEED_DDR (1<<4) /* card is in high speed mode */ #define MMC_STATE_ULTRAHIGHSPEED (1<<5) /* card is in ultra high speed mode */ #define MMC_CARD_SDXC (1<<6) /* card is SDXC */ +#define MMC_STATE_NEED_BKOPS (1<<7)/* card need to do BKOPS */ +#define MMC_STATE_DOING_BKOPS (1<<8)/* card is doing BKOPS */ unsigned int quirks; /* card quirks */
#defineMMC_QUIRK_LENIENT_FN0(1<<0) /* allow SDIO FN0 writes outside of the VS CCCR range */ #defineMMC_QUIRK_BLKSZ_FOR_BYTE_MODE(1<<1) /* usefunc->cur_blksize*/include/linux/mmc/card.h +7
-0@@ -365,6 +370,8 @@ static inline void __maybe_unused remove_quirk(struct mmc_card *card, int data) #define mmc_card_ddr_mode(c) ((c)->state & MMC_STATE_HIGHSPEED_DDR) #define mmc_sd_card_uhs(c) ((c)->state & MMC_STATE_ULTRAHIGHSPEED) #define mmc_card_ext_capacity(c) ((c)->state & MMC_CARD_SDXC) +#define mmc_card_need_bkops (c) ((c)->state & MMC_STATE_NEED_BKOPS) +#define mmc_card_doing_bkops (c) ((c)->state & MMC_STATE_DOING_BKOPS) #define mmc_card_set_present(c) ((c)->state |= MMC_STATE_PRESENT) #define mmc_card_set_readonly(c) ((c)->state |= MMC_STATE_READONLY)@@ -373,6 +380,11 @@ static inline void __maybe_unused remove_quirk(struct mmc_card *card, int data) #define mmc_card_set_ddr_mode(c) ((c)->state |= MMC_STATE_HIGHSPEED_DDR) #define mmc_sd_card_set_uhs(c) ((c)->state |= MMC_STATE_ULTRAHIGHSPEED) #define mmc_card_set_ext_capacity(c) ((c)->state |= MMC_CARD_SDXC) +#define mmc_card_set_need_bkops (c) ((c)->state |= MMC_STATE_NEED_BKOPS) +#define mmc_card_set_doing_bkops (c) ((c)->state |= MMC_STATE_DOING_BKOPS) + +#define mmc_card_clr_need_bkops (c) ((c)->state &= ~MMC_STATE_NEED_BKOPS) +#define mmc_card_clr_doing_bkops (c) ((c)->state &= ~MMC_STATE_DOING_BKOPS) /** Quirk add/remove for MMC products. include/linux/mmc/core.h +3
-0@@ -134,6 +134,8 @@ struct mmc_host; struct mmc_card; struct mmc_async_req; +extern int mmc_interrupt_bkops (struct mmc_card *); +extern int mmc_is_exception_event (struct mmc_card *,unsigned int ); extern struct mmc_async_req *mmc_start_req(struct mmc_host *, struct mmc_async_req *, int *); extern int mmc_interrupt_hpi(struct mmc_card *);@@ -163,6 +165,7 @@ extern int mmc_can_sanitize(struct mmc_card *card); extern int mmc_can_secure_erase_trim(struct mmc_card *card); extern int mmc_erase_group_aligned(struct mmc_card *card, unsigned int from, unsigned int nr); +extern void mmc_start_bkops (struct mmc_card *card); extern unsigned int mmc_calc_max_discard(struct mmc_card *card); extern int mmc_set_blocklen(struct mmc_card *card, unsigned int blocklen);include/linux/mmc/host.h +1
-0@@ -242,6 +242,7 @@ struct mmc_host { #define MMC_CAP2_CACHE_CTRL (1 << 1) /* Allow cache control */ #define MMC_CAP2_POWEROFF_NOTIFY (1 << 2) /* Notify poweroff supported */ #define MMC_CAP2_NO_MULTI_READ (1 << 3) /* Multiblock reads don't work */ +#define MMC_CAP2_BKOPS (1 << 4)/* BKOPS supported */ mmc_pm_flag_t
pm_caps; /* supported pm features */ unsigned int power_notify_type;include/linux/mmc/mmc.h +14
-1@@ -138,6 +138,7 @@ static inline bool mmc_op_multi(u32 opcode) #define R1_CURRENT_STATE(x) ((x & 0x00001E00) >> 9) /* sx, b (4 bits) */ #define R1_READY_FOR_DATA (1 << 8) /* sx, a */ #define R1_SWITCH_ERROR (1 << 7) /* sx, c */ +#define R1_EXCEPTION_EVENT (1 << 6)/* sx, a */ #define R1_APP_CMD (1 << 5) /* sr, c */ #define R1_STATE_IDLE 0@@ -273,11 +274,14 @@ struct _mmc_csd { #define EXT_CSD_FLUSH_CACHE 32 /* W */ #define EXT_CSD_CACHE_CTRL 33 /* R/W */ #define EXT_CSD_POWER_OFF_NOTIFICATION 34 /* R/W */ +#define EXT_CSD_EXCEPTION_STATUS 54/* RO */ #define EXT_CSD_GP_SIZE_MULT 143 /* R/W */ #define EXT_CSD_PARTITION_ATTRIBUTE 156 /* R/W */ #define EXT_CSD_PARTITION_SUPPORT 160 /* RO */ #define EXT_CSD_HPI_MGMT 161 /* R/W */ #define EXT_CSD_RST_N_FUNCTION 162 /* R/W */ +#define EXT_CSD_BKOPS_EN 163/* R/W */ +#define EXT_CSD_BKOPS_START 164/* W */ #define EXT_CSD_SANITIZE_START 165 /* W */ #define EXT_CSD_WR_REL_PARAM 166 /* RO */ #define EXT_CSD_ERASE_GROUP_DEF 175 /* R/W */@@ -310,9 +314,11 @@ struct _mmc_csd { #define EXT_CSD_PWR_CL_200_360 237 /* RO */ #define EXT_CSD_PWR_CL_DDR_52_195 238 /* RO */ #define EXT_CSD_PWR_CL_DDR_52_360 239 /* RO */ +#define EXT_CSD_BKOPS_STATUS 246/* RO */ #define EXT_CSD_POWER_OFF_LONG_TIME 247 /* RO */ #define EXT_CSD_GENERIC_CMD6_TIME 248 /* RO */ #define EXT_CSD_CACHE_SIZE 249 /* RO, 4 bytes */ +#define EXT_CSD_BKOPS_SUPPORT 502/* RO */ #define EXT_CSD_HPI_FEATURES 503 /* RO */ /*@@ -373,4 +379,12 @@ struct _mmc_csd { #define MMC_SWITCH_MODE_CLEAR_BITS 0x02 /* Clear bits which are 1 in value */ #define MMC_SWITCH_MODE_WRITE_BYTE 0x03 /* Set target to value */ +/* +* EXCEPTION_EVENT_STATUS field (eMMC4.5) +*/ +#define EXT_CSD_URGENT_BKOPS BIT(0) +#define EXT_CSD_DYNCAP_NEEDED BIT(1) +#define EXT_CSD_SYSPOOL_EXHAUSTED BIT(2) +#define EXT_CSD_PACKED_FAILURE BIT(3) + #endif /* LINUX_MMC_MMC_H */ --
Quoted 4 lines
To unsubscribe from this list: send the line "unsubscribe linux-mmc" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Regards,
Per
Hi Per.
2011/11/5 Per Forlin <[email protected]>:
Quoted 98 lines
Hi Jaehoon,
Quoted 94 lines · Jaehoon Chung
Enable eMMC background operations (BKOPS) feature.
If
URGENT_BKOPSis set after a response, note that BKOPS are required. After all I/O requests are finished, run BKOPS if required. Should read/write operations be requested during BKOPS, first issue HPI to interrupt the ongoing BKOPS and then service the request.If you want to enable this feature, set
MMC_CAP2_BKOPS.Signed-off-by Jaehoon Chung <[email protected]>Signed-off-by Kyungmin Park <[email protected]>CC Hanumath Prasad <[email protected]>---
Changelog V2:
- UseEXCEPTION_STATUSinstead ofURGENT_BKOPS
- Add function to checkException_status(for eMMC4.5)
- remove unnecessary code.drivers/mmc/card/block.c | 9 +++++
drivers/mmc/card/queue.c | 4 ++
drivers/mmc/core/core.c | 87 ++++++++++++++++++++++++++++++++++++++++++++drivers/mmc/core/mmc.c| 9 ++++-drivers/mmc/core/mmc_ops.c| 4 ++include/linux/mmc/card.h | 12 ++++++ include/linux/mmc/core.h | 3 ++ include/linux/mmc/host.h | 1 + include/linux/mmc/mmc.h | 14 +++++++ 9 files changed, 142 insertions(+), 1 deletions(-)drivers/mmc/card/block.c +0
-0@@ -1192,6 +1192,15 @@ static int mmc_blk_issue_rw_rq(struct mmc_queue *mq, struct request *rqc)case
MMC_BLK_SUCCESS:
caseMMC_BLK_PARTIAL:
/*
+ * Check BKOPS urgency from each R1 response
+ */
+ if (mmc_card_mmc(card)&&
+ (brq->cmd.resp[0] &R1_EXCEPTION_EVENT)) {
+ if (mmc_is_exception_event(card,
+EXT_CSD_URGENT_BKOPS))
+mmc_card_set_need_bkops(card);
+ }
+ /*
* A block was successfully transferred. */
mmc_blk_reset_success(md, type);drivers/mmc/card/queue.c +4
-0@@ -61,6 +61,9 @@ static int mmc_queue_thread(void *d) spin_unlock_irq(q->queue_lock); if (req || mq->mqrq_prev->req) { + if (mmc_card_doing_bkops(mq->card)) + mmc_interrupt_bkops(mq->card); + set_current_state(TASK_RUNNING); mq->issue_fn(mq, req); } else {@@ -68,6 +71,7 @@ static int mmc_queue_thread(void *d) set_current_state(TASK_RUNNING); break; } + mmc_start_bkops(mq->card); up(&mq->thread_sem); schedule(); down(&mq->thread_sem);drivers/mmc/core/core.c +13
-0@@ -238,6 +238,50 @@ mmc_start_request(struct mmc_host *host, struct mmc_request *mrq) host->ops->request(host, mrq); } +/** +* mmc_start_bkops - start BKOPS for supported cards +* @card: MMC card to start BKOPS +* +* Start background operations whenever requested. +* when the urgent BKOPS bit is set in a R1 command response +* then background operations should be started immediately. +*/ +void mmc_start_bkops (struct mmc_card *card) +{ + int err; + unsigned long flags; +
Quoted 2 lines
drivers/mmc/core/core.c mmc_start_request(struct mmc_host *host, struct mmc_request *mrq) · line 254
Quoted 1 line
drivers/mmc/core/core.c +1
-0+ card->host->caps2 |= MMC_CAP2_BKOPS;I guess this should be set by the host driver?
You're right...it's my mistake...i will remove this..
Quoted 9 lines
drivers/mmc/core/core.c mmc_start_request(struct mmc_host *host, struct mmc_request *mrq) · line 256
Quoted 3 lines
drivers/mmc/core/core.c +2
-0+ if ((!card || !card->ext_csd.bkops_en) && + !(card->host->caps2 & MMC_CAP2_BKOPS))I don't really understand this. If card is NULL it will seg-fault.
Do you mean:
if (!card)
return
Quoted 5 lines
if (!card->ext_csd.bkops_en ||
!(card->host->caps2 &MMC_CAP2_BKOPS))
returnDo you really need to check card != NULL? Consider
BUG_ON
Maybe if (!card && !card->ext_csd.bkops_en) is correctly...i think...
Quoted 89 lines
Quoted 89 lines
drivers/mmc/core/core.c +71
-0+ return; + + /* + * If card is already doing bkops or need for + * bkops flag is not set, then do nothing just + * return + */ + if (mmc_card_doing_bkops(card) + || !mmc_card_need_bkops(card)) + return; + + mmc_claim_host(card->host); + err = mmc_switch(card, EXT_CSD_CMD_SET_NORMAL, + EXT_CSD_BKOPS_START, 1, 0); + if (err) { + pr_warning("error %d starting bkops\n", err); + mmc_card_clr_need_bkops(card); + goto out; + } + spin_lock_irqsave(&card->host->lock, flags); + mmc_card_clr_need_bkops(card); + mmc_card_set_doing_bkops(card); + spin_unlock_irqrestore(&card->host->lock, flags); +out: + mmc_release_host(card->host); +} +EXPORT_SYMBOL (mmc_start_bkops); + static void mmc_wait_done(struct mmc_request *mrq) { complete(&mrq->completion);@@ -466,6 +510,49 @@ int mmc_wait_for_cmd(struct mmc_host *host, struct mmc_command *cmd, int retries EXPORT_SYMBOL(mmc_wait_for_cmd); /** +* mmc_interrupt_bkops - interrupt ongoing BKOPS +* @card: MMC card to check BKOPS +* +* Send HPI command to interrupt ongoing background operations, +* to allow rapid servicing of foreground operations,e.g. read/ +* writes. Wait until the card comes out of the programming state +* to avoid errors in servicing read/write requests. +*/ +int mmc_interrupt_bkops (struct mmc_card *card) +{ + int err = 0; + unsigned long flags; + + BUG_ON(!card); + + err = mmc_interrupt_hpi(card); + + spin_lock_irqsave(&card->host->lock, flags); + mmc_card_clr_doing_bkops(card); + spin_unlock_irqrestore(&card->host->lock, flags); + + return err; +} +EXPORT_SYMBOL (mmc_interrupt_bkops); + +int mmc_is_exception_event (struct mmc_card *card,unsigned int value) +{ + int err; + u8 ext_csd[512]; + + /* In eMMC 4.41, R1_EXCEPTION_EVENT is URGENT_BKOPS */ + if (card->ext_csd.rev == 5) + return 1; + + err = mmc_send_ext_csd(card, ext_csd); + if (err) + return err; + + return (ext_csd[EXT_CSD_EXCEPTION_STATUS] & value) ? 1 : 0; +} +EXPORT_SYMBOL (mmc_is_exception_event); + +/** * mmc_set_data_timeout - set the timeout for a data command * @data: data phase for command * @card: the MMC card associated with the data transfer drivers/mmc/core/mmc.c +0
-0@@ -448,6 +448,14 @@ static int mmc_read_ext_csd(struct mmc_card *card, u8 *ext_csd) }
Quoted 7 lines
drivers/mmc/core/mmc.c static int mmc_read_ext_csd(struct mmc_card *card, u8 *ext_csd) · line 454
Quoted 5 lines
drivers/mmc/core/mmc.c +4
-0if (card->ext_csd.rev >= 5) { + /* check whether the eMMC card support BKOPS */ + if (ext_csd[EXT_CSD_BKOPS_SUPPORT] & 0x1) { + card->ext_csd.bkops = 1; + card->ext_csd.bkops_en = 1;What if the card has not enabled bkops? This bit could be unset.
card->ext_csd.bkops_en= ext_csd[EXT_CSD_BKOPS_EN];
When card is supported the bkops, bkops_en bit is set by default...
Quoted 180 lines
Quoted 168 lines
drivers/mmc/core/mmc.c +4
-1+ card->ext_csd.raw_bkops_status = + ext_csd[EXT_CSD_BKOPS_STATUS]; + } + /* check whether the eMMC card supports HPI */ if (ext_csd[EXT_CSD_HPI_FEATURES] & 0x1) { card->ext_csd.hpi = 1;@@ -498,7 +506,6 @@ static inline void mmc_free_ext_csd(u8 *ext_csd) kfree(ext_csd); } - static int mmc_compare_ext_csds(struct mmc_card *card, unsigned bus_width) { u8 *bw_ext_csd;drivers/mmc/core/mmc_ops.c +4
-0@@ -398,6 +398,10 @@ int mmc_switch(struct mmc_card *card, u8 set, u8 index, u8 value, if (err) return err; + /* No need to check card status in case of BKOPS switch*/ + if (index == EXT_CSD_BKOPS_START) + return 0; + /* Must check status to be sure of no errors */ do { err = mmc_send_status(card, &status);include/linux/mmc/card.h +0
-0@@ -71,6 +71,8 @@ struct mmc_ext_csd {bool hpi_en; /* HPI enablebit */ bool hpi; /* HPI support bit */ unsigned int hpi_cmd; /* cmd used as HPI */
+ bool bkops; /* background support bit */
+ bool bkops_en; /* background enable bit */ u8 raw_partition_support; /* 160 */ u8 raw_erased_mem_count; /* 181 */ u8 raw_ext_csd_structure; /* 194 */include/linux/mmc/card.h +0
-0@@ -84,6 +86,7 @@ struct mmc_ext_csd {u8 raw_sec_erase_mult; /* 230 */ u8 raw_sec_feature_support;/* 231 */ u8 raw_trim_mult; /* 232 */
+ u8 raw_bkops_status; /* 246 */ u8 raw_sectors[4]; /* 212 - 4 bytes */unsigned int feature_support;
include/linux/mmc/card.h +2
-0@@ -206,6 +209,8 @@ struct mmc_card { #define MMC_STATE_HIGHSPEED_DDR (1<<4) /* card is in high speed mode */ #define MMC_STATE_ULTRAHIGHSPEED (1<<5) /* card is in ultra high speed mode */ #define MMC_CARD_SDXC (1<<6) /* card is SDXC */ +#define MMC_STATE_NEED_BKOPS (1<<7)/* card need to do BKOPS */ +#define MMC_STATE_DOING_BKOPS (1<<8)/* card is doing BKOPS */ unsigned int quirks; /* card quirks */
#defineMMC_QUIRK_LENIENT_FN0(1<<0) /* allow SDIO FN0 writes outside of the VS CCCR range */ #defineMMC_QUIRK_BLKSZ_FOR_BYTE_MODE(1<<1) /* usefunc->cur_blksize*/include/linux/mmc/card.h +7
-0@@ -365,6 +370,8 @@ static inline void __maybe_unused remove_quirk(struct mmc_card *card, int data) #define mmc_card_ddr_mode(c) ((c)->state & MMC_STATE_HIGHSPEED_DDR) #define mmc_sd_card_uhs(c) ((c)->state & MMC_STATE_ULTRAHIGHSPEED) #define mmc_card_ext_capacity(c) ((c)->state & MMC_CARD_SDXC) +#define mmc_card_need_bkops (c) ((c)->state & MMC_STATE_NEED_BKOPS) +#define mmc_card_doing_bkops (c) ((c)->state & MMC_STATE_DOING_BKOPS) #define mmc_card_set_present(c) ((c)->state |= MMC_STATE_PRESENT) #define mmc_card_set_readonly(c) ((c)->state |= MMC_STATE_READONLY)@@ -373,6 +380,11 @@ static inline void __maybe_unused remove_quirk(struct mmc_card *card, int data) #define mmc_card_set_ddr_mode(c) ((c)->state |= MMC_STATE_HIGHSPEED_DDR) #define mmc_sd_card_set_uhs(c) ((c)->state |= MMC_STATE_ULTRAHIGHSPEED) #define mmc_card_set_ext_capacity(c) ((c)->state |= MMC_CARD_SDXC) +#define mmc_card_set_need_bkops (c) ((c)->state |= MMC_STATE_NEED_BKOPS) +#define mmc_card_set_doing_bkops (c) ((c)->state |= MMC_STATE_DOING_BKOPS) + +#define mmc_card_clr_need_bkops (c) ((c)->state &= ~MMC_STATE_NEED_BKOPS) +#define mmc_card_clr_doing_bkops (c) ((c)->state &= ~MMC_STATE_DOING_BKOPS) /** Quirk add/remove for MMC products. include/linux/mmc/core.h +3
-0@@ -134,6 +134,8 @@ struct mmc_host; struct mmc_card; struct mmc_async_req; +extern int mmc_interrupt_bkops (struct mmc_card *); +extern int mmc_is_exception_event (struct mmc_card *,unsigned int ); extern struct mmc_async_req *mmc_start_req(struct mmc_host *, struct mmc_async_req *, int *); extern int mmc_interrupt_hpi(struct mmc_card *);@@ -163,6 +165,7 @@ extern int mmc_can_sanitize(struct mmc_card *card); extern int mmc_can_secure_erase_trim(struct mmc_card *card); extern int mmc_erase_group_aligned(struct mmc_card *card, unsigned int from, unsigned int nr); +extern void mmc_start_bkops (struct mmc_card *card); extern unsigned int mmc_calc_max_discard(struct mmc_card *card); extern int mmc_set_blocklen(struct mmc_card *card, unsigned int blocklen);include/linux/mmc/host.h +1
-0@@ -242,6 +242,7 @@ struct mmc_host { #define MMC_CAP2_CACHE_CTRL (1 << 1) /* Allow cache control */ #define MMC_CAP2_POWEROFF_NOTIFY (1 << 2) /* Notify poweroff supported */ #define MMC_CAP2_NO_MULTI_READ (1 << 3) /* Multiblock reads don't work */ +#define MMC_CAP2_BKOPS (1 << 4)/* BKOPS supported */ mmc_pm_flag_t
pm_caps; /* supported pm features */ unsigned int power_notify_type;include/linux/mmc/mmc.h +14
-1@@ -138,6 +138,7 @@ static inline bool mmc_op_multi(u32 opcode) #define R1_CURRENT_STATE(x) ((x & 0x00001E00) >> 9) /* sx, b (4 bits) */ #define R1_READY_FOR_DATA (1 << 8) /* sx, a */ #define R1_SWITCH_ERROR (1 << 7) /* sx, c */ +#define R1_EXCEPTION_EVENT (1 << 6)/* sx, a */ #define R1_APP_CMD (1 << 5) /* sr, c */ #define R1_STATE_IDLE 0@@ -273,11 +274,14 @@ struct _mmc_csd { #define EXT_CSD_FLUSH_CACHE 32 /* W */ #define EXT_CSD_CACHE_CTRL 33 /* R/W */ #define EXT_CSD_POWER_OFF_NOTIFICATION 34 /* R/W */ +#define EXT_CSD_EXCEPTION_STATUS 54/* RO */ #define EXT_CSD_GP_SIZE_MULT 143 /* R/W */ #define EXT_CSD_PARTITION_ATTRIBUTE 156 /* R/W */ #define EXT_CSD_PARTITION_SUPPORT 160 /* RO */ #define EXT_CSD_HPI_MGMT 161 /* R/W */ #define EXT_CSD_RST_N_FUNCTION 162 /* R/W */ +#define EXT_CSD_BKOPS_EN 163/* R/W */ +#define EXT_CSD_BKOPS_START 164/* W */ #define EXT_CSD_SANITIZE_START 165 /* W */ #define EXT_CSD_WR_REL_PARAM 166 /* RO */ #define EXT_CSD_ERASE_GROUP_DEF 175 /* R/W */@@ -310,9 +314,11 @@ struct _mmc_csd { #define EXT_CSD_PWR_CL_200_360 237 /* RO */ #define EXT_CSD_PWR_CL_DDR_52_195 238 /* RO */ #define EXT_CSD_PWR_CL_DDR_52_360 239 /* RO */ +#define EXT_CSD_BKOPS_STATUS 246/* RO */ #define EXT_CSD_POWER_OFF_LONG_TIME 247 /* RO */ #define EXT_CSD_GENERIC_CMD6_TIME 248 /* RO */ #define EXT_CSD_CACHE_SIZE 249 /* RO, 4 bytes */ +#define EXT_CSD_BKOPS_SUPPORT 502/* RO */ #define EXT_CSD_HPI_FEATURES 503 /* RO */ /*@@ -373,4 +379,12 @@ struct _mmc_csd { #define MMC_SWITCH_MODE_CLEAR_BITS 0x02 /* Clear bits which are 1 in value */ #define MMC_SWITCH_MODE_WRITE_BYTE 0x03 /* Set target to value */ +/* +* EXCEPTION_EVENT_STATUS field (eMMC4.5) +*/ +#define EXT_CSD_URGENT_BKOPS BIT(0) +#define EXT_CSD_DYNCAP_NEEDED BIT(1) +#define EXT_CSD_SYSPOOL_EXHAUSTED BIT(2) +#define EXT_CSD_PACKED_FAILURE BIT(3) + #endif /* LINUX_MMC_MMC_H */ --Quoted 4 lines
To unsubscribe from this list: send the line "unsubscribe linux-mmc" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.htmlRegards,
Per
--
To unsubscribe from this list: send the line "unsubscribe linux-mmc" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Hi Jaehoon,
Quoted 113 lines · Jae hoon Chung
Hi Per.
2011/11/5 Per Forlin <[email protected]>:
Quoted 98 lines
Hi Jaehoon,
Quoted 94 lines · Jaehoon Chung
Enable eMMC background operations (BKOPS) feature.
If
URGENT_BKOPSis set after a response, note that BKOPS are required. After all I/O requests are finished, run BKOPS if required. Should read/write operations be requested during BKOPS, first issue HPI to interrupt the ongoing BKOPS and then service the request.If you want to enable this feature, set
MMC_CAP2_BKOPS.Signed-off-by Jaehoon Chung <[email protected]>Signed-off-by Kyungmin Park <[email protected]>CC Hanumath Prasad <[email protected]>---
Changelog V2:
- UseEXCEPTION_STATUSinstead ofURGENT_BKOPS
- Add function to checkException_status(for eMMC4.5)
- remove unnecessary code.drivers/mmc/card/block.c | 9 +++++
drivers/mmc/card/queue.c | 4 ++
drivers/mmc/core/core.c | 87 ++++++++++++++++++++++++++++++++++++++++++++drivers/mmc/core/mmc.c| 9 ++++-drivers/mmc/core/mmc_ops.c| 4 ++include/linux/mmc/card.h | 12 ++++++ include/linux/mmc/core.h | 3 ++ include/linux/mmc/host.h | 1 + include/linux/mmc/mmc.h | 14 +++++++ 9 files changed, 142 insertions(+), 1 deletions(-)drivers/mmc/card/block.c +0
-0@@ -1192,6 +1192,15 @@ static int mmc_blk_issue_rw_rq(struct mmc_queue *mq, struct request *rqc)case
MMC_BLK_SUCCESS:
caseMMC_BLK_PARTIAL:
/*
+ * Check BKOPS urgency from each R1 response
+ */
+ if (mmc_card_mmc(card)&&
+ (brq->cmd.resp[0] &R1_EXCEPTION_EVENT)) {
+ if (mmc_is_exception_event(card,
+EXT_CSD_URGENT_BKOPS))
+mmc_card_set_need_bkops(card);
+ }
+ /*
* A block was successfully transferred. */
mmc_blk_reset_success(md, type);drivers/mmc/card/queue.c +4
-0@@ -61,6 +61,9 @@ static int mmc_queue_thread(void *d) spin_unlock_irq(q->queue_lock); if (req || mq->mqrq_prev->req) { + if (mmc_card_doing_bkops(mq->card)) + mmc_interrupt_bkops(mq->card); + set_current_state(TASK_RUNNING); mq->issue_fn(mq, req); } else {@@ -68,6 +71,7 @@ static int mmc_queue_thread(void *d) set_current_state(TASK_RUNNING); break; } + mmc_start_bkops(mq->card); up(&mq->thread_sem); schedule(); down(&mq->thread_sem);drivers/mmc/core/core.c +13
-0@@ -238,6 +238,50 @@ mmc_start_request(struct mmc_host *host, struct mmc_request *mrq) host->ops->request(host, mrq); } +/** +* mmc_start_bkops - start BKOPS for supported cards +* @card: MMC card to start BKOPS +* +* Start background operations whenever requested. +* when the urgent BKOPS bit is set in a R1 command response +* then background operations should be started immediately. +*/ +void mmc_start_bkops (struct mmc_card *card) +{ + int err; + unsigned long flags; +Quoted 2 lines
drivers/mmc/core/core.c mmc_start_request(struct mmc_host *host, struct mmc_request *mrq) · line 254
Quoted 1 line
drivers/mmc/core/core.c +1
-0+ card->host->caps2 |= MMC_CAP2_BKOPS;I guess this should be set by the host driver?
You're right...it's my mistake...i will remove this..
Quoted 9 lines
drivers/mmc/core/core.c mmc_start_request(struct mmc_host *host, struct mmc_request *mrq) · line 256
Quoted 3 lines
drivers/mmc/core/core.c +2
-0+ if ((!card || !card->ext_csd.bkops_en) && + !(card->host->caps2 & MMC_CAP2_BKOPS))I don't really understand this. If card is NULL it will seg-fault.
Do you mean:
if (!card)
return
Quoted 6 lines
Quoted 5 lines
if (!card->ext_csd.bkops_en ||
!(card->host->caps2 &MMC_CAP2_BKOPS))
returnDo you really need to check card != NULL? Consider
BUG_ONMaybe if (!card && !card->ext_csd.bkops_en) is correctly...i think...
If card is NULL it will seg-fault.
Did you mean: if (card && !card->ext_csd.bkops_en)
I would suggest.
# return if card is NULL if (!card) return
# if card is set, check the values. if (!card->ext_csd.bkops_en || !(card->host->caps2 & MMC_CAP2_BKOPS)) return
Quoted 89 lines
Quoted 89 lines
Quoted 89 lines
drivers/mmc/core/core.c +71
-0+ return; + + /* + * If card is already doing bkops or need for + * bkops flag is not set, then do nothing just + * return + */ + if (mmc_card_doing_bkops(card) + || !mmc_card_need_bkops(card)) + return; + + mmc_claim_host(card->host); + err = mmc_switch(card, EXT_CSD_CMD_SET_NORMAL, + EXT_CSD_BKOPS_START, 1, 0); + if (err) { + pr_warning("error %d starting bkops\n", err); + mmc_card_clr_need_bkops(card); + goto out; + } + spin_lock_irqsave(&card->host->lock, flags); + mmc_card_clr_need_bkops(card); + mmc_card_set_doing_bkops(card); + spin_unlock_irqrestore(&card->host->lock, flags); +out: + mmc_release_host(card->host); +} +EXPORT_SYMBOL (mmc_start_bkops); + static void mmc_wait_done(struct mmc_request *mrq) { complete(&mrq->completion);@@ -466,6 +510,49 @@ int mmc_wait_for_cmd(struct mmc_host *host, struct mmc_command *cmd, int retries EXPORT_SYMBOL(mmc_wait_for_cmd); /** +* mmc_interrupt_bkops - interrupt ongoing BKOPS +* @card: MMC card to check BKOPS +* +* Send HPI command to interrupt ongoing background operations, +* to allow rapid servicing of foreground operations,e.g. read/ +* writes. Wait until the card comes out of the programming state +* to avoid errors in servicing read/write requests. +*/ +int mmc_interrupt_bkops (struct mmc_card *card) +{ + int err = 0; + unsigned long flags; + + BUG_ON(!card); + + err = mmc_interrupt_hpi(card); + + spin_lock_irqsave(&card->host->lock, flags); + mmc_card_clr_doing_bkops(card); + spin_unlock_irqrestore(&card->host->lock, flags); + + return err; +} +EXPORT_SYMBOL (mmc_interrupt_bkops); + +int mmc_is_exception_event (struct mmc_card *card,unsigned int value) +{ + int err; + u8 ext_csd[512]; + + /* In eMMC 4.41, R1_EXCEPTION_EVENT is URGENT_BKOPS */ + if (card->ext_csd.rev == 5) + return 1; + + err = mmc_send_ext_csd(card, ext_csd); + if (err) + return err; + + return (ext_csd[EXT_CSD_EXCEPTION_STATUS] & value) ? 1 : 0; +} +EXPORT_SYMBOL (mmc_is_exception_event); + +/** * mmc_set_data_timeout - set the timeout for a data command * @data: data phase for command * @card: the MMC card associated with the data transfer drivers/mmc/core/mmc.c +0
-0@@ -448,6 +448,14 @@ static int mmc_read_ext_csd(struct mmc_card *card, u8 *ext_csd) }
Quoted 9 lines
Quoted 7 lines
drivers/mmc/core/mmc.c static int mmc_read_ext_csd(struct mmc_card *card, u8 *ext_csd) · line 454
Quoted 5 lines
drivers/mmc/core/mmc.c +4
-0if (card->ext_csd.rev >= 5) { + /* check whether the eMMC card support BKOPS */ + if (ext_csd[EXT_CSD_BKOPS_SUPPORT] & 0x1) { + card->ext_csd.bkops = 1; + card->ext_csd.bkops_en = 1;What if the card has not enabled bkops? This bit could be unset.
card->ext_csd.bkops_en= ext_csd[EXT_CSD_BKOPS_EN];When card is supported the bkops,
bkops_enbit is set by default...
How do you know if the bkops_en is really enabled in th ext_csd? It could be unset in the ext_csd, right?
Quoted 181 lines
Quoted 180 lines
Quoted 168 lines
drivers/mmc/core/mmc.c +4
-1+ card->ext_csd.raw_bkops_status = + ext_csd[EXT_CSD_BKOPS_STATUS]; + } + /* check whether the eMMC card supports HPI */ if (ext_csd[EXT_CSD_HPI_FEATURES] & 0x1) { card->ext_csd.hpi = 1;@@ -498,7 +506,6 @@ static inline void mmc_free_ext_csd(u8 *ext_csd) kfree(ext_csd); } - static int mmc_compare_ext_csds(struct mmc_card *card, unsigned bus_width) { u8 *bw_ext_csd;drivers/mmc/core/mmc_ops.c +4
-0@@ -398,6 +398,10 @@ int mmc_switch(struct mmc_card *card, u8 set, u8 index, u8 value, if (err) return err; + /* No need to check card status in case of BKOPS switch*/ + if (index == EXT_CSD_BKOPS_START) + return 0; + /* Must check status to be sure of no errors */ do { err = mmc_send_status(card, &status);include/linux/mmc/card.h +0
-0@@ -71,6 +71,8 @@ struct mmc_ext_csd {bool hpi_en; /* HPI enablebit */ bool hpi; /* HPI support bit */ unsigned int hpi_cmd; /* cmd used as HPI */
+ bool bkops; /* background support bit */
+ bool bkops_en; /* background enable bit */ u8 raw_partition_support; /* 160 */ u8 raw_erased_mem_count; /* 181 */ u8 raw_ext_csd_structure; /* 194 */include/linux/mmc/card.h +0
-0@@ -84,6 +86,7 @@ struct mmc_ext_csd {u8 raw_sec_erase_mult; /* 230 */ u8 raw_sec_feature_support;/* 231 */ u8 raw_trim_mult; /* 232 */
+ u8 raw_bkops_status; /* 246 */ u8 raw_sectors[4]; /* 212 - 4 bytes */unsigned int feature_support;
include/linux/mmc/card.h +2
-0@@ -206,6 +209,8 @@ struct mmc_card { #define MMC_STATE_HIGHSPEED_DDR (1<<4) /* card is in high speed mode */ #define MMC_STATE_ULTRAHIGHSPEED (1<<5) /* card is in ultra high speed mode */ #define MMC_CARD_SDXC (1<<6) /* card is SDXC */ +#define MMC_STATE_NEED_BKOPS (1<<7)/* card need to do BKOPS */ +#define MMC_STATE_DOING_BKOPS (1<<8)/* card is doing BKOPS */ unsigned int quirks; /* card quirks */
#defineMMC_QUIRK_LENIENT_FN0(1<<0) /* allow SDIO FN0 writes outside of the VS CCCR range */ #defineMMC_QUIRK_BLKSZ_FOR_BYTE_MODE(1<<1) /* usefunc->cur_blksize*/include/linux/mmc/card.h +7
-0@@ -365,6 +370,8 @@ static inline void __maybe_unused remove_quirk(struct mmc_card *card, int data) #define mmc_card_ddr_mode(c) ((c)->state & MMC_STATE_HIGHSPEED_DDR) #define mmc_sd_card_uhs(c) ((c)->state & MMC_STATE_ULTRAHIGHSPEED) #define mmc_card_ext_capacity(c) ((c)->state & MMC_CARD_SDXC) +#define mmc_card_need_bkops (c) ((c)->state & MMC_STATE_NEED_BKOPS) +#define mmc_card_doing_bkops (c) ((c)->state & MMC_STATE_DOING_BKOPS) #define mmc_card_set_present(c) ((c)->state |= MMC_STATE_PRESENT) #define mmc_card_set_readonly(c) ((c)->state |= MMC_STATE_READONLY)@@ -373,6 +380,11 @@ static inline void __maybe_unused remove_quirk(struct mmc_card *card, int data) #define mmc_card_set_ddr_mode(c) ((c)->state |= MMC_STATE_HIGHSPEED_DDR) #define mmc_sd_card_set_uhs(c) ((c)->state |= MMC_STATE_ULTRAHIGHSPEED) #define mmc_card_set_ext_capacity(c) ((c)->state |= MMC_CARD_SDXC) +#define mmc_card_set_need_bkops (c) ((c)->state |= MMC_STATE_NEED_BKOPS) +#define mmc_card_set_doing_bkops (c) ((c)->state |= MMC_STATE_DOING_BKOPS) + +#define mmc_card_clr_need_bkops (c) ((c)->state &= ~MMC_STATE_NEED_BKOPS) +#define mmc_card_clr_doing_bkops (c) ((c)->state &= ~MMC_STATE_DOING_BKOPS) /** Quirk add/remove for MMC products. include/linux/mmc/core.h +3
-0@@ -134,6 +134,8 @@ struct mmc_host; struct mmc_card; struct mmc_async_req; +extern int mmc_interrupt_bkops (struct mmc_card *); +extern int mmc_is_exception_event (struct mmc_card *,unsigned int ); extern struct mmc_async_req *mmc_start_req(struct mmc_host *, struct mmc_async_req *, int *); extern int mmc_interrupt_hpi(struct mmc_card *);@@ -163,6 +165,7 @@ extern int mmc_can_sanitize(struct mmc_card *card); extern int mmc_can_secure_erase_trim(struct mmc_card *card); extern int mmc_erase_group_aligned(struct mmc_card *card, unsigned int from, unsigned int nr); +extern void mmc_start_bkops (struct mmc_card *card); extern unsigned int mmc_calc_max_discard(struct mmc_card *card); extern int mmc_set_blocklen(struct mmc_card *card, unsigned int blocklen);include/linux/mmc/host.h +1
-0@@ -242,6 +242,7 @@ struct mmc_host { #define MMC_CAP2_CACHE_CTRL (1 << 1) /* Allow cache control */ #define MMC_CAP2_POWEROFF_NOTIFY (1 << 2) /* Notify poweroff supported */ #define MMC_CAP2_NO_MULTI_READ (1 << 3) /* Multiblock reads don't work */ +#define MMC_CAP2_BKOPS (1 << 4)/* BKOPS supported */ mmc_pm_flag_t
pm_caps; /* supported pm features */ unsigned int power_notify_type;include/linux/mmc/mmc.h +14
-1@@ -138,6 +138,7 @@ static inline bool mmc_op_multi(u32 opcode) #define R1_CURRENT_STATE(x) ((x & 0x00001E00) >> 9) /* sx, b (4 bits) */ #define R1_READY_FOR_DATA (1 << 8) /* sx, a */ #define R1_SWITCH_ERROR (1 << 7) /* sx, c */ +#define R1_EXCEPTION_EVENT (1 << 6)/* sx, a */ #define R1_APP_CMD (1 << 5) /* sr, c */ #define R1_STATE_IDLE 0@@ -273,11 +274,14 @@ struct _mmc_csd { #define EXT_CSD_FLUSH_CACHE 32 /* W */ #define EXT_CSD_CACHE_CTRL 33 /* R/W */ #define EXT_CSD_POWER_OFF_NOTIFICATION 34 /* R/W */ +#define EXT_CSD_EXCEPTION_STATUS 54/* RO */ #define EXT_CSD_GP_SIZE_MULT 143 /* R/W */ #define EXT_CSD_PARTITION_ATTRIBUTE 156 /* R/W */ #define EXT_CSD_PARTITION_SUPPORT 160 /* RO */ #define EXT_CSD_HPI_MGMT 161 /* R/W */ #define EXT_CSD_RST_N_FUNCTION 162 /* R/W */ +#define EXT_CSD_BKOPS_EN 163/* R/W */ +#define EXT_CSD_BKOPS_START 164/* W */ #define EXT_CSD_SANITIZE_START 165 /* W */ #define EXT_CSD_WR_REL_PARAM 166 /* RO */ #define EXT_CSD_ERASE_GROUP_DEF 175 /* R/W */@@ -310,9 +314,11 @@ struct _mmc_csd { #define EXT_CSD_PWR_CL_200_360 237 /* RO */ #define EXT_CSD_PWR_CL_DDR_52_195 238 /* RO */ #define EXT_CSD_PWR_CL_DDR_52_360 239 /* RO */ +#define EXT_CSD_BKOPS_STATUS 246/* RO */ #define EXT_CSD_POWER_OFF_LONG_TIME 247 /* RO */ #define EXT_CSD_GENERIC_CMD6_TIME 248 /* RO */ #define EXT_CSD_CACHE_SIZE 249 /* RO, 4 bytes */ +#define EXT_CSD_BKOPS_SUPPORT 502/* RO */ #define EXT_CSD_HPI_FEATURES 503 /* RO */ /*@@ -373,4 +379,12 @@ struct _mmc_csd { #define MMC_SWITCH_MODE_CLEAR_BITS 0x02 /* Clear bits which are 1 in value */ #define MMC_SWITCH_MODE_WRITE_BYTE 0x03 /* Set target to value */ +/* +* EXCEPTION_EVENT_STATUS field (eMMC4.5) +*/ +#define EXT_CSD_URGENT_BKOPS BIT(0) +#define EXT_CSD_DYNCAP_NEEDED BIT(1) +#define EXT_CSD_SYSPOOL_EXHAUSTED BIT(2) +#define EXT_CSD_PACKED_FAILURE BIT(3) + #endif /* LINUX_MMC_MMC_H */ --Quoted 4 lines
To unsubscribe from this list: send the line "unsubscribe linux-mmc" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.htmlRegards,
Per
--
To unsubscribe from this list: send the line "unsubscribe linux-mmc" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Quoted 19 lines · Per Forlin
Hi Jaehoon,
Quoted 16 lines · Jae hoon Chung
Hi Per.
2011/11/5 Per Forlin <[email protected]>:
Quoted 13 lines
Hi Jaehoon,
Quoted 10 lines · Jaehoon Chung
Enable eMMC background operations (BKOPS) feature.
If
URGENT_BKOPSis set after a response, note that BKOPS are required. After all I/O requests are finished, run BKOPS if required. Should read/write operations be requested during BKOPS, first issue HPI to interrupt the ongoing BKOPS and then service the request.If you want to enable this feature, set
MMC_CAP2_BKOPS.
I'm thinking if it's good to add something in this commit message about what has been proposed in this thread. The scope of this patch is good and any additional optimizations could be added separately later on.
Future considerations
* Check BKOPS_LEVEL=1 and start BKOPS in a preventive manner.
* Interrupt ongoing BKOPS before powering off the card.
Regards,
Per
Hi per.
2011/11/8 Per Forlin <[email protected]>:
Quoted 126 lines
Hi Jaehoon,
Quoted 113 lines · Jae hoon Chung
Hi Per.
2011/11/5 Per Forlin <[email protected]>:
Quoted 98 lines
Hi Jaehoon,
Quoted 94 lines · Jaehoon Chung
Enable eMMC background operations (BKOPS) feature.
If
URGENT_BKOPSis set after a response, note that BKOPS are required. After all I/O requests are finished, run BKOPS if required. Should read/write operations be requested during BKOPS, first issue HPI to interrupt the ongoing BKOPS and then service the request.If you want to enable this feature, set
MMC_CAP2_BKOPS.Signed-off-by Jaehoon Chung <[email protected]>Signed-off-by Kyungmin Park <[email protected]>CC Hanumath Prasad <[email protected]>---
Changelog V2:
- UseEXCEPTION_STATUSinstead ofURGENT_BKOPS
- Add function to checkException_status(for eMMC4.5)
- remove unnecessary code.drivers/mmc/card/block.c | 9 +++++
drivers/mmc/card/queue.c | 4 ++
drivers/mmc/core/core.c | 87 ++++++++++++++++++++++++++++++++++++++++++++drivers/mmc/core/mmc.c| 9 ++++-drivers/mmc/core/mmc_ops.c| 4 ++include/linux/mmc/card.h | 12 ++++++ include/linux/mmc/core.h | 3 ++ include/linux/mmc/host.h | 1 + include/linux/mmc/mmc.h | 14 +++++++ 9 files changed, 142 insertions(+), 1 deletions(-)drivers/mmc/card/block.c +0
-0@@ -1192,6 +1192,15 @@ static int mmc_blk_issue_rw_rq(struct mmc_queue *mq, struct request *rqc)case
MMC_BLK_SUCCESS:
caseMMC_BLK_PARTIAL:
/*
+ * Check BKOPS urgency from each R1 response
+ */
+ if (mmc_card_mmc(card)&&
+ (brq->cmd.resp[0] &R1_EXCEPTION_EVENT)) {
+ if (mmc_is_exception_event(card,
+EXT_CSD_URGENT_BKOPS))
+mmc_card_set_need_bkops(card);
+ }
+ /*
* A block was successfully transferred. */
mmc_blk_reset_success(md, type);drivers/mmc/card/queue.c +4
-0@@ -61,6 +61,9 @@ static int mmc_queue_thread(void *d) spin_unlock_irq(q->queue_lock); if (req || mq->mqrq_prev->req) { + if (mmc_card_doing_bkops(mq->card)) + mmc_interrupt_bkops(mq->card); + set_current_state(TASK_RUNNING); mq->issue_fn(mq, req); } else {@@ -68,6 +71,7 @@ static int mmc_queue_thread(void *d) set_current_state(TASK_RUNNING); break; } + mmc_start_bkops(mq->card); up(&mq->thread_sem); schedule(); down(&mq->thread_sem);drivers/mmc/core/core.c +13
-0@@ -238,6 +238,50 @@ mmc_start_request(struct mmc_host *host, struct mmc_request *mrq) host->ops->request(host, mrq); } +/** +* mmc_start_bkops - start BKOPS for supported cards +* @card: MMC card to start BKOPS +* +* Start background operations whenever requested. +* when the urgent BKOPS bit is set in a R1 command response +* then background operations should be started immediately. +*/ +void mmc_start_bkops (struct mmc_card *card) +{ + int err; + unsigned long flags; +Quoted 2 lines
drivers/mmc/core/core.c mmc_start_request(struct mmc_host *host, struct mmc_request *mrq) · line 254
Quoted 1 line
drivers/mmc/core/core.c +1
-0+ card->host->caps2 |= MMC_CAP2_BKOPS;I guess this should be set by the host driver?
You're right...it's my mistake...i will remove this..
Quoted 9 lines
drivers/mmc/core/core.c mmc_start_request(struct mmc_host *host, struct mmc_request *mrq) · line 256
Quoted 3 lines
drivers/mmc/core/core.c +2
-0+ if ((!card || !card->ext_csd.bkops_en) && + !(card->host->caps2 & MMC_CAP2_BKOPS))I don't really understand this. If card is NULL it will seg-fault.
Do you mean:
if (!card)
returnQuoted 6 lines
Quoted 5 lines
if (!card->ext_csd.bkops_en ||
!(card->host->caps2 &MMC_CAP2_BKOPS))
returnDo you really need to check card != NULL? Consider
BUG_ONMaybe if (!card && !card->ext_csd.bkops_en) is correctly...i think...
If card is NULL it will seg-fault.
Did you mean: if (card && !card->ext_csd.bkops_en)I would suggest.
Quoted 9 lines
# return if card is NULL if (!card) return# if card is set, check the values. if (!card->ext_csd.bkops_en || !(card->host->caps2 & MMC_CAP2_BKOPS)) return
You're right...i will use BUGON()...and modify for ext_bkops_en checking
Quoted 97 lines
Quoted 97 lines
Quoted 97 lines
Quoted 88 lines
drivers/mmc/core/core.c +71
-0+ return; + + /* + * If card is already doing bkops or need for + * bkops flag is not set, then do nothing just + * return + */ + if (mmc_card_doing_bkops(card) + || !mmc_card_need_bkops(card)) + return; + + mmc_claim_host(card->host); + err = mmc_switch(card, EXT_CSD_CMD_SET_NORMAL, + EXT_CSD_BKOPS_START, 1, 0); + if (err) { + pr_warning("error %d starting bkops\n", err); + mmc_card_clr_need_bkops(card); + goto out; + } + spin_lock_irqsave(&card->host->lock, flags); + mmc_card_clr_need_bkops(card); + mmc_card_set_doing_bkops(card); + spin_unlock_irqrestore(&card->host->lock, flags); +out: + mmc_release_host(card->host); +} +EXPORT_SYMBOL (mmc_start_bkops); + static void mmc_wait_done(struct mmc_request *mrq) { complete(&mrq->completion);@@ -466,6 +510,49 @@ int mmc_wait_for_cmd(struct mmc_host *host, struct mmc_command *cmd, int retries EXPORT_SYMBOL(mmc_wait_for_cmd); /** +* mmc_interrupt_bkops - interrupt ongoing BKOPS +* @card: MMC card to check BKOPS +* +* Send HPI command to interrupt ongoing background operations, +* to allow rapid servicing of foreground operations,e.g. read/ +* writes. Wait until the card comes out of the programming state +* to avoid errors in servicing read/write requests. +*/ +int mmc_interrupt_bkops (struct mmc_card *card) +{ + int err = 0; + unsigned long flags; + + BUG_ON(!card); + + err = mmc_interrupt_hpi(card); + + spin_lock_irqsave(&card->host->lock, flags); + mmc_card_clr_doing_bkops(card); + spin_unlock_irqrestore(&card->host->lock, flags); + + return err; +} +EXPORT_SYMBOL (mmc_interrupt_bkops); + +int mmc_is_exception_event (struct mmc_card *card,unsigned int value) +{ + int err; + u8 ext_csd[512]; + + /* In eMMC 4.41, R1_EXCEPTION_EVENT is URGENT_BKOPS */ + if (card->ext_csd.rev == 5) + return 1; + + err = mmc_send_ext_csd(card, ext_csd); + if (err) + return err; + + return (ext_csd[EXT_CSD_EXCEPTION_STATUS] & value) ? 1 : 0; +} +EXPORT_SYMBOL (mmc_is_exception_event); + +/** * mmc_set_data_timeout - set the timeout for a data command * @data: data phase for command * @card: the MMC card associated with the data transfer drivers/mmc/core/mmc.c +0
-0drivers/mmc/core/mmc.c static int mmc_read_ext_csd(struct mmc_card *card, u8 *ext_csd) · line 454
Quoted 7 lines
drivers/mmc/core/mmc.c +4
-0@@ -448,6 +448,14 @@ static int mmc_read_ext_csd(struct mmc_card *card, u8 *ext_csd) } if (card->ext_csd.rev >= 5) { + /* check whether the eMMC card support BKOPS */ + if (ext_csd[EXT_CSD_BKOPS_SUPPORT] & 0x1) { + card->ext_csd.bkops = 1; + card->ext_csd.bkops_en = 1;What if the card has not enabled bkops? This bit could be unset.
card->ext_csd.bkops_en= ext_csd[EXT_CSD_BKOPS_EN];
Quoted 4 lines
Quoted 2 lines
When card is supported the bkops,
bkops_enbit is set by default...How do you know if the
bkops_enis really enabled in thext_csd? It could be unset in theext_csd, right?
In emmc4.5 spec, if card is supported the bkops, bkops_en is set by default. So i didn't assign ext_csd[EXT_CSD_BKOPS_EN], because maybe should be set by defalut
when is supported the bkops. if i think wrong, plz let me know.
Best Regards,
Jaehoon Chung
Quoted 183 lines
Quoted 182 lines
Quoted 181 lines
Quoted 169 lines
drivers/mmc/core/mmc.c +4
-1+ card->ext_csd.raw_bkops_status = + ext_csd[EXT_CSD_BKOPS_STATUS]; + } + /* check whether the eMMC card supports HPI */ if (ext_csd[EXT_CSD_HPI_FEATURES] & 0x1) { card->ext_csd.hpi = 1;@@ -498,7 +506,6 @@ static inline void mmc_free_ext_csd(u8 *ext_csd) kfree(ext_csd); } - static int mmc_compare_ext_csds(struct mmc_card *card, unsigned bus_width) { u8 *bw_ext_csd;drivers/mmc/core/mmc_ops.c +4
-0@@ -398,6 +398,10 @@ int mmc_switch(struct mmc_card *card, u8 set, u8 index, u8 value, if (err) return err; + /* No need to check card status in case of BKOPS switch*/ + if (index == EXT_CSD_BKOPS_START) + return 0; + /* Must check status to be sure of no errors */ do { err = mmc_send_status(card, &status);include/linux/mmc/card.h +0
-0@@ -71,6 +71,8 @@ struct mmc_ext_csd {bool hpi_en; /* HPI enablebit */ bool hpi; /* HPI support bit */ unsigned int hpi_cmd; /* cmd used as HPI */
+ bool bkops; /* background support bit */
+ bool bkops_en; /* background enable bit */ u8 raw_partition_support; /* 160 */ u8 raw_erased_mem_count; /* 181 */ u8 raw_ext_csd_structure; /* 194 */include/linux/mmc/card.h +0
-0@@ -84,6 +86,7 @@ struct mmc_ext_csd {u8 raw_sec_erase_mult; /* 230 */ u8 raw_sec_feature_support;/* 231 */ u8 raw_trim_mult; /* 232 */
+ u8 raw_bkops_status; /* 246 */ u8 raw_sectors[4]; /* 212 - 4 bytes */unsigned int feature_support;
include/linux/mmc/card.h +2
-0@@ -206,6 +209,8 @@ struct mmc_card { #define MMC_STATE_HIGHSPEED_DDR (1<<4) /* card is in high speed mode */ #define MMC_STATE_ULTRAHIGHSPEED (1<<5) /* card is in ultra high speed mode */ #define MMC_CARD_SDXC (1<<6) /* card is SDXC */ +#define MMC_STATE_NEED_BKOPS (1<<7)/* card need to do BKOPS */ +#define MMC_STATE_DOING_BKOPS (1<<8)/* card is doing BKOPS */ unsigned int quirks; /* card quirks */
#defineMMC_QUIRK_LENIENT_FN0(1<<0) /* allow SDIO FN0 writes outside of the VS CCCR range */ #defineMMC_QUIRK_BLKSZ_FOR_BYTE_MODE(1<<1) /* usefunc->cur_blksize*/include/linux/mmc/card.h +7
-0@@ -365,6 +370,8 @@ static inline void __maybe_unused remove_quirk(struct mmc_card *card, int data) #define mmc_card_ddr_mode(c) ((c)->state & MMC_STATE_HIGHSPEED_DDR) #define mmc_sd_card_uhs(c) ((c)->state & MMC_STATE_ULTRAHIGHSPEED) #define mmc_card_ext_capacity(c) ((c)->state & MMC_CARD_SDXC) +#define mmc_card_need_bkops (c) ((c)->state & MMC_STATE_NEED_BKOPS) +#define mmc_card_doing_bkops (c) ((c)->state & MMC_STATE_DOING_BKOPS) #define mmc_card_set_present(c) ((c)->state |= MMC_STATE_PRESENT) #define mmc_card_set_readonly(c) ((c)->state |= MMC_STATE_READONLY)@@ -373,6 +380,11 @@ static inline void __maybe_unused remove_quirk(struct mmc_card *card, int data) #define mmc_card_set_ddr_mode(c) ((c)->state |= MMC_STATE_HIGHSPEED_DDR) #define mmc_sd_card_set_uhs(c) ((c)->state |= MMC_STATE_ULTRAHIGHSPEED) #define mmc_card_set_ext_capacity(c) ((c)->state |= MMC_CARD_SDXC) +#define mmc_card_set_need_bkops (c) ((c)->state |= MMC_STATE_NEED_BKOPS) +#define mmc_card_set_doing_bkops (c) ((c)->state |= MMC_STATE_DOING_BKOPS) + +#define mmc_card_clr_need_bkops (c) ((c)->state &= ~MMC_STATE_NEED_BKOPS) +#define mmc_card_clr_doing_bkops (c) ((c)->state &= ~MMC_STATE_DOING_BKOPS) /** Quirk add/remove for MMC products. include/linux/mmc/core.h +3
-0@@ -134,6 +134,8 @@ struct mmc_host; struct mmc_card; struct mmc_async_req; +extern int mmc_interrupt_bkops (struct mmc_card *); +extern int mmc_is_exception_event (struct mmc_card *,unsigned int ); extern struct mmc_async_req *mmc_start_req(struct mmc_host *, struct mmc_async_req *, int *); extern int mmc_interrupt_hpi(struct mmc_card *);@@ -163,6 +165,7 @@ extern int mmc_can_sanitize(struct mmc_card *card); extern int mmc_can_secure_erase_trim(struct mmc_card *card); extern int mmc_erase_group_aligned(struct mmc_card *card, unsigned int from, unsigned int nr); +extern void mmc_start_bkops (struct mmc_card *card); extern unsigned int mmc_calc_max_discard(struct mmc_card *card); extern int mmc_set_blocklen(struct mmc_card *card, unsigned int blocklen);include/linux/mmc/host.h +1
-0@@ -242,6 +242,7 @@ struct mmc_host { #define MMC_CAP2_CACHE_CTRL (1 << 1) /* Allow cache control */ #define MMC_CAP2_POWEROFF_NOTIFY (1 << 2) /* Notify poweroff supported */ #define MMC_CAP2_NO_MULTI_READ (1 << 3) /* Multiblock reads don't work */ +#define MMC_CAP2_BKOPS (1 << 4)/* BKOPS supported */ mmc_pm_flag_t
pm_caps; /* supported pm features */ unsigned int power_notify_type;include/linux/mmc/mmc.h +14
-1@@ -138,6 +138,7 @@ static inline bool mmc_op_multi(u32 opcode) #define R1_CURRENT_STATE(x) ((x & 0x00001E00) >> 9) /* sx, b (4 bits) */ #define R1_READY_FOR_DATA (1 << 8) /* sx, a */ #define R1_SWITCH_ERROR (1 << 7) /* sx, c */ +#define R1_EXCEPTION_EVENT (1 << 6)/* sx, a */ #define R1_APP_CMD (1 << 5) /* sr, c */ #define R1_STATE_IDLE 0@@ -273,11 +274,14 @@ struct _mmc_csd { #define EXT_CSD_FLUSH_CACHE 32 /* W */ #define EXT_CSD_CACHE_CTRL 33 /* R/W */ #define EXT_CSD_POWER_OFF_NOTIFICATION 34 /* R/W */ +#define EXT_CSD_EXCEPTION_STATUS 54/* RO */ #define EXT_CSD_GP_SIZE_MULT 143 /* R/W */ #define EXT_CSD_PARTITION_ATTRIBUTE 156 /* R/W */ #define EXT_CSD_PARTITION_SUPPORT 160 /* RO */ #define EXT_CSD_HPI_MGMT 161 /* R/W */ #define EXT_CSD_RST_N_FUNCTION 162 /* R/W */ +#define EXT_CSD_BKOPS_EN 163/* R/W */ +#define EXT_CSD_BKOPS_START 164/* W */ #define EXT_CSD_SANITIZE_START 165 /* W */ #define EXT_CSD_WR_REL_PARAM 166 /* RO */ #define EXT_CSD_ERASE_GROUP_DEF 175 /* R/W */@@ -310,9 +314,11 @@ struct _mmc_csd { #define EXT_CSD_PWR_CL_200_360 237 /* RO */ #define EXT_CSD_PWR_CL_DDR_52_195 238 /* RO */ #define EXT_CSD_PWR_CL_DDR_52_360 239 /* RO */ +#define EXT_CSD_BKOPS_STATUS 246/* RO */ #define EXT_CSD_POWER_OFF_LONG_TIME 247 /* RO */ #define EXT_CSD_GENERIC_CMD6_TIME 248 /* RO */ #define EXT_CSD_CACHE_SIZE 249 /* RO, 4 bytes */ +#define EXT_CSD_BKOPS_SUPPORT 502/* RO */ #define EXT_CSD_HPI_FEATURES 503 /* RO */ /*@@ -373,4 +379,12 @@ struct _mmc_csd { #define MMC_SWITCH_MODE_CLEAR_BITS 0x02 /* Clear bits which are 1 in value */ #define MMC_SWITCH_MODE_WRITE_BYTE 0x03 /* Set target to value */ +/* +* EXCEPTION_EVENT_STATUS field (eMMC4.5) +*/ +#define EXT_CSD_URGENT_BKOPS BIT(0) +#define EXT_CSD_DYNCAP_NEEDED BIT(1) +#define EXT_CSD_SYSPOOL_EXHAUSTED BIT(2) +#define EXT_CSD_PACKED_FAILURE BIT(3) + #endif /* LINUX_MMC_MMC_H */ --Quoted 4 lines
To unsubscribe from this list: send the line "unsubscribe linux-mmc" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.htmlRegards,
Per
--
To unsubscribe from this list: send the line "unsubscribe linux-mmc" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Quoted 236 lines · Jae hoon Chung
Hi per.
2011/11/8 Per Forlin <[email protected]>:
Quoted 126 lines
Hi Jaehoon,
Quoted 113 lines · Jae hoon Chung
Hi Per.
2011/11/5 Per Forlin <[email protected]>:
Quoted 98 lines
Hi Jaehoon,
Quoted 94 lines · Jaehoon Chung
Enable eMMC background operations (BKOPS) feature.
If
URGENT_BKOPSis set after a response, note that BKOPS are required. After all I/O requests are finished, run BKOPS if required. Should read/write operations be requested during BKOPS, first issue HPI to interrupt the ongoing BKOPS and then service the request.If you want to enable this feature, set
MMC_CAP2_BKOPS.Signed-off-by Jaehoon Chung <[email protected]>Signed-off-by Kyungmin Park <[email protected]>CC Hanumath Prasad <[email protected]>---
Changelog V2:
- UseEXCEPTION_STATUSinstead ofURGENT_BKOPS
- Add function to checkException_status(for eMMC4.5)
- remove unnecessary code.drivers/mmc/card/block.c | 9 +++++
drivers/mmc/card/queue.c | 4 ++
drivers/mmc/core/core.c | 87 ++++++++++++++++++++++++++++++++++++++++++++drivers/mmc/core/mmc.c| 9 ++++-drivers/mmc/core/mmc_ops.c| 4 ++include/linux/mmc/card.h | 12 ++++++ include/linux/mmc/core.h | 3 ++ include/linux/mmc/host.h | 1 + include/linux/mmc/mmc.h | 14 +++++++ 9 files changed, 142 insertions(+), 1 deletions(-)drivers/mmc/card/block.c +0
-0@@ -1192,6 +1192,15 @@ static int mmc_blk_issue_rw_rq(struct mmc_queue *mq, struct request *rqc)case
MMC_BLK_SUCCESS:
caseMMC_BLK_PARTIAL:
/*
+ * Check BKOPS urgency from each R1 response
+ */
+ if (mmc_card_mmc(card)&&
+ (brq->cmd.resp[0] &R1_EXCEPTION_EVENT)) {
+ if (mmc_is_exception_event(card,
+EXT_CSD_URGENT_BKOPS))
+mmc_card_set_need_bkops(card);
+ }
+ /*
* A block was successfully transferred. */
mmc_blk_reset_success(md, type);drivers/mmc/card/queue.c +4
-0@@ -61,6 +61,9 @@ static int mmc_queue_thread(void *d) spin_unlock_irq(q->queue_lock); if (req || mq->mqrq_prev->req) { + if (mmc_card_doing_bkops(mq->card)) + mmc_interrupt_bkops(mq->card); + set_current_state(TASK_RUNNING); mq->issue_fn(mq, req); } else {@@ -68,6 +71,7 @@ static int mmc_queue_thread(void *d) set_current_state(TASK_RUNNING); break; } + mmc_start_bkops(mq->card); up(&mq->thread_sem); schedule(); down(&mq->thread_sem);drivers/mmc/core/core.c +13
-0@@ -238,6 +238,50 @@ mmc_start_request(struct mmc_host *host, struct mmc_request *mrq) host->ops->request(host, mrq); } +/** +* mmc_start_bkops - start BKOPS for supported cards +* @card: MMC card to start BKOPS +* +* Start background operations whenever requested. +* when the urgent BKOPS bit is set in a R1 command response +* then background operations should be started immediately. +*/ +void mmc_start_bkops (struct mmc_card *card) +{ + int err; + unsigned long flags; +Quoted 2 lines
drivers/mmc/core/core.c mmc_start_request(struct mmc_host *host, struct mmc_request *mrq) · line 254
Quoted 1 line
drivers/mmc/core/core.c +1
-0+ card->host->caps2 |= MMC_CAP2_BKOPS;I guess this should be set by the host driver?
You're right...it's my mistake...i will remove this..
Quoted 9 lines
drivers/mmc/core/core.c mmc_start_request(struct mmc_host *host, struct mmc_request *mrq) · line 256
Quoted 3 lines
drivers/mmc/core/core.c +2
-0+ if ((!card || !card->ext_csd.bkops_en) && + !(card->host->caps2 & MMC_CAP2_BKOPS))I don't really understand this. If card is NULL it will seg-fault.
Do you mean:
if (!card)
returnQuoted 6 lines
Quoted 5 lines
if (!card->ext_csd.bkops_en ||
!(card->host->caps2 &MMC_CAP2_BKOPS))
returnDo you really need to check card != NULL? Consider
BUG_ONMaybe if (!card && !card->ext_csd.bkops_en) is correctly...i think...
If card is NULL it will seg-fault.
Did you mean: if (card && !card->ext_csd.bkops_en)I would suggest.
Quoted 9 lines
# return if card is NULL if (!card) return# if card is set, check the values. if (!card->ext_csd.bkops_en || !(card->host->caps2 & MMC_CAP2_BKOPS)) returnYou're right...i will use BUGON()...and modify for
ext_bkops_encheckingQuoted 97 lines
Quoted 97 lines
Quoted 97 lines
Quoted 88 lines
drivers/mmc/core/core.c +71
-0+ return; + + /* + * If card is already doing bkops or need for + * bkops flag is not set, then do nothing just + * return + */ + if (mmc_card_doing_bkops(card) + || !mmc_card_need_bkops(card)) + return; + + mmc_claim_host(card->host); + err = mmc_switch(card, EXT_CSD_CMD_SET_NORMAL, + EXT_CSD_BKOPS_START, 1, 0); + if (err) { + pr_warning("error %d starting bkops\n", err); + mmc_card_clr_need_bkops(card); + goto out; + } + spin_lock_irqsave(&card->host->lock, flags); + mmc_card_clr_need_bkops(card); + mmc_card_set_doing_bkops(card); + spin_unlock_irqrestore(&card->host->lock, flags); +out: + mmc_release_host(card->host); +} +EXPORT_SYMBOL (mmc_start_bkops); + static void mmc_wait_done(struct mmc_request *mrq) { complete(&mrq->completion);@@ -466,6 +510,49 @@ int mmc_wait_for_cmd(struct mmc_host *host, struct mmc_command *cmd, int retries EXPORT_SYMBOL(mmc_wait_for_cmd); /** +* mmc_interrupt_bkops - interrupt ongoing BKOPS +* @card: MMC card to check BKOPS +* +* Send HPI command to interrupt ongoing background operations, +* to allow rapid servicing of foreground operations,e.g. read/ +* writes. Wait until the card comes out of the programming state +* to avoid errors in servicing read/write requests. +*/ +int mmc_interrupt_bkops (struct mmc_card *card) +{ + int err = 0; + unsigned long flags; + + BUG_ON(!card); + + err = mmc_interrupt_hpi(card); + + spin_lock_irqsave(&card->host->lock, flags); + mmc_card_clr_doing_bkops(card); + spin_unlock_irqrestore(&card->host->lock, flags); + + return err; +} +EXPORT_SYMBOL (mmc_interrupt_bkops); + +int mmc_is_exception_event (struct mmc_card *card,unsigned int value) +{ + int err; + u8 ext_csd[512]; + + /* In eMMC 4.41, R1_EXCEPTION_EVENT is URGENT_BKOPS */ + if (card->ext_csd.rev == 5) + return 1; + + err = mmc_send_ext_csd(card, ext_csd); + if (err) + return err; + + return (ext_csd[EXT_CSD_EXCEPTION_STATUS] & value) ? 1 : 0; +} +EXPORT_SYMBOL (mmc_is_exception_event); + +/** * mmc_set_data_timeout - set the timeout for a data command * @data: data phase for command * @card: the MMC card associated with the data transfer drivers/mmc/core/mmc.c +0
-0drivers/mmc/core/mmc.c static int mmc_read_ext_csd(struct mmc_card *card, u8 *ext_csd) · line 454
Quoted 7 lines
drivers/mmc/core/mmc.c +4
-0@@ -448,6 +448,14 @@ static int mmc_read_ext_csd(struct mmc_card *card, u8 *ext_csd) } if (card->ext_csd.rev >= 5) { + /* check whether the eMMC card support BKOPS */ + if (ext_csd[EXT_CSD_BKOPS_SUPPORT] & 0x1) { + card->ext_csd.bkops = 1; + card->ext_csd.bkops_en = 1;What if the card has not enabled bkops? This bit could be unset.
card->ext_csd.bkops_en= ext_csd[EXT_CSD_BKOPS_EN];
Quoted 6 lines
Quoted 4 lines
Quoted 2 lines
When card is supported the bkops,
bkops_enbit is set by default...How do you know if the
bkops_enis really enabled in thext_csd? It could be unset in theext_csd, right?In emmc4.5 spec, if card is supported the bkops,
bkops_enis set by default.
If bkops_en is set by default it should be in the the ext_csd too, right? It should be safer to trust the value of ext_csd[EXT_CSD_BKOPS_EN] in this case I think.
Regards,
Per
Hi Per
Quoted 10 lines
Quoted 10 lines
Quoted 10 lines
Quoted 10 lines
Quoted 8 lines
drivers/mmc/core/mmc.c static int mmc_read_ext_csd(struct mmc_card *card, u8 *ext_csd) · line 454
Quoted 6 lines
if (card->ext_csd.rev >= 5) {drivers/mmc/core/mmc.c +4
-0+/* check whether the eMMC card support BKOPS */ +if (ext_csd[EXT_CSD_BKOPS_SUPPORT ] &0x1 ) { + card->ext_csd.bkops =1 ; + card->ext_csd.bkops_en =1 ;What if the card has not enabled bkops? This bit could be unset.
card->ext_csd.bkops_en= ext_csd[EXT_CSD_BKOPS_EN];When card is supported the bkops,
bkops_enbit is set by default...
Quoted 7 lines
Quoted 4 lines
Quoted 2 lines
How do you know if the
bkops_enis really enabled in thext_csd? It could be unset in theext_csd, right?In emmc4.5 spec, if card is supported the bkops,
bkops_enis set by default.If
bkops_enis set by default it should be in the theext_csdtoo, right? It should be safer to trust the value of ext_csd[EXT_CSD_BKOPS_EN] in this case I think.
If we want to ensure whether bkops_en bit is set or not, your approach is right.
Best Regards,
Jaehoon Chung
Hello Jaehoon, Per
I have experimented with eMMC v4.41 card and BKOPS feature and want to add info on EXT_CSD_BKOPS_EN[163] field. See below.
Quoted 22 lines
Hi Per
Quoted 13 lines
Quoted 13 lines
Quoted 12 lines
Quoted 10 lines
Quoted 8 lines
Review
Quoted 6 lines
if (card->ext_csd.rev >= 5) {(quoted diff) +4
-0+ /* check whether the eMMC card support BKOPS */ + if (ext_csd[EXT_CSD_BKOPS_SUPPORT] & 0x1) { + card->ext_csd.bkops = 1; + card->ext_csd.bkops_en = 1;What if the card has not enabled bkops? This bit could be unset.
card->ext_csd.bkops_en= ext_csd[EXT_CSD_BKOPS_EN];When card is supported the bkops,
bkops_enbit is set by default...How do you know if the
bkops_enis really enabled in thext_csd? It could be unset in theext_csd, right?Quoted 6 lines
Quoted 2 lines
In emmc4.5 spec, if card is supported the bkops,
bkops_enis set by default.If
bkops_enis set by default it should be in the theext_csdtoo, right?
It should be safer to trust the value of ext_csd[EXT_CSD_BKOPS_EN] in this case I think.
Quoted 5 lines
If we want to ensure whether
bkops_enbit is set or not, your approach is right.Best Regards,
Jaehoon Chung
First of all protocol state:
------------------------------
7.4.57 BKOPS_EN [163]
This field allows the _host_ to indicate to the device if it is expected to periodically manually start background operations by writing to the BKOPS_START field.
...In order for the device to know if host is going to periodically start background operations, host shall set bit 0 of BKOPS_EN (EXT_CSD byte [163]) to indicate that it is going to write to BKOPS_START periodically. The device may then delay some of its maintenance operations to when host writes to BKOPS_START.
------------------------------
My card supports BKOPS (by reading Bit 0 of BKOPS_SUPPORT (EXT_CSD byte [502]), but BKOPS_EN[163] is not set. So I suppose, original code to set BKOPS_EN[163] is needed, otherwise card will never delay its maintenance operations.
Thanks,
Kostya
Hi Kostya
Quoted 47 lines · Konstantin Dorfman
Hello Jaehoon, Per
I have experimented with eMMC v4.41 card and BKOPS feature and want to add info on EXT_CSD_BKOPS_EN[163] field. See below.
Quoted 22 lines
Hi Per
Quoted 13 lines
Quoted 13 lines
Quoted 12 lines
Quoted 10 lines
Quoted 8 lines
Review
Quoted 6 lines
if (card->ext_csd.rev >= 5) {(quoted diff) +4
-0+ /* check whether the eMMC card support BKOPS */ + if (ext_csd[EXT_CSD_BKOPS_SUPPORT] & 0x1) { + card->ext_csd.bkops = 1; + card->ext_csd.bkops_en = 1;What if the card has not enabled bkops? This bit could be unset.
card->ext_csd.bkops_en= ext_csd[EXT_CSD_BKOPS_EN];When card is supported the bkops,
bkops_enbit is set by default...How do you know if the
bkops_enis really enabled in thext_csd? It could be unset in theext_csd, right?Quoted 6 lines
Quoted 2 lines
In emmc4.5 spec, if card is supported the bkops,
bkops_enis set by default.If
bkops_enis set by default it should be in the theext_csdtoo, right?
It should be safer to trust the value of ext_csd[EXT_CSD_BKOPS_EN] in this case I think.Quoted 5 lines
If we want to ensure whether
bkops_enbit is set or not, your approach is right.Best Regards,
Jaehoon ChungFirst of all protocol state:
------------------------------
7.4.57BKOPS_EN[163]
This field allows the _host_ to indicate to the device if it is expected to periodically manually start background operations by writing to theBKOPS_STARTfield....In order for the device to know if host is going to periodically start background operations, host shall set bit 0 of
BKOPS_EN(EXT_CSDbyte [163]) to indicate that it is going to write toBKOPS_STARTperiodically. The device may then delay some of its maintenance operations to when host writes toBKOPS_START.
------------------------------
Quoted 4 lines
My card supports BKOPS (by reading Bit 0 of
BKOPS_SUPPORT(EXT_CSDbyte [502]), but BKOPS_EN[163] is not set. So I suppose, original code to set BKOPS_EN[163] is needed, otherwise card will never delay its maintenance operations.
Ok...i will add the code for setting BKOPS_EN bit in patch-v4. Thanks,
Jaehoon Chung
Quoted 51 lines · Jaehoon Chung
Hi Kostya
Quoted 47 lines · Konstantin Dorfman
Hello Jaehoon, Per
I have experimented with eMMC v4.41 card and BKOPS feature and want to add info on EXT_CSD_BKOPS_EN[163] field. See below.
Quoted 22 lines
Hi Per
Quoted 13 lines
Quoted 13 lines
Quoted 12 lines
Quoted 10 lines
Quoted 8 lines
Review
Quoted 6 lines
if (card->ext_csd.rev >= 5) {(quoted diff) +4
-0+ /* check whether the eMMC card support BKOPS */ + if (ext_csd[EXT_CSD_BKOPS_SUPPORT] & 0x1) { + card->ext_csd.bkops = 1; + card->ext_csd.bkops_en = 1;What if the card has not enabled bkops? This bit could be unset.
card->ext_csd.bkops_en= ext_csd[EXT_CSD_BKOPS_EN];When card is supported the bkops,
bkops_enbit is set by default...How do you know if the
bkops_enis really enabled in thext_csd? It could be unset in theext_csd, right?Quoted 6 lines
Quoted 2 lines
In emmc4.5 spec, if card is supported the bkops,
bkops_enis set by default.If
bkops_enis set by default it should be in the theext_csdtoo, right?
It should be safer to trust the value of ext_csd[EXT_CSD_BKOPS_EN] in this case I think.Quoted 5 lines
If we want to ensure whether
bkops_enbit is set or not, your approach is right.Best Regards,
Jaehoon ChungFirst of all protocol state:
------------------------------
7.4.57BKOPS_EN[163]
This field allows the _host_ to indicate to the device if it is expected to periodically manually start background operations by writing to theBKOPS_STARTfield....In order for the device to know if host is going to periodically start background operations, host shall set bit 0 of
BKOPS_EN(EXT_CSDbyte [163]) to indicate that it is going to write toBKOPS_STARTperiodically. The device may then delay some of its maintenance operations to when host writes toBKOPS_START.
------------------------------
Quoted 7 lines
Quoted 4 lines
My card supports BKOPS (by reading Bit 0 of
BKOPS_SUPPORT(EXT_CSDbyte [502]), but BKOPS_EN[163] is not set. So I suppose, original code to set BKOPS_EN[163] is needed, otherwise card will never delay its maintenance operations.Ok...i will add the code for setting
BKOPS_ENbit in patch-v4.
I hope this features are provided from platform data. since it's not mandatory for all devices
Thank you,
Kyungmin Park
Quoted 7 lines
Thanks,
Jaehoon Chung
--
To unsubscribe from this list: send the line "unsubscribe linux-mmc" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Quoted 27 lines
Quoted 27 lines
Quoted 25 lines
First of all protocol state:
------------------------------
7.4.57BKOPS_EN[163]
This field allows the _host_ to indicate to the device if it is expected
to periodically manually start background operations by writing to theBKOPS_STARTfield....In order for the device to know if host is going to periodically start
background operations, host shall set bit 0 ofBKOPS_EN(EXT_CSDbyte [163]) to indicate that it is going to write toBKOPS_STARTperiodically.
The device may then delay some of its maintenance operations to when host
writes toBKOPS_START.
------------------------------My card supports BKOPS (by reading Bit 0 of
BKOPS_SUPPORT(EXT_CSDbyte [502]), but BKOPS_EN[163] is not set. So I suppose, original code to set
BKOPS_EN[163] is needed, otherwise card will never delay its maintenance
operations.
Quoted 3 lines
Quoted 1 line
Ok...i will add the code for setting
BKOPS_ENbit in patch-v4.I hope this features are provided from platform data. since it's not mandatory for all devices
This feature is mandatory for eMMC v4.5, but it may be enabled only when card supports BKOPS_SUPPORT[502] is set (and this one depend on device) Thanks,
Kostya
Hi Jaehoon,
Quoted 14 lines · Jaehoon Chung
Enable eMMC background operations (BKOPS) feature.
If
URGENT_BKOPSis set after a response, note that BKOPS are required. After all I/O requests are finished, run BKOPS if required. Should read/write operations be requested during BKOPS, first issue HPI to interrupt the ongoing BKOPS and then service the request.If you want to enable this feature, set
MMC_CAP2_BKOPS.Signed-off-by Jaehoon Chung <[email protected]>Signed-off-by Kyungmin Park <[email protected]>CC Hanumath Prasad <[email protected]>
Quoted 5 lines
---
Changelog V2:
- UseEXCEPTION_STATUSinstead ofURGENT_BKOPS
- Add function to checkException_status(for eMMC4.5)
- remove unnecessary code.
Will there be a V3 soon?
I have tested this patch with my minor changes on top and as far as I can tell it looks ok.
I'm ready to accept this patch if those minor updates are made in V3.
Thanks,
Per
Hi Per...
I wll send the patch v3 about next week.
Actually i didn't find how control about the level-1. In future,,we need to add this control at this patch.
Best regards,
Jaehoon Chung
2011/11/11 Per Forlin <[email protected]>:
Quoted 35 lines
Hi Jaehoon,
Quoted 14 lines · Jaehoon Chung
Enable eMMC background operations (BKOPS) feature.
If
URGENT_BKOPSis set after a response, note that BKOPS are required. After all I/O requests are finished, run BKOPS if required. Should read/write operations be requested during BKOPS, first issue HPI to interrupt the ongoing BKOPS and then service the request.If you want to enable this feature, set
MMC_CAP2_BKOPS.Signed-off-by Jaehoon Chung <[email protected]>Signed-off-by Kyungmin Park <[email protected]>CC Hanumath Prasad <[email protected]>Quoted 5 lines
---
Changelog V2:
- UseEXCEPTION_STATUSinstead ofURGENT_BKOPS
- Add function to checkException_status(for eMMC4.5)
- remove unnecessary code.Will there be a V3 soon?
I have tested this patch with my minor changes on top and as far as I can tell it looks ok.
I'm ready to accept this patch if those minor updates are made in V3.Thanks,
Per
--
To unsubscribe from this list: send the line "unsubscribe linux-mmc" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Hi Jaehoon,
Quoted 48 lines
-----Original Message-----
From: Jaehoon Chung [mailto:[email protected]]
Sent: Wednesday, November 02, 2011 6:29 PM
To: linux-mmc
Cc: Chris Ball; Kyungmin Park; Hanumath Prasad; Sebastian Rasmussen; Per Forlin; [email protected]; Dong, Chuanxiao
Subject: [PATCH v2] mmc: support BKOPS feature for eMMCEnable eMMC background operations (BKOPS) feature.
If
URGENT_BKOPSis set after a response, note that BKOPS are required. After all I/O requests are finished, run BKOPS if required. Should read/write operations be requested during BKOPS, first issue HPI to interrupt the ongoing BKOPS and then service the request.If you want to enable this feature, set
MMC_CAP2_BKOPS.Signed-off-by Jaehoon Chung <[email protected]>Signed-off-by Kyungmin Park <[email protected]>CC Hanumath Prasad <[email protected]>---
Changelog V2:
- UseEXCEPTION_STATUSinstead ofURGENT_BKOPS
- Add function to checkException_status(for eMMC4.5)
- remove unnecessary code.drivers/mmc/card/block.c | 9 +++++ drivers/mmc/card/queue.c | 4 ++ drivers/mmc/core/core.c | 87 ++++++++++++++++++++++++++++++++++++++++++++ drivers/mmc/core/mmc.c | 9 ++++- drivers/mmc/core/mmc_ops.c | 4 ++ include/linux/mmc/card.h | 12 ++++++ include/linux/mmc/core.h | 3 ++ include/linux/mmc/host.h | 1 + include/linux/mmc/mmc.h | 14 +++++++ 9 files changed, 142 insertions(+), 1 deletions(-)drivers/mmc/card/block.c +0
-0@@ -1192,6 +1192,15 @@ static int mmc_blk_issue_rw_rq(struct mmc_queue *mq, struct request *rqc)case MMC_BLK_SUCCESS :case MMC_BLK_PARTIAL :
drivers/mmc/card/block.c static int mmc_blk_issue_rw_rq(struct mmc_queue · line 1204
Quoted 10 lines
drivers/mmc/card/block.c +9
-0/* +* Check BKOPS urgency from each R1 response +*/ +if (mmc_card_mmc (card) && + (brq->cmd.resp[0 ] &R1_EXCEPTION_EVENT )) { +if (mmc_is_exception_event (card, +EXT_CSD_URGENT_BKOPS )) +mmc_card_set_need_bkops (card); + } +/*
Have you thought about moving this into mmc_wait_for_req_done()? We can check if the command is a R1 or R1B or not, and set BKOPS bit in there if needed. I was just thinking if we put such code here, we may only cover the successful scenario but not for the failed cases. Putting in mmc_wait_for_req_done can cover all cases.
Thanks
Chuanxiao
Quoted 53 lines · Chuanxiao
Hi Jaehoon,
Quoted 51 lines
-----Original Message-----
From: Jaehoon Chung [mailto:[email protected]]
Sent: Wednesday, November 02, 2011 6:29 PM
To: linux-mmc
Cc: Chris Ball; Kyungmin Park; Hanumath Prasad; Sebastian Rasmussen; Per Forlin; [email protected]; Dong, Chuanxiao
Subject: [PATCH v2] mmc: support BKOPS feature for eMMCEnable eMMC background operations (BKOPS) feature.
If
URGENT_BKOPSis set after a response, note that BKOPS are required. After all I/O requests are finished, run BKOPS if required. Should read/write operations be requested during BKOPS, first issue HPI to interrupt the ongoing BKOPS and then service the request.If you want to enable this feature, set
MMC_CAP2_BKOPS.Signed-off-by Jaehoon Chung <[email protected]>Signed-off-by Kyungmin Park <[email protected]>CC Hanumath Prasad <[email protected]>---
Changelog V2:
- UseEXCEPTION_STATUSinstead ofURGENT_BKOPS
- Add function to checkException_status(for eMMC4.5)
- remove unnecessary code.drivers/mmc/card/block.c | 9 +++++
drivers/mmc/card/queue.c | 4 ++
drivers/mmc/core/core.c | 87
++++++++++++++++++++++++++++++++++++++++++++
drivers/mmc/core/mmc.c | 9 ++++-
drivers/mmc/core/mmc_ops.c | 4 ++include/linux/mmc/card.h | 12 ++++++ include/linux/mmc/core.h | 3 ++ include/linux/mmc/host.h | 1 + include/linux/mmc/mmc.h | 14 +++++++ 9 files changed, 142 insertions(+), 1 deletions(-)drivers/mmc/card/block.c +0
-0@@ -1192,6 +1192,15 @@ static int mmc_blk_issue_rw_rq(struct mmc_queue *mq, struct request *rqc)case
MMC_BLK_SUCCESS:
caseMMC_BLK_PARTIAL:
/*
+ * Check BKOPS urgency from each R1 response
+ */
Quoted 9 lines
Quoted 7 lines
+ if (
mmc_card_mmc(card)&&
+ (brq->cmd.resp[0] &R1_EXCEPTION_EVENT)) {
+ if (mmc_is_exception_event(card,
+EXT_CSD_URGENT_BKOPS))
+mmc_card_set_need_bkops(card);
+ }
+ /*Have you thought about moving this into
mmc_wait_for_req_done()? We can check if the command is a R1 or R1B or not, and set BKOPS bit in there if needed. I was just thinking if we put such code here, we may only cover the successful scenario but not for the failed cases. Putting inmmc_wait_for_req_donecan cover all cases.
Good point! I'm in favor of this change.
Thanks,
Per
Quoted 64 lines · Per Forlin
Quoted 53 lines · Chuanxiao
Hi Jaehoon,
Quoted 51 lines
-----Original Message-----
From: Jaehoon Chung [mailto:[email protected]]
Sent: Wednesday, November 02, 2011 6:29 PM
To: linux-mmc
Cc: Chris Ball; Kyungmin Park; Hanumath Prasad; Sebastian Rasmussen; Per Forlin; [email protected]; Dong, Chuanxiao
Subject: [PATCH v2] mmc: support BKOPS feature for eMMCEnable eMMC background operations (BKOPS) feature.
If
URGENT_BKOPSis set after a response, note that BKOPS are required. After all I/O requests are finished, run BKOPS if required. Should read/write operations be requested during BKOPS, first issue HPI to interrupt the ongoing BKOPS and then service the request.If you want to enable this feature, set
MMC_CAP2_BKOPS.Signed-off-by Jaehoon Chung <[email protected]>Signed-off-by Kyungmin Park <[email protected]>CC Hanumath Prasad <[email protected]>---
Changelog V2:
- UseEXCEPTION_STATUSinstead ofURGENT_BKOPS
- Add function to checkException_status(for eMMC4.5)
- remove unnecessary code.drivers/mmc/card/block.c | 9 +++++
drivers/mmc/card/queue.c | 4 ++
drivers/mmc/core/core.c | 87
++++++++++++++++++++++++++++++++++++++++++++
drivers/mmc/core/mmc.c | 9 ++++-
drivers/mmc/core/mmc_ops.c | 4 ++include/linux/mmc/card.h | 12 ++++++ include/linux/mmc/core.h | 3 ++ include/linux/mmc/host.h | 1 + include/linux/mmc/mmc.h | 14 +++++++ 9 files changed, 142 insertions(+), 1 deletions(-)drivers/mmc/card/block.c +0
-0@@ -1192,6 +1192,15 @@ static int mmc_blk_issue_rw_rq(struct mmc_queue *mq, struct request *rqc)case
MMC_BLK_SUCCESS:
caseMMC_BLK_PARTIAL:
/*
+ * Check BKOPS urgency from each R1 response
+ */Quoted 9 lines
Quoted 7 lines
+ if (
mmc_card_mmc(card)&&
+ (brq->cmd.resp[0] &R1_EXCEPTION_EVENT)) {
+ if (mmc_is_exception_event(card,
+EXT_CSD_URGENT_BKOPS))
+mmc_card_set_need_bkops(card);
+ }
+ /*Have you thought about moving this into
mmc_wait_for_req_done()? We can check if the command is a R1 or R1B or not, and set BKOPS bit in there if needed. I was just thinking if we put such code here, we may only cover the successful scenario but not for the failed cases. Putting inmmc_wait_for_req_donecan cover all cases.
Quoted 1 line
Good point! I'm in favor of this change.
Or, put the check before the switch-case.
Quoted 80 lines
-----Original Message-----
From: Per Forlin [mailto:[email protected]]
Sent: Friday, November 11, 2011 4:32 PM
To: Dong, Chuanxiao
Cc: Jaehoon Chung; linux-mmc; Jae hoon Chung; Chris Ball; Kyungmin Park; Hanumath Prasad; Sebastian Rasmussen; [email protected]
Subject: Re: [PATCH v2] mmc: support BKOPS feature for eMMCQuoted 9 lines · Per Forlin
Quoted 7 lines · Chuanxiao
Hi Jaehoon,
Quoted 5 lines
-----Original Message-----
From: Jaehoon Chung [mailto:[email protected]]
Sent: Wednesday, November 02, 2011 6:29 PM
To: linux-mmc
Cc: Chris Ball; Kyungmin Park; Hanumath Prasad; Sebastian Rasmussen; PerForlin;
Quoted 35 lines
Quoted 35 lines
Quoted 35 lines
[email protected]; Dong, Chuanxiao
Subject: [PATCH v2] mmc: support BKOPS feature for eMMCEnable eMMC background operations (BKOPS) feature.
If
URGENT_BKOPSis set after a response, note that BKOPS are required. After all I/O requests are finished, run BKOPS if required. Should read/write operations be requested during BKOPS, first issue HPI to interrupt the ongoing BKOPS and then service the request.If you want to enable this feature, set
MMC_CAP2_BKOPS.Signed-off-by Jaehoon Chung <[email protected]>Signed-off-by Kyungmin Park <[email protected]>CC Hanumath Prasad <[email protected]>---
Changelog V2:
- UseEXCEPTION_STATUSinstead ofURGENT_BKOPS
- Add function to checkException_status(for eMMC4.5)
- remove unnecessary code.drivers/mmc/card/block.c | 9 +++++
drivers/mmc/card/queue.c | 4 ++
drivers/mmc/core/core.c | 87
++++++++++++++++++++++++++++++++++++++++++++
drivers/mmc/core/mmc.c | 9 ++++-
drivers/mmc/core/mmc_ops.c | 4 ++include/linux/mmc/card.h | 12 ++++++ include/linux/mmc/core.h | 3 ++ include/linux/mmc/host.h | 1 + include/linux/mmc/mmc.h | 14 +++++++ 9 files changed, 142 insertions(+), 1 deletions(-)Quoted 5 lines
Quoted 5 lines
drivers/mmc/card/block.c static int mmc_blk_issue_rw_rq(struct
Quoted 5 lines
drivers/mmc/card/block.c +0
-0@@ -1192,6 +1192,15 @@ static int mmc_blk_issue_rw_rq(struct
mmc_queueQuoted 8 lines
Quoted 8 lines
Quoted 8 lines
drivers/mmc/card/block.c +0
-0*mq, struct request *rqc)case
MMC_BLK_SUCCESS:
caseMMC_BLK_PARTIAL:
/*
+ * Check BKOPS urgency from each R1 response
+ */
+ if (mmc_card_mmc(card)&&
+ (brq->cmd.resp[0] &
R1_EXCEPTION_EVENT)) {Quoted 2 lines
Quoted 2 lines
Quoted 2 lines
+ if (mmc_is_exception_event(card,
+
EXT_CSD_URGENT_BKOPS))Quoted 1 line
Quoted 1 line
Quoted 1 line
+
mmc_card_set_need_bkops(card );Quoted 2 lines
Quoted 2 lines
Quoted 2 lines
+ }
+ /*
Quoted 8 lines
Quoted 1 line
Quoted 1 line
Have you thought about moving this into
mmc_wait_for_req_done()? We cancheck if the command is a R1 or R1B or not, and set BKOPS bit in there if needed. I was just thinking if we put such code here, we may only cover the successful scenario but not for the failed cases. Putting in
mmc_wait_for_req_donecan cover all cases.Quoted 2 lines
Quoted 1 line
Good point! I'm in favor of this change.
Or, put the check before the switch-case.
If we put in mmc_wait_for_req_done, then we can catch all R1 response command result not only for the READ/WRITE command, right? ERASE command is also using R1 response. However, I am not sure whether ERASE command can set the BKOPS Urgent bit for us. Anyway, I agree putting before switch-case is another good point.
Thanks
Chuanxiao
Quoted 81 lines · Chuanxiao
Quoted 81 lines
-----Original Message-----
From: Per Forlin [mailto:[email protected]]
Sent: Friday, November 11, 2011 4:32 PM
To: Dong, Chuanxiao
Cc: Jaehoon Chung; linux-mmc; Jae hoon Chung; Chris Ball; Kyungmin Park; Hanumath Prasad; Sebastian Rasmussen; [email protected]
Subject: Re: [PATCH v2] mmc: support BKOPS feature for eMMCQuoted 9 lines · Per Forlin
Quoted 7 lines · Chuanxiao
Hi Jaehoon,
Quoted 5 lines
-----Original Message-----
From: Jaehoon Chung [mailto:[email protected]]
Sent: Wednesday, November 02, 2011 6:29 PM
To: linux-mmc
Cc: Chris Ball; Kyungmin Park; Hanumath Prasad; Sebastian Rasmussen; PerForlin;
Quoted 35 lines
Quoted 35 lines
Quoted 35 lines
[email protected]; Dong, Chuanxiao
Subject: [PATCH v2] mmc: support BKOPS feature for eMMCEnable eMMC background operations (BKOPS) feature.
If
URGENT_BKOPSis set after a response, note that BKOPS are required. After all I/O requests are finished, run BKOPS if required. Should read/write operations be requested during BKOPS, first issue HPI to interrupt the ongoing BKOPS and then service the request.If you want to enable this feature, set
MMC_CAP2_BKOPS.Signed-off-by Jaehoon Chung <[email protected]>Signed-off-by Kyungmin Park <[email protected]>CC Hanumath Prasad <[email protected]>---
Changelog V2:
- UseEXCEPTION_STATUSinstead ofURGENT_BKOPS
- Add function to checkException_status(for eMMC4.5)
- remove unnecessary code.drivers/mmc/card/block.c | 9 +++++
drivers/mmc/card/queue.c | 4 ++
drivers/mmc/core/core.c | 87
++++++++++++++++++++++++++++++++++++++++++++
drivers/mmc/core/mmc.c | 9 ++++-
drivers/mmc/core/mmc_ops.c | 4 ++include/linux/mmc/card.h | 12 ++++++ include/linux/mmc/core.h | 3 ++ include/linux/mmc/host.h | 1 + include/linux/mmc/mmc.h | 14 +++++++ 9 files changed, 142 insertions(+), 1 deletions(-)Quoted 5 lines
Quoted 5 lines
drivers/mmc/card/block.c static int mmc_blk_issue_rw_rq(struct
Quoted 5 lines
drivers/mmc/card/block.c +0
-0@@ -1192,6 +1192,15 @@ static int mmc_blk_issue_rw_rq(struct
mmc_queueQuoted 8 lines
Quoted 8 lines
Quoted 8 lines
drivers/mmc/card/block.c +0
-0*mq, struct request *rqc)case
MMC_BLK_SUCCESS:
caseMMC_BLK_PARTIAL:
/*
+ * Check BKOPS urgency from each R1 response
+ */
+ if (mmc_card_mmc(card)&&
+ (brq->cmd.resp[0] &
R1_EXCEPTION_EVENT)) {Quoted 2 lines
Quoted 2 lines
Quoted 2 lines
+ if (mmc_is_exception_event(card,
+
EXT_CSD_URGENT_BKOPS))Quoted 1 line
Quoted 1 line
Quoted 1 line
+
mmc_card_set_need_bkops(card );Quoted 3 lines
Quoted 3 lines
Quoted 2 lines
+ }
+ /*Have you thought about moving this into
mmc_wait_for_req_done()? We can
Quoted 8 lines
Quoted 7 lines
check if the command is a R1 or R1B or not, and set BKOPS bit in there if needed. I was just thinking if we put such code here, we may only cover the successful scenario but not for the failed cases. Putting in
mmc_wait_for_req_donecan cover all cases.Quoted 2 lines
Quoted 1 line
Good point! I'm in favor of this change.
Or, put the check before the switch-case.
If we put in
mmc_wait_for_req_done, then we can catch all R1 response command result not only for the READ/WRITE command, right?
Yes I agree. The only reason for _not_ moving it to wait_for_req_done() would be if this response (URGENT_BKOPS) is directly connected to request handled by mmc_blk_issue_rw_rq() and no one else. I don't know the answer.
Quoted 1 line
ERASE command is also using R1 response.
I wasn't aware of this. Reading the R1 response should be done in wait_for_req_done().
Checking if the response is (URGENT_BKOPS) could still be done in mmc_blk_issue_rw_rq(), if this particular response only happens here. Otherwise that needs to be done in wait_for_req_done() too.
Thanks,
Per
Hi Chuanxiao,
Quoted 54 lines · Chuanxiao
Hi Jaehoon,
Quoted 52 lines
-----Original Message-----
From: Jaehoon Chung [mailto:[email protected]]
Sent: Wednesday, November 02, 2011 6:29 PM
To: linux-mmc
Cc: Chris Ball; Kyungmin Park; Hanumath Prasad; Sebastian Rasmussen; Per Forlin; [email protected]; Dong, Chuanxiao
Subject: [PATCH v2] mmc: support BKOPS feature for eMMCEnable eMMC background operations (BKOPS) feature.
If
URGENT_BKOPSis set after a response, note that BKOPS are required. After all I/O requests are finished, run BKOPS if required. Should read/write operations be requested during BKOPS, first issue HPI to interrupt the ongoing BKOPS and then service the request.If you want to enable this feature, set
MMC_CAP2_BKOPS.Signed-off-by Jaehoon Chung <[email protected]>Signed-off-by Kyungmin Park <[email protected]>CC Hanumath Prasad <[email protected]>---
Changelog V2:
- UseEXCEPTION_STATUSinstead ofURGENT_BKOPS
- Add function to checkException_status(for eMMC4.5)
- remove unnecessary code.drivers/mmc/card/block.c | 9 +++++ drivers/mmc/card/queue.c | 4 ++ drivers/mmc/core/core.c | 87 ++++++++++++++++++++++++++++++++++++++++++++ drivers/mmc/core/mmc.c | 9 ++++- drivers/mmc/core/mmc_ops.c | 4 ++ include/linux/mmc/card.h | 12 ++++++ include/linux/mmc/core.h | 3 ++ include/linux/mmc/host.h | 1 + include/linux/mmc/mmc.h | 14 +++++++ 9 files changed, 142 insertions(+), 1 deletions(-)drivers/mmc/card/block.c +3
-0@@ -1192,6 +1192,15 @@ static int mmc_blk_issue_rw_rq(struct mmc_queue *mq, struct request *rqc)case MMC_BLK_SUCCESS :case MMC_BLK_PARTIAL :/* +* Check BKOPS urgency from each R1 response +*/ + if (mmc_card_mmc(card) &&
Quoted 8 lines
drivers/mmc/card/block.c static int mmc_blk_issue_rw_rq(struct mmc_queue *mq, struct request *rqc) · line 1203
Quoted 6 lines
drivers/mmc/card/block.c +6
-0+ (brq->cmd.resp[0] & R1_EXCEPTION_EVENT)) { +if (mmc_is_exception_event (card, +EXT_CSD_URGENT_BKOPS )) +mmc_card_set_need_bkops (card); + } +/* Have you thought about moving this into
mmc_wait_for_req_done()? We can check if the command is a R1 or R1B or not, and set BKOPS bit in there if needed. I was just thinking if we put such code here, we may only cover the successful scenario but not for the failed cases. Putting inmmc_wait_for_req_donecan cover all cases.
Thanks for comment..I will move this into mmc_wait_for_req_done..and i will test. Then i will modify and resend the patch with your opinion
Best Regards,
Jaehoon Chung
Quoted 4 lines
Thanks
Chuanxiao