ARM: pxa168/gplugd: add the correct SSP device
Subsystems (3)
PATCH 1/1 ARM: pxa168/gplugd: add the correct SSP device
There is no SSP0, but SSP2 is used on gplugd.
--- arch/arm/mach-mmp/gplugd.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)
arch/arm/mach-mmp/gplugd.c +1 -1
@@ -182,7 +182,7 @@ static void __init gplugd_init(void)/* on-chip devices */ pxa168_add_uart (3 ); -pxa168_add_ssp (0 ); +pxa168_add_ssp (2 );pxa168_add_twsi (0 ,NULL ,ARRAY_AND_SIZE (gplugd_i2c_board_info));pxa168_add_eth (&gplugd_eth_platform_data);
Signature · 1 line
1.7.5.4
PATCH 1/1 ARM: pxa168/gplugd: add the correct SSP device
Quoted 13 lines · Eric Miao
There is no SSP0, but SSP2 is used on gplugd.
Cc Tanmay Upadhyay<[email protected]>Signed-off-by Eric Miao<[email protected]>--- arch/arm/mach-mmp/gplugd.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)arch/arm/mach-mmp/gplugd.c +0
-0
arch/arm/mach-mmp/gplugd.c static void __init gplugd_init(void) · line 188
Quoted 8 lines
arch/arm/mach-mmp/gplugd.c +1
-1@@ -182,7 +182,7 @@ static void __init gplugd_init(void)/* on-chip devices */ pxa168_add_uart (3 ); -pxa168_add_ssp (0 ); +pxa168_add_ssp (2 );pxa168_add_twsi (0 ,NULL ,ARRAY_AND_SIZE (gplugd_i2c_board_info));pxa168_add_eth (&gplugd_eth_platform_data);
Hi Eric,
HDMI chip (TDA9981A) on gplugD gets audio data from SSP0 - used as I2S. Page # 7 of [1] & page # 1 & 3 of [2] indicates this. SSP2 is also used on gplugD as SPI to talk to the NOR flash.
Thanks,
Tanmay
[1] http://www.globalscaletechnologies.com/download/gplugD-MBV2R1-web.pdf
[2] http://www.globalscaletechnologies.com/download/gplugD-IOV2R1-web.pdf
PATCH 1/1 ARM: pxa168/gplugd: add the correct SSP device
Quoted 24 lines · Tanmay Upadhyay
Quoted 21 lines · Eric Miao
There is no SSP0, but SSP2 is used on gplugd.
Cc Tanmay Upadhyay<[email protected]>Signed-off-by Eric Miao<[email protected]>---
?arch/arm/mach-mmp/gplugd.c | ? ?2 +-
?1 files changed, 1 insertions(+), 1 deletions(-)arch/arm/mach-mmp/gplugd.c +0
-0@@ -182,7 +182,7 @@ static void __init gplugd_init(void)? ? ? ?/* on-chip devices */
? ? ? ?pxa168_add_uart(3);
- ? ? ?pxa168_add_ssp(0);
+ ? ? ?pxa168_add_ssp(2);
? ? ? ?pxa168_add_twsi(0, NULL,ARRAY_AND_SIZE(gplugd_i2c_board_info));
Quoted 6 lines
Quoted 1 line
? ? ? ?pxa168_add_eth(&gplugd_eth_platform_data);
Hi Eric,
HDMI chip (TDA9981A) on gplugD gets audio data from SSP0 - used as I2S. Page # 7 of [1] & page # 1 & 3 of [2] indicates this.
Shouldn't this be SSP1 instead, if following the public PXA168 software manual (there is no SSP0, and the existing code doesn't suppport it)
Quoted 2 lines
SSP2 is also used on gplugD
as SPI to talk to the NOR flash.
If ignoring this port at this moment, how about the patch below?
ARM: pxa168/gplugd: add the correct SSP device
There is no SSP0, but SSP1 is used on gplugd as an I2S port.
arch/arm/mach-mmp/gplugd.c +1 -1
@@ -182,7 +182,7 @@ static void __init gplugd_init(void)/* on-chip devices */ pxa168_add_uart (3 ); -pxa168_add_ssp (0 ); +pxa168_add_ssp (1 );pxa168_add_twsi (0 ,NULL ,ARRAY_AND_SIZE (gplugd_i2c_board_info));pxa168_add_eth (&gplugd_eth_platform_data);
PATCH 1/1 ARM: pxa168/gplugd: add the correct SSP device
Quoted 24 lines · Eric Miao
Quoted 22 lines · Tanmay Upadhyay
Quoted 20 lines · Eric Miao
There is no SSP0, but SSP2 is used on gplugd.
Cc Tanmay Upadhyay<[email protected]>Signed-off-by Eric Miao<[email protected]>--- arch/arm/mach-mmp/gplugd.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)arch/arm/mach-mmp/gplugd.c +1
-1@@ -182,7 +182,7 @@ static void __init gplugd_init(void)/* on-chip devices */ pxa168_add_uart (3 ); -pxa168_add_ssp (0 ); +pxa168_add_ssp (2 );pxa168_add_twsi (0 ,NULL ,ARRAY_AND_SIZE (gplugd_i2c_board_info));
Quoted 7 lines
Quoted 5 lines
arch/arm/mach-mmp/gplugd.c static void __init gplugd_init(void) · line 188
Quoted 1 line
arch/arm/mach-mmp/gplugd.c +0
-0pxa168_add_eth (&gplugd_eth_platform_data);Hi Eric,
HDMI chip (TDA9981A) on gplugD gets audio data from SSP0 - used as I2S. Page # 7 of [1]& page # 1& 3 of [2] indicates this.
Shouldn't this be SSP1 instead, if following the public PXA168 software manual (there is no SSP0, and the existing code doesn't suppport it)
Ah! My bad! You are right. Current code doesn't support SSP0. It just starts from 1! Sorry I just missed it. :(
Quoted 3 lines
Quoted 2 lines
SSP2 is also used on gplugD
as SPI to talk to the NOR flash.If ignoring this port at this moment, how about the patch below?
It looks good. We should go with it.
Thanks,
Tanmay
Quoted 21 lines
ARM: pxa168/gplugd: add the correct SSP device
There is no SSP0, but SSP1 is used on gplugd as an I2S port.
Cc Tanmay Upadhyay<[email protected]>Signed-off-by Eric Miao<[email protected]>arch/arm/mach-mmp/gplugd.c +1
-1@@ -182,7 +182,7 @@ static void __init gplugd_init(void)/* on-chip devices */ pxa168_add_uart (3 ); -pxa168_add_ssp (0 ); +pxa168_add_ssp (1 );pxa168_add_twsi (0 ,NULL ,ARRAY_AND_SIZE (gplugd_i2c_board_info));pxa168_add_eth (&gplugd_eth_platform_data);
PATCH 1/1 ARM: pxa168/gplugd: add the correct SSP device
Quoted 43 lines · Tanmay Upadhyay
Quoted 30 lines · Eric Miao
Quoted 27 lines · On Sat, Nov 12, 2011 at 12:02 AM, Tanmay Upadhyay…
Quoted 21 lines · Eric Miao
There is no SSP0, but SSP2 is used on gplugd.
Cc Tanmay Upadhyay<[email protected]>Signed-off-by Eric Miao<[email protected]>---
?arch/arm/mach-mmp/gplugd.c | ? ?2 +-
?1 files changed, 1 insertions(+), 1 deletions(-)arch/arm/mach-mmp/gplugd.c +0
-0@@ -182,7 +182,7 @@ static void __init gplugd_init(void)? ? ? ?/* on-chip devices */
? ? ? ?pxa168_add_uart(3);
- ? ? ?pxa168_add_ssp(0);
+ ? ? ?pxa168_add_ssp(2);
? ? ? ?pxa168_add_twsi(0, NULL,ARRAY_AND_SIZE(gplugd_i2c_board_info));Quoted 1 line
? ? ? ?pxa168_add_eth(&gplugd_eth_platform_data);
Hi Eric,
Quoted 6 lines
Quoted 3 lines
HDMI chip (TDA9981A) on gplugD gets audio data from SSP0 - used as I2S. Page
# 7 of [1]& ?page # 1& ?3 of [2] indicates this.Shouldn't this be SSP1 instead, if following the public PXA168 software manual (there is no SSP0, and the existing code doesn't suppport it)
Ah! My bad! You are right. Current code doesn't support SSP0. It just starts from 1! Sorry I just missed it. :(
Quoted 6 lines
Quoted 4 lines
Quoted 2 lines
SSP2 is also used on gplugD
as SPI to talk to the NOR flash.If ignoring this port at this moment, how about the patch below?
It looks good. We should go with it.
Can I take your Acked-by?
PATCH 1/1 ARM: pxa168/gplugd: add the correct SSP device
Quoted 35 lines · Eric Miao
Quoted 33 lines · Tanmay Upadhyay
Quoted 31 lines · Eric Miao
Quoted 21 lines · Tanmay Upadhyay
Quoted 20 lines · Eric Miao
There is no SSP0, but SSP2 is used on gplugd.
Cc Tanmay Upadhyay<[email protected]>Signed-off-by Eric Miao<[email protected]>--- arch/arm/mach-mmp/gplugd.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)arch/arm/mach-mmp/gplugd.c +1
-1@@ -182,7 +182,7 @@ static void __init gplugd_init(void)/* on-chip devices */ pxa168_add_uart (3 ); -pxa168_add_ssp (0 ); +pxa168_add_ssp (2 );pxa168_add_twsi (0 ,NULL ,ARRAY_AND_SIZE (gplugd_i2c_board_info));Quoted 6 lines
arch/arm/mach-mmp/gplugd.c static void __init gplugd_init(void) · line 188
Quoted 1 line
arch/arm/mach-mmp/gplugd.c +0
-0pxa168_add_eth (&gplugd_eth_platform_data);Hi Eric,
HDMI chip (TDA9981A) on gplugD gets audio data from SSP0 - used as I2S. Page
# 7 of [1]& page # 1& 3 of [2] indicates this.Shouldn't this be SSP1 instead, if following the public PXA168 software manual (there is no SSP0, and the existing code doesn't suppport it)
Quoted 9 lines
Quoted 7 lines
Ah! My bad! You are right. Current code doesn't support SSP0. It just starts from 1! Sorry I just missed it. :(
Quoted 3 lines
Quoted 2 lines
SSP2 is also used on gplugD
as SPI to talk to the NOR flash.If ignoring this port at this moment, how about the patch below?
It looks good. We should go with it.
Can I take your Acked-by?
Yes. Thanks for taking care! Could you please also provide your feedback for a pending patch for gplugD USB [1]?
Thanks,
Tanmay
[1]
http://lists.arm.linux.org.uk/lurker/message/20110718.065211.c3b28958.en.html
PATCH 1/1 ARM: pxa168/gplugd: add the correct SSP device
Quoted 55 lines · Tanmay Upadhyay
Quoted 52 lines · Eric Miao
Quoted 49 lines · On Mon, Nov 14, 2011 at 1:05 PM, Tanmay Upadhyay…
Quoted 31 lines · Eric Miao
Quoted 28 lines · On Sat, Nov 12, 2011 at 12:02 AM, Tanmay Upadhyay…
Quoted 22 lines · Eric Miao
There is no SSP0, but SSP2 is used on gplugd.
Cc Tanmay Upadhyay<[email protected]>Signed-off-by Eric Miao<[email protected]>---
?arch/arm/mach-mmp/gplugd.c | ? ?2 +-
?1 files changed, 1 insertions(+), 1 deletions(-)arch/arm/mach-mmp/gplugd.c +0
-0@@ -182,7 +182,7 @@ static void __init gplugd_init(void)? ? ? ?/* on-chip devices */
? ? ? ?pxa168_add_uart(3);
- ? ? ?pxa168_add_ssp(0);
+ ? ? ?pxa168_add_ssp(2);
? ? ? ?pxa168_add_twsi(0, NULL,ARRAY_AND_SIZE(gplugd_i2c_board_info));Quoted 1 line
? ? ? ?pxa168_add_eth(&gplugd_eth_platform_data);
Hi Eric,
Quoted 6 lines
Quoted 3 lines
HDMI chip (TDA9981A) on gplugD gets audio data from SSP0 - used as I2S. Page
# 7 of [1]& ? ?page # 1& ? ?3 of [2] indicates this.Shouldn't this be SSP1 instead, if following the public PXA168 software manual (there is no SSP0, and the existing code doesn't suppport it)
Ah! My bad! You are right. Current code doesn't support SSP0. It just starts
from 1! Sorry I just missed it. :(Quoted 4 lines
Quoted 2 lines
SSP2 is also used on gplugD
as SPI to talk to the NOR flash.If ignoring this port at this moment, how about the patch below?
Quoted 7 lines
Quoted 4 lines
Quoted 1 line
It looks good. We should go with it.
Can I take your Acked-by?
Yes. Thanks for taking care! Could you please also provide your feedback for a pending patch for gplugD USB [1]?
Thanks. I will.
Quoted 8 lines
Thanks,
Tanmay
[1]
http://lists.arm.linux.org.uk/lurker/message/20110718.065211.c3b28958.en.html