Skip to contentSkip to conversation

Fix some spelling bugs in documentation and comments

PATCH In review Stefan Weil 2 participants 4 messages Nov 14, 2011

lore
Share & tools
lore

Stefan Weil

author
#0 lore raw

PATCH 2/2 Fix some spelling bugs in documentation and comments

My previous mail used a wrong address for qemu-devel, sorry.

Regards,
Stefan Weil

-------- Original-Nachricht --------
Betreff: [PATCH 1.0 2/2] Fix some spelling bugs in documentation and comments
Datum: Sun, 13 Nov 2011 22:24:27 +0100
Von: Stefan Weil <[email protected]>
An: [email protected]
CC: Anthony Liguori <[email protected]>, [email protected], Stefan Weil <[email protected]>

These errors were detected by codespell:

remaing -> remaining
soley -> solely
virutal -> virtual
seperate -> separate

libcacard.txt still needs some more patches.

Signed-off-by Stefan Weil<[email protected]>
---
 block-migration.c      |    2 +-
 docs/libcacard.txt     |    6 +++---
 docs/qapi-code-gen.txt |    2 +-
 3 files changed, 5 insertions(+), 5 deletions(-)
block-migration.c +1 -1
index 0bff075..5f10486 100644
@@ -521,7 +521,7 @@ static int is_stage2_completed(void)
 
         if ((remaining_dirty / bwidth)<=
             migrate_max_downtime()) {
-            /* finish stage2 because we think that we can finish remaing work
+            /* finish stage2 because we think that we can finish remaining work
                below max_downtime */
 
             return 1;
docs/libcacard.txt +3 -3
index ae010d2..296706a 100644
@@ -281,7 +281,7 @@ create card responses.
         VCardResponse *vcard_make_response(VCard7816Status status);
 
     This is the most basic function to get a response. This function will
-    return a response the consists soley one 2 byte status code. If that status
+    return a response the consists solely one 2 byte status code. If that status
     code is defined in card_7816t.h, then this function is guarrenteed to
     return a response with that status. If a cart type specific status code
     is passed and vcard_make_response fails to allocate the appropriate memory

@@ -327,7 +327,7 @@ and applet.
 
         int vcard_emul_get_login_count(VCard *card);
 
-    This function returns the the number of remaing login attempts for this
+    This function returns the the number of remaining login attempts for this
     card. If the card emulator does not know, or the card does not have a
     way of giving this information, this function returns -1.
 

@@ -373,7 +373,7 @@ functions:
 
   The options structure is built by another function in the virtual card
   interface where a string of virtual card emulator specific strings are
-  mapped to the options. The actual structure is defined by the virutal card
+  mapped to the options. The actual structure is defined by the virtual card
   emulator and is used to determine the configuration of soft cards, or to
   determine which physical cards to present to the guest.
docs/qapi-code-gen.txt +1 -1
index c0a9325..5831e37 100644
@@ -14,7 +14,7 @@ To map QMP-defined interfaces to the native C QAPI implementations,
 a JSON-based schema is used to define types and function
 signatures, and a set of scripts is used to generate types/signatures,
 and marshaling/dispatch code. The QEMU Guest Agent also uses these
-scripts, paired with a seperate schema, to generate
+scripts, paired with a separate schema, to generate
 marshaling/dispatch code for the guest agent server running in the
 guest.
Signature · 1 line
1.7.2.5
#1 lore raw
Quoted 10 lines · Stefan Weil
docs/libcacard.txt +0 -0
@@ -281,7 +281,7 @@ create card responses.
         VCardResponse *vcard_make_response(VCard7816Status status);

    This is the most basic function to get a response. This function will
-    return a response the consists soley one 2 byte status code. If that status
+    return a response the consists solely one 2 byte status code. If that status

"return a response that consists solely of one 2 byte status code"

Quoted 1 line

    code is defined in card_7816t.h, then this function is guarrenteed to

"guaranteed"

Quoted 1 line

    return a response with that status. If a cart type specific status code

"card type"

-- PMM

author
#2 lore raw

Am 14.11.2011 20:25, schrieb Peter Maydell:

Quoted 17 lines · Stefan Weil
Quoted 11 lines
docs/libcacard.txt +0 -1
@@ -281,7 +281,7 @@ create card responses.
        VCardResponse *vcard_make_response(VCard7816Status status);
 
    This is the most basic function to get a response. This function will
-    return a response the consists soley one 2 byte status code. If that

status
+ return a response the consists solely one 2 byte status code. If
that
status

"return a response that consists solely of one 2 byte status code"

Quoted 1 line

code is defined in card_7816t.h, then this function is guarrenteed to

Quoted 8 lines

"guaranteed"

Quoted 2 lines

return a response with that status. If a cart type specific
status code

"card type"

-- PMM

I noticed these, too - see my mail: "libcacard.txt still needs some more patches", but was not sure about the first one. Thanks for your feedback. It's always good to have a native speaker who shows us foreigners the right way of writing :-)

The file still needs more patches even after your changes (e.g. replacable), so I suggest that we proceed incrementally: first my patch, then your patch, then whoever wants ...

--- SW

#3 lore raw
Quoted 3 lines · Stefan Weil

The file still needs more patches even after your changes (e.g. replacable), so I suggest that we proceed incrementally: first my patch, then your patch, then whoever wants ...

If you like. I might submit a patch post 1.0.

-- PMM