Skip to contentSkip to conversation

mmc: sdhci-s3c: remove unnecessary code in sdhci_s3c_notify_change

PATCH New Jaehoon Chung 1 participant 1 message Nov 15, 2011

Subsystems (3)
MMC, SD and SDIO Secure digital host controller interface (SDHCI) driver Secure digital host controller interface (SDHCI) Samsung driver
lore
Share & tools
lore

Jaehoon Chung

author maintainer
#0 lore raw

PATCH 1/1 mmc: sdhci-s3c: remove unnecessary code in sdhci_s3c_notify_change

This patch is removed the DEVICE_DEAD flag for sdhci-s3c.

I didn't know why this flag is assigned.
If this flag is set When card is removed,
ENSDCLK bit in CLOCK control register is always set in sdhci_set_ios(). Because if device dead, be skipped set_ios.

Signed-off-by Jaehoon Chung <[email protected]>
Signed-off-by Kyungmin Park <[email protected]>
---
 drivers/mmc/host/sdhci-s3c.c |    2 --
 1 files changed, 0 insertions(+), 2 deletions(-)
drivers/mmc/host/sdhci-s3c.c +0 -2
index c992e4f..995b11d 100644
@@ -334,11 +334,9 @@ static void sdhci_s3c_notify_change(struct platform_device *dev, int state)
 		spin_lock_irqsave(&host->lock, flags);
 		if (state) {
 			dev_dbg(&dev->dev, "card inserted.\n");
-			host->flags &= ~SDHCI_DEVICE_DEAD;
 			host->quirks |= SDHCI_QUIRK_BROKEN_CARD_DETECTION;
 		} else {
 			dev_dbg(&dev->dev, "card removed.\n");
-			host->flags |= SDHCI_DEVICE_DEAD;
 			host->quirks &= ~SDHCI_QUIRK_BROKEN_CARD_DETECTION;
 		}
 		tasklet_schedule(&host->card_tasklet);