Skip to contentSkip to conversation

ath9k: rename ath9k_platform.h to ath_platform.h

PATCH In review Sangwook Lee 6 participants 8 messages Nov 15, 2011 – Nov 22, 2011

Subsystems (2)
MIPS Qualcomm Atheros ATH9K wireless driver
lore
Share & tools
lore

Sangwook Lee

author
#0 lore raw

PATCH 1/1 ath9k: rename ath9k_platform.h to ath_platform.h

The patch series proposes to rename ath9k_platform.h to "ath_platform.h This header file handles platform data used only for ath9k, but it can used by ath6k as well. We can take "wl12xx.h" as as a example. Please let us change this file name so that other Atheors WLANs use this file for their own platform data

Signed-off-by Sangwook Lee <[email protected]>
---
 arch/mips/ath79/dev-ar913x-wmac.c                  |    2 +-
 drivers/net/wireless/ath/ath9k/ahb.c               |    2 +-
 drivers/net/wireless/ath/ath9k/init.c              |    2 +-
 drivers/net/wireless/ath/ath9k/pci.c               |    2 +-
 include/linux/{ath9k_platform.h => ath_platform.h} |    0
 5 files changed, 4 insertions(+), 4 deletions(-)
 rename include/linux/{ath9k_platform.h => ath_platform.h} (100%)
arch/mips/ath79/dev-ar913x-wmac.c +1 -1
index 48f425a..bc8869c 100644
@@ -13,7 +13,7 @@
 #include <linux/delay.h>
 #include <linux/irq.h>
 #include <linux/platform_device.h>
-#include <linux/ath9k_platform.h>
+#include <linux/ath_platform.h>
 
 #include <asm/mach-ath79/ath79.h>
 #include <asm/mach-ath79/ar71xx_regs.h>
drivers/net/wireless/ath/ath9k/ahb.c +1 -1
index 85a54cd..d84bee6 100644
@@ -18,7 +18,7 @@
 
 #include <linux/nl80211.h>
 #include <linux/platform_device.h>
-#include <linux/ath9k_platform.h>
+#include <linux/ath_platform.h>
 #include "ath9k.h"
 
 static const struct platform_device_id ath9k_platform_id_table[] = {
drivers/net/wireless/ath/ath9k/init.c +1 -1
index af1b325..0c82aea 100644
@@ -16,7 +16,7 @@
 
 #include <linux/dma-mapping.h>
 #include <linux/slab.h>
-#include <linux/ath9k_platform.h>
+#include <linux/ath_platform.h>
 
 #include "ath9k.h"
drivers/net/wireless/ath/ath9k/pci.c +1 -1
index edb0b4b..2f031b8 100644
@@ -17,7 +17,7 @@
 #include <linux/nl80211.h>
 #include <linux/pci.h>
 #include <linux/pci-aspm.h>
-#include <linux/ath9k_platform.h>
+#include <linux/ath_platform.h>
 #include "ath9k.h"
 
 static DEFINE_PCI_DEVICE_TABLE(ath_pci_id_table) = {
include/linux/ath_platform.h renamed from include/linux/ath9k_platform.h +0 -0
similarity index 100%
rename from include/linux/ath9k_platform.h
rename to include/linux/ath_platform.h
Signature · 1 line
1.7.4.1
#1 lore raw
Quoted 3 lines · Sangwook Lee

The patch series proposes to rename ath9k_platform.h to "ath_platform.h This header file handles platform data used only for ath9k, but it can used by ath6k as well.

Adding the actual OpenWrt stakeholders. Is there any public hardware platform that uses this yet?

Luis

#2 lore raw

PATCH 1/1 ath9k: rename ath9k_platform.h to ath_platform.h

Quoted 6 lines · Luis R. Rodriguez
Quoted 3 lines · Sangwook Lee

The patch series proposes to rename ath9k_platform.h to "ath_platform.h This header file handles platform data used only for ath9k, but it can used by ath6k as well.

Adding the actual OpenWrt stakeholders. Is there any public hardware platform that uses this yet?

Same for ath5k, after discussing the issue on openwrt-devel (in June 2010) we decided to have a seperate _platform struct for each chip. However, I agree that this is unneeded redundancy and it would be nice to have things generalized in a single ath_platform.h.
The ALL0305 (based on Senao eap7660d board) currently uses ath5k_platform.

Cheers

Daniel

#3 lore raw
In reply to Luis R. Rodriguez

2011.11.15. 17:09 keltez?ssel, Luis R. Rodriguez ?rta:

Quoted 7 lines · Sangwook Lee
Quoted 3 lines

The patch series proposes to rename ath9k_platform.h to "ath_platform.h This header file handles platform data used only for ath9k, but it can used by ath6k as well.

Adding the actual OpenWrt stakeholders. Is there any public hardware platform that uses this yet?

It is used by the ath79 platform code in the mainline kernel, although only the AP81 reference board uses that for now. However the linux-mips tree also has code for the AP121 reference board, and that will use it as well.

Additionaly, we are using that in OpenWrt for several consumer boards which are based on the AR71xx/AR724x/AR913x SoCs.

-Gabor

#4 lore raw
In reply to Sangwook Lee

Hi Sangwook,

Quoted 5 lines · Sangwook Lee

The patch series proposes to rename ath9k_platform.h to "ath_platform.h This header file handles platform data used only for ath9k, but it can used by ath6k as well. We can take "wl12xx.h" as as a example. Please let us change this file name so that other Atheors WLANs use this file for their own platform data

ath9k and ath6kl are very different devices, I'm not sure if sharing a platfrom struct between the two is really a good idea. Most likely there is very little the two drivers can share. What are your plans here?

I myself was thinking that we would have include/linux/ath6kl.h dedicated just for ath6kl. That would makes things simpler.

Kalle

author
#5 lore raw

PATCH 1/1 ath9k: rename ath9k_platform.h to ath_platform.h

Hi Kalle, Luis

Quoted 9 lines · Kalle Valo

Hi Sangwook,

Quoted 5 lines · Sangwook Lee

The patch series proposes to rename ath9k_platform.h to "ath_platform.h This header file handles platform data used only for ath9k, but it can used by ath6k as well. We can take "wl12xx.h" as as a example. Please let us change this file name so that other Atheors WLANs use this file for their own platform data

Quoted 5 lines

ath9k and ath6kl are very different devices, I'm not sure if sharing a platfrom struct between the two is really a good idea. Most likely there is very little the two drivers can share. What are your plans here?

As you know, if ath6kl is not SDIO powered (in most of cases, including mine)
we need to use platform struct in order to control reset/power line, because ath6k is designed for mobile and embedded devices. so I found out that there is already header file for ath9k's platform struct.
How about using the one header file instead of "include/linux/ath9k_platform.h"
, and "include/linux/ath6k_platform.h" ?

Quoted 4 lines

I myself was thinking that we would have include/linux/ath6kl.h dedicated just for ath6kl. That would makes things simpler.

But since I don't know much about ath9k, if you want to make the separate

header
file for ath6kl's own struct, It would be fine as well.

Quoted 2 lines

Kalle

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.ath9k.org/pipermail/ath9k-devel/attachments/20111116/f45bfe32/attachment.htm

#6 lore raw

Hi Sangwook,

Quoted 20 lines · Sangwook Lee

On 15 November 2011 16:37, Kalle Valo <[email protected] <mailto:[email protected]>> wrote:

Hi Sangwook,

On 11/15/2011 01:23 PM, Sangwook Lee wrote:
> The patch series proposes to rename ath9k_platform.h to "ath_platform.h
> This header file handles platform data used only for ath9k, > but it can used by ath6k as well. We can take "wl12xx.h" as > as a example. Please let us change this file name so that > other Atheors WLANs use this file for their own platform data

ath9k and ath6kl are very different devices, I'm not sure if sharing a platfrom struct between the two is really a good idea. Most likely there is very little the two drivers can share. What are your plans here?

Quoted 4 lines

As you know, if ath6kl is not SDIO powered (in most of cases, including mine)
we need to use platform struct in order to control reset/power line, because ath6k is designed for mobile and embedded devices.

We have been actually planning to do the same, but it's still on our todo list. If you can do this it would be awesome.

Also we need to provide some clock configuration from the board file and I'm sure there will be more in the future. But let's start with the power control.

Quoted 11 lines

so I found out that there is already header file for ath9k's platform struct. How about using the one header file instead of "include/linux/ath9k_platform.h"
, and "include/linux/ath6k_platform.h" ?

I myself was thinking that we would have include/linux/ath6kl.h dedicated just for ath6kl. That would makes things simpler.

But since I don't know much about ath9k, if you want to make the separate header file for ath6kl's own struct, It would be fine as well.

Yeah, I really would like to use separate file for ath6kl.

Kalle

author
#7 lore raw

PATCH 1/1 ath9k: rename ath9k_platform.h to ath_platform.h

Hi Kalle

Quoted 26 lines · Kalle Valo

Hi Sangwook,

Quoted 14 lines · Sangwook Lee

On 15 November 2011 16:37, Kalle Valo <[email protected] <mailto:[email protected]>> wrote:

Hi Sangwook,

On 11/15/2011 01:23 PM, Sangwook Lee wrote:
> The patch series proposes to rename ath9k_platform.h to "ath_platform.h
> This header file handles platform data used only for ath9k, > but it can used by ath6k as well. We can take "wl12xx.h" as > as a example. Please let us change this file name so that > other Atheors WLANs use this file for their own platform data

Quoted 1 line

ath9k and ath6kl are very different devices, I'm not sure if sharing

a

Quoted 1 line

platfrom struct between the two is really a good idea. Most likely

there

Quoted 4 lines

is very little the two drivers can share. What are your plans here?

Quoted 8 lines
Quoted 4 lines

As you know, if ath6kl is not SDIO powered (in most of cases, including mine)
we need to use platform struct in order to control reset/power line, because ath6k is designed for mobile and embedded devices.

We have been actually planning to do the same, but it's still on our todo list. If you can do this it would be awesome.

I did it but because my hw2.0 AR6003 has another problem, I couldn't go further.
Simply I copied the same method from wl12xx wlan driver. (Maybe you might have know it)

You can run "grep" the following definition, which is used by Panda board. CONFIG_WL12XX_PLATFORM_DATA

It will increase small bits in WLAN driver but discard platform data from init section at booting time.

Also we need to provide some clock configuration from the board file and

Quoted 12 lines

I'm sure there will be more in the future. But let's start with the power control.

Quoted 9 lines

so I found out that there is already header file for ath9k's platform struct. How about using the one header file instead of "include/linux/ath9k_platform.h"
, and "include/linux/ath6k_platform.h" ?

I myself was thinking that we would have include/linux/ath6kl.h dedicated just for ath6kl. That would makes things simpler.

Quoted 7 lines
Quoted 2 lines

But since I don't know much about ath9k, if you want to make the separate header file for ath6kl's own struct, It would be fine as well.

Yeah, I really would like to use separate file for ath6kl.

Kalle

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.ath9k.org/pipermail/ath9k-devel/attachments/20111122/8116f624/attachment-0001.htm