ARM: pxa: fix missing linux/gpio.h include

PATCH New Daniel Mack 3 participants 5 messages Nov 16, 2011

Subsystems (3)

Arm (32-bit) Arm sub-architectures PXA2xx/PXA3xx support

lore

Share & tools

lore

Daniel Mack

author

2011-11-16 14:35 UTC #0 lore raw

PATCH 1/1 ARM: pxa: fix missing linux/gpio.h include

Fixes the following compile error:

arch/arm/mach-pxa/pxa3xx.c: In function 'pxa3xx_cpu_pm_suspend':
arch/arm/mach-pxa/pxa3xx.c:156: error: implicit declaration of function 'gpio_get_value' make[1]: *** [arch/arm/mach-pxa/pxa3xx.o] Error 1

Signed-off-by Daniel Mack <[email protected]>

Cc Haojian Zhuang <[email protected]>

Cc Eric Miao <[email protected]>

---

I didn't closely follow all recent patches around PXA, so it might be that this has already been cared for. Haojian?

 arch/arm/mach-pxa/pxa3xx.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

arch/arm/mach-pxa/pxa3xx.c +1 -0

index 3866d52..7cddd11 100644
@@ -19,6 +19,7 @@
 #include <linux/platform_device.h>
 #include <linux/irq.h>
 #include <linux/io.h>
+#include <linux/gpio.h>
 #include <linux/syscore_ops.h>
 #include <linux/i2c/pxa-i2c.h>

Signature · 1 line

1.7.7.1

Eric Miao

Applied

2011-11-16 14:52 UTC #1 lore raw

PATCH 1/1 ARM: pxa: fix missing linux/gpio.h include

Quoted 9 lines · Daniel Mack

Fixes the following compile error:
?arch/arm/mach-pxa/pxa3xx.c: In function 'pxa3xx_cpu_pm_suspend':
?arch/arm/mach-pxa/pxa3xx.c:156: error: implicit declaration of function 'gpio_get_value' ?make[1]: *** [arch/arm/mach-pxa/pxa3xx.o] Error 1
Signed-off-by Daniel Mack <[email protected]>
Cc Haojian Zhuang <[email protected]>
Cc Eric Miao <[email protected]>

Applied.

Quoted 24 lines

---
?I didn't closely follow all recent patches around PXA, so it might be that ?this has already been cared for. Haojian?
?arch/arm/mach-pxa/pxa3xx.c | ? ?1 +
?1 files changed, 1 insertions(+), 0 deletions(-)
arch/arm/mach-pxa/pxa3xx.c +0 -0
index 3866d52..7cddd11 100644
@@ -19,6 +19,7 @@
?#include <linux/platform_device.h>
?#include <linux/irq.h>
?#include <linux/io.h>
+#include <linux/gpio.h>
?#include <linux/syscore_ops.h>
?#include <linux/i2c/pxa-i2c.h>
--
1.7.7.1

Haojian Zhuang

maintainer

2011-11-16 15:03 UTC #2 lore raw

PATCH 1/1 ARM: pxa: fix missing linux/gpio.h include

In reply to Daniel Mack

Quoted 29 lines · Daniel Mack

Fixes the following compile error:
?arch/arm/mach-pxa/pxa3xx.c: In function 'pxa3xx_cpu_pm_suspend':
?arch/arm/mach-pxa/pxa3xx.c:156: error: implicit declaration of function 'gpio_get_value' ?make[1]: *** [arch/arm/mach-pxa/pxa3xx.o] Error 1
Signed-off-by Daniel Mack <[email protected]>
Cc Haojian Zhuang <[email protected]>
Cc Eric Miao <[email protected]>
---
?I didn't closely follow all recent patches around PXA, so it might be that ?this has already been cared for. Haojian?
?arch/arm/mach-pxa/pxa3xx.c | ? ?1 +
?1 files changed, 1 insertions(+), 0 deletions(-)
arch/arm/mach-pxa/pxa3xx.c +0 -0
index 3866d52..7cddd11 100644
@@ -19,6 +19,7 @@
?#include <linux/platform_device.h>
?#include <linux/irq.h>
?#include <linux/io.h>
+#include <linux/gpio.h>
?#include <linux/syscore_ops.h>
?#include <linux/i2c/pxa-i2c.h>

Quoted 9 lines

--
1.7.7.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel at lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

Hi Daniel,

At first, gpio_get_value() isn't used in arch/arm/mach-pxa/pxa3xx.c.

Which git tree and which branch are you using now? I tried my git tree, arnd/for-next, rmk/for-next. Everything is ok. I can't find any build issue.

Thanks
Haojian

Eric Miao

2011-11-16 15:08 UTC #3 lore raw

PATCH 1/1 ARM: pxa: fix missing linux/gpio.h include

Quoted 42 lines · Haojian Zhuang

Quoted 29 lines · Daniel Mack
Fixes the following compile error:
?arch/arm/mach-pxa/pxa3xx.c: In function 'pxa3xx_cpu_pm_suspend':
?arch/arm/mach-pxa/pxa3xx.c:156: error: implicit declaration of function 'gpio_get_value' ?make[1]: *** [arch/arm/mach-pxa/pxa3xx.o] Error 1
Signed-off-by Daniel Mack <[email protected]>
Cc Haojian Zhuang <[email protected]>
Cc Eric Miao <[email protected]>
---
?I didn't closely follow all recent patches around PXA, so it might be that ?this has already been cared for. Haojian?
?arch/arm/mach-pxa/pxa3xx.c | ? ?1 +
?1 files changed, 1 insertions(+), 0 deletions(-)
arch/arm/mach-pxa/pxa3xx.c +0 -0
index 3866d52..7cddd11 100644
@@ -19,6 +19,7 @@
?#include <linux/platform_device.h>
?#include <linux/irq.h>
?#include <linux/io.h>
+#include <linux/gpio.h>
?#include <linux/syscore_ops.h>
?#include <linux/i2c/pxa-i2c.h>
Quoted 9 lines
--
1.7.7.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel at lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
Hi Daniel,

Quoted 5 lines

At first, gpio_get_value() isn't used in arch/arm/mach-pxa/pxa3xx.c.
Which git tree and which branch are you using now? I tried my git tree, arnd/for-next, rmk/for-next. Everything is ok. I can't find any build issue.

Ouch! I didn't even give it a second thought to this obvious one-liner patch.

Daniel Mack

author

2011-11-16 15:30 UTC #4 lore raw

PATCH 1/1 ARM: pxa: fix missing linux/gpio.h include

Quoted 44 lines · Eric Miao

Quoted 42 lines · Haojian Zhuang
Quoted 33 lines · Daniel Mack
Fixes the following compile error:
arch/arm/mach-pxa/pxa3xx.c: In function 'pxa3xx_cpu_pm_suspend':
arch/arm/mach-pxa/pxa3xx.c:156: error: implicit declaration of function 'gpio_get_value' make[1]: *** [arch/arm/mach-pxa/pxa3xx.o] Error 1
Signed-off-by Daniel Mack <[email protected]>
Cc Haojian Zhuang <[email protected]>
Cc Eric Miao <[email protected]>
---
I didn't closely follow all recent patches around PXA, so it might be that this has already been cared for. Haojian?
 arch/arm/mach-pxa/pxa3xx.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)
arch/arm/mach-pxa/pxa3xx.c +1 -1
index 3866d52..7cddd11 100644
@@ -19,6 +19,7 @@
 #include <linux/platform_device.h>
 #include <linux/irq.h>
 #include <linux/io.h>
+#include <linux/gpio.h>
 #include <linux/syscore_ops.h>
 #include <linux/i2c/pxa-i2c.h>
 
--
1.7.7.1
Quoted 5 lines
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel at lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
Hi Daniel,

Quoted 7 lines

Quoted 5 lines
At first, gpio_get_value() isn't used in arch/arm/mach-pxa/pxa3xx.c.
Which git tree and which branch are you using now? I tried my git tree, arnd/for-next, rmk/for-next. Everything is ok. I can't find any build issue.
Ouch! I didn't even give it a second thought to this obvious one-liner patch.

Gash. Not my day. We have a stupid workaround in that file that is buried in a very old patch. Due to recent changes in mainline, this doesn't build anymore, but that is something I have to keep privately.

Thanks for the heads-up, and sorry. You can drop this patch.

Daniel