Should "N/A" dust bunnies be swept from fw_version?
Subsystems (2)
In the discussion on "enable virtio_net to return bus_info in ethtool -i consistent with emulated NICs" Ben Hutchings had the following feedback on what might go into bus_info:
Quoted 3 lines
Please use the existing 'not implemented' value, which is the empty
string. If you think ethtool should print some helpful message instead
of an empty string, please submit a patch for ethtool.
When I was sweeping in the .get_drvinfo routines, I noticed many drivers would return "N/A" for fw_version - presumably they were drivers for cards without firmware. Should those be removed to have the fw_version be the empty string, or should those sleeping dust bunnies be allowed to lie?
rick jones
Quoted 8 lines · Rick Jones
In the discussion on "enable
virtio_netto returnbus_infoin ethtool -i consistent with emulated NICs" Ben Hutchings had the following feedback on what might go intobus_info:Quoted 3 lines
Please use the existing 'not implemented' value, which is the empty
string. If you think ethtool should print some helpful message instead
of an empty string, please submit a patch for ethtool.
Quoted 5 lines
When I was sweeping in the .get_drvinfo routines, I noticed many drivers would return "N/A" for
fw_version- presumably they were drivers for cards without firmware. Should those be removed to have thefw_versionbe the empty string, or should those sleeping dust bunnies be allowed to lie?
I much prefer the empty string; the ethtool utility can turn that into a user-friendly placeholder if it's considered confusing.
Ben.
Signature · 3 lines
Ben Hutchings, Staff Engineer, Solarflare Not speaking for my employer; that's the marketing department's job. They asked us to note that Solarflare product names are trademarked.
Quoted 9 lines · Ben Hutchings
Quoted 8 lines · Rick Jones
In the discussion on "enable
virtio_netto returnbus_infoin ethtool -i consistent with emulated NICs" Ben Hutchings had the following feedback on what might go intobus_info:Quoted 3 lines
Please use the existing 'not implemented' value, which is the empty
string. If you think ethtool should print some helpful message instead
of an empty string, please submit a patch for ethtool.
Quoted 8 lines
Quoted 5 lines
When I was sweeping in the .get_drvinfo routines, I noticed many drivers would return "N/A" for
fw_version- presumably they were drivers for cards without firmware. Should those be removed to have thefw_versionbe the empty string, or should those sleeping dust bunnies be allowed to lie?I much prefer the empty string; the ethtool utility can turn that into a user-friendly placeholder if it's considered confusing.
Any other opinions out there? Anyone? Anyone?-)
rick jones
David Miller
maintainerFrom: Rick Jones <[email protected]>
Date: Fri, 18 Nov 2011 11:09:48 -0800
Quoted 22 lines · Ben Hutchings
Quoted 21 lines · Rick Jones
Quoted 19 lines
In the discussion on "enable
virtio_netto returnbus_infoin ethtool -i
consistent with emulated NICs" Ben Hutchings had the following feedback
on what might go intobus_info:Quoted 4 lines
Please use the existing 'not implemented' value, which is the empty string. If you think ethtool should print some helpful message instead
of an empty string, please submit a patch for ethtool.When I was sweeping in the .get_drvinfo routines, I noticed many drivers
would return "N/A" forfw_version- presumably they were drivers for cards without firmware. Should those be removed to have thefw_version
be the empty string, or should those sleeping dust bunnies be allowed to
lie?
Quoted 5 lines
Quoted 3 lines
I much prefer the empty string; the ethtool utility can turn that into a
user-friendly placeholder if it's considered confusing.Any other opinions out there? Anyone? Anyone?-)
I agree with Ben, just provide the empty string.
Quoted 25 lines · David Miller
From: Rick Jones<[email protected]>
Date: Fri, 18 Nov 2011 11:09:48 -0800Quoted 22 lines · Ben Hutchings
Quoted 21 lines · Rick Jones
Quoted 19 lines
In the discussion on "enable
virtio_netto returnbus_infoin ethtool -i
consistent with emulated NICs" Ben Hutchings had the following feedback
on what might go intobus_info:Quoted 4 lines
Please use the existing 'not implemented' value, which is the empty string. If you think ethtool should print some helpful message instead
of an empty string, please submit a patch for ethtool.When I was sweeping in the .get_drvinfo routines, I noticed many drivers
would return "N/A" forfw_version- presumably they were drivers for cards without firmware. Should those be removed to have thefw_version
be the empty string, or should those sleeping dust bunnies be allowed to
lie?
Quoted 7 lines
Quoted 5 lines
Quoted 3 lines
I much prefer the empty string; the ethtool utility can turn that into a
user-friendly placeholder if it's considered confusing.Any other opinions out there? Anyone? Anyone?-)
I agree with Ben, just provide the empty string.
OK, when I have time to pick-up my broom, I'll do some additional sweeping.
rick