Skip to contentSkip to conversation

Makefile: Add the missing dependency for spl target

PATCH New Aneesh V 2 participants 4 messages Nov 5, 2011 – Nov 18, 2011 Kbuild

lore
Share & tools
lore

Aneesh V

author
#0 lore raw

PATCH 1/1 Makefile: Add the missing dependency for spl target

Wolfgang's patch for build time improvement is bringing out issues due to missing dependencies in the top-level Makefile. I get errors such as the below while building with many threads.

make[1]: /home/a0393566local/u-boot-denx/tools/mkimage: Command not found

This also allows one to do:

$ make spl/u-boot-spl.bin
if you want to build only spl
Cc Wolfgang Denk <[email protected]>
---
 Makefile |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
Makefile +1 -1
index 82de62b..7ae8b22 100644
@@ -481,7 +481,7 @@ mmc_spl:	$(TIMESTAMP_FILE) $(VERSION_FILE) depend
 
 $(obj)mmc_spl/u-boot-mmc-spl.bin:	mmc_spl
 
-$(obj)spl/u-boot-spl.bin:		depend
+$(obj)spl/u-boot-spl.bin:	$(SUBDIR_TOOLS) depend
 		$(MAKE) -C spl all
 
 updater:
Signature · 1 line
1.7.1
author
#1 lore raw

PATCH 1/1 Makefile: Add the missing dependency for spl target

Hi Wolfgang,

Quoted 6 lines · Aneesh V

Wolfgang's patch for build time improvement is bringing out issues due to missing dependencies in the top-level Makefile. I get errors such as the below while building with many threads.

make[1]: /home/a0393566local/u-boot-denx/tools/mkimage: Command not found

Now that your build time improvement patch is up-stream omap and any other platform that uses any of the tools during SPL build may face occasional failures. Can you pull this one if my change looks ok?

Quoted 24 lines

This also allows one to do:

$ make spl/u-boot-spl.bin
if you want to build only spl
Cc Wolfgang Denk<[email protected]>
---
  Makefile |    2 +-
  1 files changed, 1 insertions(+), 1 deletions(-)
Makefile +1 -1
index 82de62b..7ae8b22 100644
@@ -481,7 +481,7 @@ mmc_spl:	$(TIMESTAMP_FILE) $(VERSION_FILE) depend
 
  $(obj)mmc_spl/u-boot-mmc-spl.bin:	mmc_spl
 
-$(obj)spl/u-boot-spl.bin:		depend
+$(obj)spl/u-boot-spl.bin:	$(SUBDIR_TOOLS) depend
  		$(MAKE) -C spl all
 
  updater:
author
#2 lore raw

PATCH 1/1 Makefile: Add the missing dependency for spl target

Dear Wolfgang,

Quoted 8 lines · Aneesh V

Hi Wolfgang,

Quoted 5 lines · Aneesh V

Wolfgang's patch for build time improvement is bringing out issues due to missing dependencies in the top-level Makefile. I get errors such as the below while building with many threads.

Quoted 5 lines
Quoted 1 line

make[1]: /home/a0393566local/u-boot-denx/tools/mkimage: Command not found

Now that your build time improvement patch is up-stream omap and any other platform that uses any of the tools during SPL build may face occasional failures. Can you pull this one if my change looks ok?

Gentle reminder. If you don't have any objections to this one could you consider pulling it. It avoids a build break.

br,
Aneesh

Quoted 26 lines
Quoted 25 lines

This also allows one to do:

$ make spl/u-boot-spl.bin
if you want to build only spl
Cc Wolfgang Denk<[email protected]>

---
Makefile | 2 +-

1 files changed, 1 insertions(+), 1 deletions(-)
Makefile +0 -0
index 82de62b..7ae8b22 100644
@@ -481,7 +481,7 @@ mmc_spl: $(TIMESTAMP_FILE) $(VERSION_FILE) depend
 

$(obj)mmc_spl/u-boot-mmc-spl.bin: mmc_spl

-$(obj)spl/u-boot-spl.bin: depend +$(obj)spl/u-boot-spl.bin: $(SUBDIR_TOOLS) depend $(MAKE) -C spl all

updater:

#3 lore raw

PATCH 1/1 Makefile: Add the missing dependency for spl target

In reply to Aneesh V
Quoted 10 lines · On Saturday 05 November 2011 08:43:33 Aneesh V wrote:

Wolfgang's patch for build time improvement is bringing out issues due to missing dependencies in the top-level Makefile. I get errors such as the below while building with many threads.

make[1]: /home/a0393566local/u-boot-denx/tools/mkimage: Command not found

This also allows one to do:

$ make spl/u-boot-spl.bin
if you want to build only spl

Applied to u-boot-staging sr at denx.de. Thanks.

Best regards,
Stefan

--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-0 Fax: (+49)-8142-66989-80 Email: office at denx.de